Post B63NKfqQ48iVCBB7Ls by azonenberg@ioc.exchange
 (DIR) More posts by azonenberg@ioc.exchange
 (DIR) Post #B63KZa1zf6t3eB0ZdI by azonenberg@ioc.exchange
       0 likes, 0 repeats
       
       Hmmm... How likely are platform specific memory safety issues in ngscopeclient/libscopehal? I'm thinking "not very" since almost all of the OS-specific stuff code is in third party portability libraries.I ask because right now we do all of our CI builds as optimized release builds with the intention of creating nightly builds other people can download and play with.But I want to do ASAN+debug builds to catch memory safety issues during tests (there was at least one that this could have caught in the past).The question is, do we double up *all* of the CI builds, using twice as much time/power? Or is it sufficient to do a *single* debug/sanitizer build, on one supported platform (probably one using llvmpipe to avoid monopolizing a real GPU)?
       
 (DIR) Post #B63M5yQSbBc8WhSkEK by penguin42@mastodon.org.uk
       0 likes, 0 repeats
       
       @azonenberg Why don't you spread it, like 1/3 of CI gets Linux ASAN, 1/3 gets Windows etc; or do it once a week or something.
       
 (DIR) Post #B63Ma0ss1Whuq14j1U by azonenberg@ioc.exchange
       0 likes, 0 repeats
       
       @penguin42 well I want to make it so that every CI configuration uploads non-sanitized installable binaries that we can have early adopters play with who want to be on the bleeding edge but don't want to compile from scratch.So anything I *also* build with sanitizers is an extra workload on top of the release builds I have to do for every platform.
       
 (DIR) Post #B63NDaB6jbpDavTQVk by penguin42@mastodon.org.uk
       0 likes, 0 repeats
       
       @azonenberg Sure it's an extra, but it doesn't need to be double; which is why I say do the ASAN stuff less often
       
 (DIR) Post #B63NGU146KkFLu9wqe by the_art_of_giving_up@mastodon.social
       0 likes, 0 repeats
       
       @azonenberg no idea about the answer to your question sorry, but, in yosys we run sanitizers on the merge queue so regular PR commits don't get sanitizers run on them but we won't merge leaks into main this way
       
 (DIR) Post #B63NKfqQ48iVCBB7Ls by azonenberg@ioc.exchange
       0 likes, 0 repeats
       
       @the_art_of_giving_up Makes sense.I'm gonna build out the sanitizer flow in the new CI pipeline and test it, we can figure out when and how often to run it later.