Post AnO8nnUcv17EjCmxMW by kagan@wandering.shop
 (DIR) More posts by kagan@wandering.shop
 (DIR) Post #AnO8nnUcv17EjCmxMW by kagan@wandering.shop
       2024-10-25T20:18:19Z
       
       1 likes, 1 repeats
       
       There is a value in making one's pull requests as small as possible. Among other things, it makes them easier for your colleagues to review.Unfortunately, "as small as possible" doesn't always mean "actually small".I'm currently looking at a PR that requires 30 files, because the ticket itself was to roll out an entire new feature. (And no, subdividing it wouldn't have made sense.)Ugh.Not everything decomposes into tiny increments. It sucks, but it's true.#work #webdev
       
 (DIR) Post #AnO8npjaaMGxgBnvxg by kagan@wandering.shop
       2024-10-25T20:40:48Z
       
       0 likes, 0 repeats
       
       OTOH, this particular co-worker of mine has helpfully left comments on large swathes of the changes, as part of his PR! Very nice, and very helpful!Definitely one of the kinds of people who I make sure to type "co-worker" for, because I don't want anyone to think for a moment that there's any possibility of him being a cow-orker. 😀