Post 2705225 by slp@mstdn.io
(DIR) More posts by slp@mstdn.io
(DIR) Post #2704871 by fdroidorg@mastodon.technology
2019-01-06T14:08:58Z
1 likes, 4 repeats
We need reviewers for new apps submitted as Merge Requests to #FDroid. There are over 40 pending MRs: https://gitlab.com/fdroid/fdroiddata/merge_requests?scope=all&utf8=%E2%9C%93&state=opened&search=new+app(or here as well: https://gitlab.com/fdroid/fdroiddata/merge_requests?scope=all&utf8=%E2%9C%93&state=opened&search=add)
(DIR) Post #2704922 by fdroidorg@mastodon.technology
2019-01-06T14:12:45Z
0 likes, 1 repeats
So what to do:1. Does the app look legitimate? Are the permissions it declares (AndroidManifest.xml) reasonable? The library dependencies (build.gradle) look okay?2. Does it build with fdroid build <appID>?3. Is there at least a description and Summary present in the metadata file? Also author name, website, donation information where applicable?
(DIR) Post #2705073 by gaditb@icosahedron.website
2019-01-06T14:22:43Z
0 likes, 0 repeats
@fdroidorg Is there are preference to skim over the code to see if it does anything which looks suspicious?
(DIR) Post #2705225 by slp@mstdn.io
2019-01-06T14:35:45Z
0 likes, 0 repeats
@fdroidorg I'll try to help with some of them later this week. 👍
(DIR) Post #2705298 by pl@mastodon.social
2019-01-06T14:38:57Z
0 likes, 0 repeats
@fdroidorg I'd suggest you to use labels for new apps, makes searching, milestone handling, etc in #GitLab really nice.https://docs.gitlab.com/ee/user/project/labels.html
(DIR) Post #2705322 by fdroidorg@mastodon.technology
2019-01-06T14:40:06Z
0 likes, 0 repeats
@gaditb That's a plus, and highly appreciated, yes.😊
(DIR) Post #2705489 by fdroidorg@mastodon.technology
2019-01-06T14:50:19Z
0 likes, 0 repeats
@pl Labled all I could find: https://gitlab.com/fdroid/fdroiddata/merge_requests?label_name%5B%5D=New+App
(DIR) Post #2712968 by therojam@chaos.social
2019-01-06T20:34:59Z
0 likes, 0 repeats
@fdroidorg how can people help?
(DIR) Post #2713557 by melunaka@eldritch.cafe
2019-01-06T21:05:58Z
0 likes, 0 repeats
@fdroidorg For the search you should use the label since not all MR that adds a new app contain «new app» in the title:https://gitlab.com/fdroid/fdroiddata/merge_requests?label_name%5B%5D=New+AppSo in fact there’s like ~60 MR for new app inclusion
(DIR) Post #2715307 by JonathanMM@mastodon.social
2019-01-06T22:04:48Z
0 likes, 0 repeats
@fdroidorg Why not add this todo list in the new app submission template?
(DIR) Post #2782137 by gdorn@social.coop
2019-01-08T22:28:08Z
0 likes, 0 repeats
@fdroidorg I'd be happy to help, but it's not clear what you need. If you need somebody to check on the four criteria (compliance, author notification, rfp/fdroiddata correctness, build sanity) that's probably something I can help out with. It looks like you might need a workflow of assigning MRs to volunteers to do the legwork.
(DIR) Post #2797727 by fdroidorg@mastodon.technology
2019-01-09T10:40:29Z
0 likes, 0 repeats
@gdorn See https://mastodon.technology/@fdroidorg/101370033920843399
(DIR) Post #2797760 by fdroidorg@mastodon.technology
2019-01-09T10:40:41Z
0 likes, 0 repeats
@therojam See https://mastodon.technology/@fdroidorg/101370033920843399
(DIR) Post #2797791 by therojam@chaos.social
2019-01-09T10:43:23Z
0 likes, 0 repeats
@fdroidorg thank you for this info.
(DIR) Post #9gbV7tmM8OhIQWcCLg by mondstern@mastodon.technology
2019-03-09T19:13:48Z
0 likes, 0 repeats
@fdroidorgmeine reviews sind die gemalten fdroid app Logos mit links :)