Fix one byte NULL stack overflow - quark - quark web server
(HTM) git clone git://git.suckless.org/quark
(DIR) Log
(DIR) Files
(DIR) Refs
(DIR) LICENSE
---
(DIR) commit d2013a6337972c62a71f01324e87af0e55579245
(DIR) parent 72b309bbe40444add563cdc37c0aa31386a4630d
(HTM) Author: Aaron Burrow <burrows@charstarstar.com>
Date: Mon, 16 Jul 2018 22:46:09 +0200
Fix one byte NULL stack overflow
Don't append a forward slash if the length of a folder is PATH_MAX-1. This can
happen if HEADER_MAX is larger than PATH_MAX or if the `-m` option is used to
increase the path length.
Diffstat:
M LICENSE | 1 +
M http.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
---
(DIR) diff --git a/LICENSE b/LICENSE
@@ -9,6 +9,7 @@ Copyright 2017-2018 Hiltjo Posthuma <hiltjo@codemadness.org>
Copyright 2017-2018 Quentin Rameau <quinq@fifth.space>
Copyright 2018 Josuah Demangeon <mail@josuah.net>
Copyright 2018 Dominik Schmidt <domischmidt@swissonline.ch>
+Copyright 2018 Aaron Burrow <burrows@charstarstar.com>
Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
(DIR) diff --git a/http.c b/http.c
@@ -430,7 +430,7 @@ http_send_response(int fd, struct request *r)
if (S_ISDIR(st.st_mode)) {
/* add / to target if not present */
len = strlen(realtarget);
- if (len == PATH_MAX - 2) {
+ if (len >= PATH_MAX - 2) {
return http_send_status(fd, S_REQUEST_TOO_LARGE);
}
if (len && realtarget[len - 1] != '/') {