tfix clang 3.4 warnings and ignore uninteresting ones - plan9port - [fork] Plan 9 from user space
(HTM) git clone git://src.adamsgaard.dk/plan9port
(DIR) Log
(DIR) Files
(DIR) Refs
(DIR) README
(DIR) LICENSE
---
(DIR) commit 6c7443a65369d0bd236d9eb19e59df6639c91eec
(DIR) parent 2763a6d8324fc5e1296e9a50a067ec04d52c581f
(HTM) Author: David du Colombier <0intro@gmail.com>
Date: Tue, 21 Oct 2014 14:22:12 +0200
fix clang 3.4 warnings and ignore uninteresting ones
fixed warnings:
src/cmd/fossil/disk.c:37:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:38:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:39:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:40:13: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/cmd/fossil/disk.c:41:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator]
src/libndb/ndbreorder.c:41:55: warning: for loop has empty body [-Wempty-body]
ignored warnings:
src/cmd/acid/dbg.y:393:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/lex/parser.y:886:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/rc/syn.y:303:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/cmd/units.y:1003:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
src/libregexp/regcomp.c:19:16: warning: variable 'reprog' is not needed and will not be emitted [-Wunneeded-internal-declaration]
LGTM=rsc
R=rsc
https://codereview.appspot.com/158250043
Diffstat:
M bin/9c | 2 ++
M src/cmd/fossil/disk.c | 10 +++++-----
M src/libndb/ndbreorder.c | 2 +-
3 files changed, 8 insertions(+), 6 deletions(-)
---
(DIR) diff --git a/bin/9c b/bin/9c
t@@ -67,6 +67,8 @@ useclang()
-Wno-unused-value \
-Wno-array-bounds \
-Wno-gnu-designator \
+ -Wno-array-bounds \
+ -Wno-unneeded-internal-declaration \
-fsigned-char \
-fno-caret-diagnostics \
"
(DIR) diff --git a/src/cmd/fossil/disk.c b/src/cmd/fossil/disk.c
t@@ -34,11 +34,11 @@ struct Disk {
/* keep in sync with Part* enum in dat.h */
static char *partname[] = {
- [PartError] "error",
- [PartSuper] "super",
- [PartLabel] "label",
- [PartData] "data",
- [PartVenti] "venti",
+ [PartError] = "error",
+ [PartSuper] = "super",
+ [PartLabel] = "label",
+ [PartData] = "data",
+ [PartVenti] = "venti",
};
Disk *
(DIR) diff --git a/src/libndb/ndbreorder.c b/src/libndb/ndbreorder.c
t@@ -38,7 +38,7 @@ ndbreorder(Ndbtuple *t, Ndbtuple *x)
if(x != last->line){
/* find entry before x */
- for(prev = last; prev->line != x; prev = prev->line);
+ for(prev = last; prev->line != x; prev = prev->line)
;
/* detach line */