cleanup - reportable - Fork of reportable required by WarVox, from hdm/reportable.
 (DIR) Log
 (DIR) Files
 (DIR) Refs
 (DIR) README
       ---
 (DIR) commit 9577b0d728079889d178694076d0bbcc6861eb3c
 (DIR) parent d48fcc5ad3dad4227a805cfe89c586958752e355
 (HTM) Author: Marco Otte-Witte <marco.otte-witte@simplabs.com>
       Date:   Thu, 15 Jan 2009 12:32:39 +0100
       
       cleanup
       
       Diffstat:
         M lib/kvlr/reports_as_sparkline/repo… |       9 +++++----
         M rdoc/classes/Kvlr/ReportsAsSparkli… |      31 ++++++++++++++++---------------
         M rdoc/created.rid                    |       2 +-
         M rdoc/files/lib/kvlr/reports_as_spa… |       2 +-
         M rdoc/files/lib/kvlr/reports_as_spa… |       2 +-
       
       5 files changed, 24 insertions(+), 22 deletions(-)
       ---
 (DIR) diff --git a/lib/kvlr/reports_as_sparkline/report.rb b/lib/kvlr/reports_as_sparkline/report.rb
       @@ -29,7 +29,8 @@ module Kvlr #:nodoc:
                @options = {
                  :limit      => options[:limit] || 100,
                  :conditions => options[:conditions] || [],
       -          :grouping   => Grouping.new(options[:grouping] || :day)
       +          :grouping   => Grouping.new(options[:grouping] || :day),
       +          :live_data  => options[:live_data] || false
                }
                @options.merge!(options)
                @options.freeze
       @@ -53,7 +54,7 @@ module Kvlr #:nodoc:
        
              private
        
       -        def read_data(begin_at, options) #:nodoc:
       +        def read_data(begin_at, options)
                  conditions = setup_conditions(begin_at, options[:conditions])
                  @klass.send(@aggregation,
                    @value_column,
       @@ -63,7 +64,7 @@ module Kvlr #:nodoc:
                  )
                end
        
       -        def setup_conditions(begin_at, custom_conditions = []) #:nodoc:
       +        def setup_conditions(begin_at, custom_conditions = [])
                  conditions = ['']
                  if custom_conditions.is_a?(Hash)
                    conditions = [custom_conditions.map{ |k, v| "#{k.to_s} = ?" }.join(' AND '), *custom_conditions.map{ |k, v| v }]
       @@ -74,7 +75,7 @@ module Kvlr #:nodoc:
                  conditions << begin_at
                end
        
       -        def ensure_valid_options(options, context = :initialize) #:nodoc:
       +        def ensure_valid_options(options, context = :initialize)
                  case context
                    when :initialize
                      options.each_key do |k|
 (DIR) diff --git a/rdoc/classes/Kvlr/ReportsAsSparkline/Report.html b/rdoc/classes/Kvlr/ReportsAsSparkline/Report.html
       @@ -218,11 +218,12 @@ records that match there conditions are reported on
        29:         <span class="ruby-ivar">@options</span> = {
        30:           <span class="ruby-identifier">:limit</span>      =<span class="ruby-operator">&gt;</span> <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:limit</span>] <span class="ruby-operator">||</span> <span class="ruby-value">100</span>,
        31:           <span class="ruby-identifier">:conditions</span> =<span class="ruby-operator">&gt;</span> <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:conditions</span>] <span class="ruby-operator">||</span> [],
       -32:           <span class="ruby-identifier">:grouping</span>   =<span class="ruby-operator">&gt;</span> <span class="ruby-constant">Grouping</span>.<span class="ruby-identifier">new</span>(<span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>] <span class="ruby-operator">||</span> <span class="ruby-identifier">:day</span>)
       -33:         }
       -34:         <span class="ruby-ivar">@options</span>.<span class="ruby-identifier">merge!</span>(<span class="ruby-identifier">options</span>)
       -35:         <span class="ruby-ivar">@options</span>.<span class="ruby-identifier">freeze</span>
       -36:       <span class="ruby-keyword kw">end</span>
       +32:           <span class="ruby-identifier">:grouping</span>   =<span class="ruby-operator">&gt;</span> <span class="ruby-constant">Grouping</span>.<span class="ruby-identifier">new</span>(<span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>] <span class="ruby-operator">||</span> <span class="ruby-identifier">:day</span>),
       +33:           <span class="ruby-identifier">:live_data</span>  =<span class="ruby-operator">&gt;</span> <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:live_data</span>] <span class="ruby-operator">||</span> <span class="ruby-keyword kw">false</span>
       +34:         }
       +35:         <span class="ruby-ivar">@options</span>.<span class="ruby-identifier">merge!</span>(<span class="ruby-identifier">options</span>)
       +36:         <span class="ruby-ivar">@options</span>.<span class="ruby-identifier">freeze</span>
       +37:       <span class="ruby-keyword kw">end</span>
        </pre>
                  </div>
                </div>
       @@ -262,16 +263,16 @@ you specify conditions here, caching will be disabled</b>)
                    onclick="toggleCode('M000010-source');return false;">[Source]</a></p>
                  <div class="method-source-code" id="M000010-source">
        <pre>
       -    <span class="ruby-comment cmt"># File lib/kvlr/reports_as_sparkline/report.rb, line 44</span>
       -44:       <span class="ruby-keyword kw">def</span> <span class="ruby-identifier">run</span>(<span class="ruby-identifier">options</span> = {})
       -45:         <span class="ruby-identifier">ensure_valid_options</span>(<span class="ruby-identifier">options</span>, <span class="ruby-identifier">:run</span>)
       -46:         <span class="ruby-identifier">custom_conditions</span> = <span class="ruby-identifier">options</span>.<span class="ruby-identifier">key?</span>(<span class="ruby-identifier">:conditions</span>)
       -47:         <span class="ruby-identifier">options</span>.<span class="ruby-identifier">reverse_merge!</span>(<span class="ruby-ivar">@options</span>)
       -48:         <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>] = <span class="ruby-constant">Grouping</span>.<span class="ruby-identifier">new</span>(<span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>]) <span class="ruby-keyword kw">unless</span> <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>].<span class="ruby-identifier">is_a?</span>(<span class="ruby-constant">Grouping</span>)
       -49:         <span class="ruby-constant">ReportCache</span>.<span class="ruby-identifier">process</span>(<span class="ruby-keyword kw">self</span>, <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:limit</span>], <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>], <span class="ruby-identifier">custom_conditions</span>) <span class="ruby-keyword kw">do</span> <span class="ruby-operator">|</span><span class="ruby-identifier">begin_at</span><span class="ruby-operator">|</span>
       -50:           <span class="ruby-identifier">read_data</span>(<span class="ruby-identifier">begin_at</span>, <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>], <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:conditions</span>])
       -51:         <span class="ruby-keyword kw">end</span>
       -52:       <span class="ruby-keyword kw">end</span>
       +    <span class="ruby-comment cmt"># File lib/kvlr/reports_as_sparkline/report.rb, line 45</span>
       +45:       <span class="ruby-keyword kw">def</span> <span class="ruby-identifier">run</span>(<span class="ruby-identifier">options</span> = {})
       +46:         <span class="ruby-identifier">ensure_valid_options</span>(<span class="ruby-identifier">options</span>, <span class="ruby-identifier">:run</span>)
       +47:         <span class="ruby-identifier">custom_conditions</span> = <span class="ruby-identifier">options</span>.<span class="ruby-identifier">key?</span>(<span class="ruby-identifier">:conditions</span>)
       +48:         <span class="ruby-identifier">options</span>.<span class="ruby-identifier">reverse_merge!</span>(<span class="ruby-ivar">@options</span>)
       +49:         <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>] = <span class="ruby-constant">Grouping</span>.<span class="ruby-identifier">new</span>(<span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>]) <span class="ruby-keyword kw">unless</span> <span class="ruby-identifier">options</span>[<span class="ruby-identifier">:grouping</span>].<span class="ruby-identifier">is_a?</span>(<span class="ruby-constant">Grouping</span>)
       +50:         <span class="ruby-constant">ReportCache</span>.<span class="ruby-identifier">process</span>(<span class="ruby-keyword kw">self</span>, <span class="ruby-identifier">options</span>, <span class="ruby-operator">!</span><span class="ruby-identifier">custom_conditions</span>) <span class="ruby-keyword kw">do</span> <span class="ruby-operator">|</span><span class="ruby-identifier">begin_at</span><span class="ruby-operator">|</span>
       +51:           <span class="ruby-identifier">read_data</span>(<span class="ruby-identifier">begin_at</span>, <span class="ruby-identifier">options</span>)
       +52:         <span class="ruby-keyword kw">end</span>
       +53:       <span class="ruby-keyword kw">end</span>
        </pre>
                  </div>
                </div>
 (DIR) diff --git a/rdoc/created.rid b/rdoc/created.rid
       @@ -1 +1 @@
       -Thu, 15 Jan 2009 12:00:12 +0100
       +Thu, 15 Jan 2009 12:32:28 +0100
 (DIR) diff --git a/rdoc/files/lib/kvlr/reports_as_sparkline/report_cache_rb.html b/rdoc/files/lib/kvlr/reports_as_sparkline/report_cache_rb.html
       @@ -56,7 +56,7 @@
            </tr>
            <tr class="top-aligned-row">
              <td><strong>Last Update:</strong></td>
       -      <td>Thu Jan 15 11:13:51 +0100 2009</td>
       +      <td>Thu Jan 15 12:20:10 +0100 2009</td>
            </tr>
            </table>
          </div>
 (DIR) diff --git a/rdoc/files/lib/kvlr/reports_as_sparkline/report_rb.html b/rdoc/files/lib/kvlr/reports_as_sparkline/report_rb.html
       @@ -56,7 +56,7 @@
            </tr>
            <tr class="top-aligned-row">
              <td><strong>Last Update:</strong></td>
       -      <td>Thu Jan 15 11:13:51 +0100 2009</td>
       +      <td>Thu Jan 15 12:32:02 +0100 2009</td>
            </tr>
            </table>
          </div>