Post AZ6G4eTtxwD4R3PbSS by mmstick@fosstodon.org
(DIR) More posts by mmstick@fosstodon.org
(DIR) Post #AZ6G4eTtxwD4R3PbSS by mmstick@fosstodon.org
2023-08-25T14:49:41Z
0 likes, 0 repeats
@lx @jgamble @soller This is not a normal code review by any means. If this is normal for you, then perhaps you need a career change.These comments in particular are really telling:> Ok, whatever your explanation for this is: I am not going to accept it, period.>> And, no, I am not going to dig through all your replies tryingto figure out your rationale for doing thisSo in effect, they don't understand what the device is or how it works, and don't care about supporting it.
(DIR) Post #AZ6G4fTEHvGZVG6a36 by shironeko@fedi.tesaguri.club
2023-08-25T20:14:34.014779Z
0 likes, 0 repeats
@mmstick > they don't understand what the device is or how it worksI'm not sure what's the problem here? Of course they won't understand what the device is or how it works, they probably never heard about it before this patch, let along have one/used one before. It would be the patch's job to explain this to the reader what the device does and how to make it work.> don't care about supporting it.and if the patch doesn't do that, then there's no way anyone other than the original author can support it, especially without access to the hardware. So the push to have all kinks worked out before it gets into mainline is understandable to me.Is the language too rude? yes, and that's a problem. But in terms of the substance of the review I don't see any issue.@lx @jgamble @soller
(DIR) Post #AZ6HG8cyK4Yp4WhB7w by mmstick@fosstodon.org
2023-08-25T20:21:44Z
0 likes, 0 repeats
@shironeko @jgamble @soller @lx I think you missed the point of a code review. That is not the issue. The person submitting the driver also designed the board in question, and works for the company that uses it in their Linux desktops. So the responsibility to maintain the driver is mainly with us.
(DIR) Post #AZ6HG9MLbMrBLFvPqy by shironeko@fedi.tesaguri.club
2023-08-25T20:27:55.350361Z
0 likes, 0 repeats
@mmstick The hwmon maintainer didn't design the board, so how are they supposed to understand what the thing does and how to make it work, other than by reading the patch? How are the random people that came after supposed to understand the code to fix/refactor it/etc if the subsystem maintainer can't even understand it?
(DIR) Post #AZ6HobuvvlhDl4XCJU by shironeko@fedi.tesaguri.club
2023-08-25T20:34:07.513897Z
0 likes, 0 repeats
@mmstick reply to the edit: once some code goes into the mainline, then it would ultimately be their responsibility to maintain. What if sys76 disappear? I really hope not (I like your stuff) but it's the state of affair for so many lines of code that is in mainline, the original author came and gone, and now it's just there rotting and a toll on the maintainers.
(DIR) Post #AZ6QH3gh4ekBczwxTE by mmstick@fosstodon.org
2023-08-25T20:41:47Z
0 likes, 0 repeats
@shironeko That's not really relevant to this. As I said to someone else, if the issue was merely that of wanting code comments, they could have simply requested a change to add detailed code comments.
(DIR) Post #AZ6QH4PMOaTNrWqd5k by shironeko@fedi.tesaguri.club
2023-08-25T22:08:55.559150Z
0 likes, 0 repeats
@mmstick I feel like we are talking past each other. do you mean that the patch is posted as a request for comments/draft?
(DIR) Post #AZ6d6CM1oHogj4R4Ay by mmstick@fosstodon.org
2023-08-25T22:16:08Z
0 likes, 0 repeats
@shironeko That's how the mailing list works.
(DIR) Post #AZ6d6D7AyzWx5IUifI by shironeko@fedi.tesaguri.club
2023-08-26T00:32:37.916265Z
0 likes, 0 repeats
@mmstick interesting, the way I read the thread I felt like the patch was more or less "complete"