Post AQ511DDF0BUXf0YoLI by mdbraber@mastodon.nl
 (DIR) More posts by mdbraber@mastodon.nl
 (DIR) Post #AQ2BYFQaCeRa9dJRce by shadowfacts@social.shadowfacts.net
       2022-11-27T16:16:14.950522Z
       
       0 likes, 0 repeats
       
       Does anyone know what could cause the mastodon API to return a notification that has a type of favourite/reblog but whose status property is null?I've been getting an increasing number of crash reports because I assume (reasonably, imo) that a fav/reblog notification always has an associated statusThe only explanation I can think of is if you delete a post after it was fav'd—but that removes the notification as well, like I'd expect
       
 (DIR) Post #AQ2C3vXDhSj9ixWTdg by libei@mastodon.social
       2022-11-27T16:17:55Z
       
       1 likes, 0 repeats
       
       @shadowfacts I encountered this crash too, no idea what happened.
       
 (DIR) Post #AQ2EopvMZrztqGJNMe by Gaelan@queer.party
       2022-11-27T16:32:34Z
       
       0 likes, 0 repeats
       
       @shadowfacts I wonder if you can fav a post after it's been deleted, like maybe the delete didn't properly federate to the fav-er's instance?
       
 (DIR) Post #AQ2EoqWwKA3TintNw0 by shadowfacts@social.shadowfacts.net
       2022-11-27T16:52:44.187603Z
       
       0 likes, 0 repeats
       
       @Gaelan in that case, a notification should never even be generated on the recipient side
       
 (DIR) Post #AQ2klkvZtYsi0fzFTM by gudenau@fosstodon.org
       2022-11-27T17:14:16Z
       
       0 likes, 0 repeats
       
       @shadowfacts Is there any way you could dump the raw payload when that happens? It might give you a hint.
       
 (DIR) Post #AQ2kllNwC7ZBQdFtg0 by shadowfacts@social.shadowfacts.net
       2022-11-27T22:50:50.808803Z
       
       0 likes, 0 repeats
       
       @gudenau I could, but that would be far more invasive automated reporting than I want to do
       
 (DIR) Post #AQ2rOPIwp3SfxwjPdI by gudenau@fosstodon.org
       2022-11-27T23:16:16Z
       
       0 likes, 0 repeats
       
       @shadowfacts You could just list the fields and the types. So something like {"id": 1234} could just be {"id": "int"}
       
 (DIR) Post #AQ2rOPm14yiJQ6KcwS by shadowfacts@social.shadowfacts.net
       2022-11-28T00:05:03.440085Z
       
       0 likes, 0 repeats
       
       @gudenau but then I just get {type: string, id: string, status: null, ...} which doesn't tell me anything I don't already know
       
 (DIR) Post #AQ2uizXK7fFZzVxkEi by gudenau@fosstodon.org
       2022-11-28T00:12:25Z
       
       0 likes, 0 repeats
       
       @shadowfacts If it's something stupid like a "status": int Vs "statuses": [int] or color Vs colour it would tell you.Other than that, no idea.
       
 (DIR) Post #AQ2uizv4hMFVBB4iG0 by shadowfacts@social.shadowfacts.net
       2022-11-28T00:42:23.400767Z
       
       0 likes, 0 repeats
       
       @gudenau I'm fairly confident it isn't a schema issue, since everything is getting decoded correctly
       
 (DIR) Post #AQ2ul83pOtgP0YBZE8 by shadowfacts@social.shadowfacts.net
       2022-11-28T00:42:42.783212Z
       
       0 likes, 0 repeats
       
       @joshua no, this is on a code path that's only accessible if the notification type is favourite/reblog
       
 (DIR) Post #AQ511DDF0BUXf0YoLI by mdbraber@mastodon.nl
       2022-11-28T21:10:40Z
       
       0 likes, 0 repeats
       
       @shadowfacts could it be this? http://github.com/mastodon/mastodon/issues/21292
       
 (DIR) Post #AQ511Do6n6yxVLoFo8 by mdbraber@mastodon.nl
       2022-11-28T21:11:46Z
       
       0 likes, 0 repeats
       
       @shadowfacts another explanation of that same problem that reminded me of your description: https://github.com/mastodon/mastodon/pull/18207
       
 (DIR) Post #AQ511EYtz8PdqThckC by shadowfacts@social.shadowfacts.net
       2022-11-29T01:02:19.899994Z
       
       0 likes, 0 repeats
       
       @mdbraber interesting, that might be related. I haven't tested with soft deletes (though I don't know how you even perform one from the UI?) so I wonder if that's the difference