Post 9rLORcHb8lpWBvcuRM by sir@cmpwn.com
(DIR) More posts by sir@cmpwn.com
(DIR) Post #9rGx1b4zW80XXGG65I by sir@cmpwn.com
2020-01-22T21:49:56Z
2 likes, 2 repeats
Seeking feedback on proposed design changes for sr.ht - see attached images for the before and after respectively.These changes would bring git.sr.ht up to spec with WCAG2 accessibility recommendations.
(DIR) Post #9rGxHUmegzCkdvGNOa by lanodan@queer.hacktivis.me
2020-01-22T21:53:29.547376Z
0 likes, 0 repeats
@sir Looks much better , now links are directly identifiable (also had to open them in tabs, mastofe's gallery isn't great for blink-diff)
(DIR) Post #9rGxRsnIHGMw0OVyng by sir@cmpwn.com
2020-01-22T21:54:43Z
1 likes, 0 repeats
For reference, today SourceHut and GitHub both score reasonably well, but not perfect; GitLab scores poorly; Gogs is very bad; Gerrit scores somewhat better than GitLab, but still poorly
(DIR) Post #9rGxcESEbEzM4zbE6i by kick@blob.cat
2020-01-22T21:57:14.575158Z
0 likes, 0 repeats
@sir It looks less nice but accessibility is commendable and aesthetics are worth sacrificing for it in any case.
(DIR) Post #9rGxiiM6LCwaYNp0MK by lanodan@queer.hacktivis.me
2020-01-22T21:58:24.536835Z
0 likes, 0 repeats
@sir Well even other than looks, Gitlab isn't really keyboard-accessible…
(DIR) Post #9rGy6OkesaqahebLRg by sir@cmpwn.com
2020-01-22T22:01:57Z
1 likes, 0 repeats
I was going to work on WIA-ARIA tags, too, but it turns out SourceHut is already basically good to go because it's already built out of semantically relevant HTML components, does very little magic, and doesn't use JavaScript to fiddle with things at runtime
(DIR) Post #9rGybrZ5nlqV2lC9mi by mauromorales@mastodon.social
2020-01-22T22:07:24Z
0 likes, 0 repeats
@sir looking good!
(DIR) Post #9rGyxudz2F0OxmzrhA by viralstitch@kind.social
2020-01-22T22:11:08Z
0 likes, 0 repeats
@sir I like the darker blue. Not sure how I feel about the link underlines, but they make links more identifiable that's a definite thumbs up from me.
(DIR) Post #9rH0zRY4NjnVDH5XWq by Wolf480pl@niu.moe
2020-01-22T22:34:55Z
0 likes, 0 repeats
@sir Would it be also ok if it was lighter blue with underlines?
(DIR) Post #9rH16As0n2WVVscr0S by sir@cmpwn.com
2020-01-22T22:36:08Z
0 likes, 0 repeats
@Wolf480pl no, the color issue is about readability and contrast, not about identifying links vs text
(DIR) Post #9rH1Q9xVt67GTjjF68 by Wolf480pl@niu.moe
2020-01-22T22:39:46Z
1 likes, 0 repeats
@sir eh... the dark blue IMO looks pretty bad and doesn't fit the rest of the style but if that's what it takes to make the thing accessible, so be it. Fuction > looks afterall.
(DIR) Post #9rH27md9z06Crw0gQC by val@oc.todon.fr
2020-01-22T22:46:00Z
1 likes, 0 repeats
@sir I didn't realize I got so used to links not having underline. I find underline kind of ugly now, but still think it's a good call
(DIR) Post #9rH2jGHYhZhTXvmFP6 by zethra@fosstodon.org
2020-01-22T22:53:32Z
0 likes, 0 repeats
@sir the changes look good to me
(DIR) Post #9rHHc0JRB2NrIoeZ4S by carl@linuxrocks.online
2020-01-23T01:40:17Z
0 likes, 0 repeats
@sir Do you recommend some resource to learn more about these recommendations and how to test?
(DIR) Post #9rHKKwvApg2Liwrb2u by tomleb@toot.cafe
2020-01-23T02:10:40Z
0 likes, 0 repeats
@sir I prefer the light blue but I wouldn't mind the darker one.Don't really like the underline, might be that I'm not yet used to it.. Is this necessary? The blue being used only for links make it pretty clear that blue text are links.
(DIR) Post #9rHNPKeIr2GwKrknYW by grmat@social.tchncs.de
2020-01-23T02:45:08Z
0 likes, 0 repeats
@sir did you miss the header/menu links (git, builds, todo, ...) or kept them without underline on purpose?
(DIR) Post #9rHRNwoaNpY1wU9uMq by aeolun@niu.moe
2020-01-23T03:29:42Z
0 likes, 0 repeats
@sir This looks basically the identical to me (slightly more visible links).
(DIR) Post #9rHXyFjw66Ygmrg9Ds by sir@cmpwn.com
2020-01-23T04:43:56Z
0 likes, 0 repeats
@carl chromium has a tester built in
(DIR) Post #9rIv2rFP4zGINQWRDk by flussence@nulled.red
2020-01-23T20:37:00Z
0 likes, 0 repeats
@sir The design was already really good to begin with.The only things I could suggest here are to make the "log ▸" a bit more verbose and/or whitespaced as it's the hardest target to hit on the screen, and maybe make the project name next to the Summary tab an extra link to the summary page.
(DIR) Post #9rIv9Ns0haC3I9gyUC by sir@cmpwn.com
2020-01-23T20:38:27Z
0 likes, 0 repeats
@flussence appreciate the feedback, thanks! I know they were good, but the change was motivated by accessibility. I'll put some thought into making log better but I don't think I'd like to have two summary links.
(DIR) Post #9rIvKsuTdYookHKVou by flussence@nulled.red
2020-01-23T20:40:24Z
0 likes, 0 repeats
@sir yeah that's understandable, I felt like I was being a bit pedantic with that latter idea
(DIR) Post #9rK2qtAt59ORfcAopk by nloomans@mastodon.technology
2020-01-24T09:38:59Z
0 likes, 0 repeats
@sir Interesting, I didn't know that X months ago was a link.Well I just tried it out and against my expectations it didn't link me to another page. Instead it just scrolls me to the commit I clicked X months ago on.What is the use case of this?
(DIR) Post #9rKLAx6LzRbaodlljc by danny@mastodon.dvk.co
2020-01-24T13:04:17Z
0 likes, 0 repeats
@sir For me they look exactly the same, with the latter definitely being easier on the eyes.
(DIR) Post #9rKOrV3SRUr493OXVg by sir@cmpwn.com
2020-01-24T13:45:55Z
0 likes, 0 repeats
@nloomans it's an anchor link so you can use it to link to that specific part of the page
(DIR) Post #9rLKTV9WDpjiq7UUro by adrianlshaw@mastodon.social
2020-01-25T00:31:15Z
0 likes, 0 repeats
@sir Gogs is very bad?
(DIR) Post #9rLLb4195qkQx7kD6u by nloomans@mastodon.technology
2020-01-25T00:43:53Z
0 likes, 0 repeats
@sir But these links will eventually break won't they? When enough commits have been added to push the linked commit to the next page. Also I'm not sure when one would want to link to a commit on the log/summery page instead of linking to the commit (diff) itself.And linking to one of the three commits on the summery page just feels silly.
(DIR) Post #9rLORcHb8lpWBvcuRM by sir@cmpwn.com
2020-01-25T01:16:02Z
0 likes, 0 repeats
@nloomans the reason this is here is because the commit box thing that link is inside of is a reusable component. If you file a ticket somewhere I'll look into a better approach when I get the chance.