Subj : binkd crashes when reloading after file change detection
To   : Wilfred van Velzen
From : mark lewis
Date : Thu Jan 20 2022 08:23 am


 On 2022 Jan 20 13:51:20, you wrote to me:

 ml>> as a test i stopped my binkd, edited my startup script to remove the
 ml>> "-C" option, and restarted it... then i edited my binkd-networks.conf
 ml>> file which is included as previously shown... 5 minutes later and
 ml>> binkd still has not noticed the change contrary to what the FAQ's last
 ml>> paragraph above states about the configs being re-read
 ml>> automatically...

 WV> I use a self compiled binkd:

same here...

 WV> # binkd -vv
 WV> Binkd 1.1a-111 (May 27 2020 16:10:25/Linux)
 WV> Compilation flags: gcc, zlib, bzlib2.
 WV> Facilities: fts5004 ipv6

$ binkd -vv
Binkd 1.1a-113 (Dec  7 2021 07:17:01/Linux)
Compilation flags: gcc, zlib, bzlib2, https, ntlm, bwlim.
Facilities: fts5004 ipv6

 WV> I start it with '-Cq' options,

'q'?? hummm... ahhh... quiet mode... ok... i run in a console terminal so i want to see all of that :)

-C is not working for me and is what my original message showing the "double free in " defect...

 WV> and a 'rescan-delay 3' in the config (not '3s' btw!).

[quote=binkd.conf-dist]
# Suffixes for time intervals are w for weeks, d for days,
# h for hours, m for minutes, s or no suffix for seconds.
# You can mix the suffixes, i.e. 1d12h is the same as 36h.
[/quote]

;)

 WV> It never crashes when I edit one of the config files, and never did so
 WV> with older versions...

that's interesting... what is your linux and compiler, please?

$ uname -a; echo; gcc --version
Linux sestar 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

my configure and compiling output appear to be ok for the most part... configure doesn't complain loudly about anything and compiling shows a few warnings about format-overflow where some things may possibly write more than 12 bytes to a region or destination of only 12 bytes in readcfg.c... the only other warning is a misleading indention in https.c where an if statement is apparently missing the "{}" around the two Log() lines it appears to be protecting... lines 372-374...

just to be sure, i've just pulled and built again but there were no changes since my last pull and update...

[remote "upstream"]
        url = https://github.com/pgul/binkd.git
        fetch = +refs/heads/*:refs/remotes/upstream/*


)\/(ark

"The soul of a small kitten in the body of a mighty dragon. Look on my majesty, ye mighty, and despair! Or bring me catnip. Your choice. Oooh, a shiny thing!"
.... Everyone has the right to act like an idiot. Some abuse the privilege.
---
 * Origin:  (1:3634/12.73)

.