Subj : binkd error
To   : Dan Cross
From : Max Vasilyev
Date : Sat Feb 08 2020 02:07 pm

Hello Dan!

06 Feb 20 15:06, you wrote to Tommi Koivula:

 TK>> https://github.com/fat-dragon/binkd.git and it compiled fine with
 TK>> gcc 3.3.5.
 DC> Ah, wonderful to hear. Thanks, other fellow.  :-)
Some words about your patch.

#ifndef sockaddr_storage
#define sockaddr_storage sockaddr_in
#endif

You don't need to add #ifndef here. There is no sockaddr_storage defined, if 
you have an old compiler without HAVE_GETADDRINFO/HAVE_GETADDRINFO.

#ifdef AF_INET6
  invalidAddresses[1].ss_family = AF_INET6;
#endif

It works with old gcc, but not with MSVC6.
I suggest to change it to #ifdef _SS_MAXSIZE.

WBR, Max. piwamoto!писем-нет
--- скучаю по FleetStreet'у :-(((
 * Origin: Personal Reality (2:5057/77)

.