Subj : Feature request
To   : Pavel Gulchouck
From : Michiel van der Vlist
Date : Mon May 16 2016 10:25 pm

Hello Pavel,

On Monday May 16 2016 18:24, you wrote to me:

 AK>>> You have to spend some time kicking the ass of 463/68. :)

 MvdV>> Then I will do that. ;-)

 PG> Got it. ;-)

Good. ;-)

 PG> In this particular case I doubt that this patch is really useful. On
 PG> most cases binkd is not multihomed, or it does not matter which local
 PG> IP address was used, so it's redundant information in the log,
 PG> obstructing to read it for most of sysops.

True, it may not be usefull for most binkd users. But that goes for a lot of 
features. Plus that as Andrew also noted, mutihoming may become more common in 
the future.

That it needlessly clutters the log for those that do not need it, can easely 
be remedied by making it an option.

# Log the ip adress to which an incoming connection is addressed.
# Useful in a multihomed setup or if binkp listens on more than one address.
#
# log-to-ip-on-incoming


 PG> IMHO it's make sense to log local IP if multiple "listen" keywords
 PG> specified in config. But you faced some problem in such configuration.
 PG> I'll try to catch it, but not sure.

It seems that the crashing has nothing to do with the multiple listen 
statements as such.

Several versions I ago I reported that the windows version of binkd crashed 
when started withe the -C option when the config changes. I reported this bug 
was no longer manifest in version  1.1a-92 and onwards.

It loooks like I was wrong. ;-( I tested it by touching an include file every 
five minutes. I let this run for a couple of weeks and it did not crash. But 
the test was wrong. It does indeed no longer crash when only the file date is 
changed, but I now found out that binkd still crashes occasianally when the 
/content/ of the config file or one of its includes changes. :-(

I now think that when it crashed when I entered multiple listen statements, it 
did not crash on the listen statements as such, but on the mere fact that the 
content of the config file was changed wile binkd was running with the -C 
option.

Testing continues...


Cheers, Michiel

--- GoldED+/W32-MSVC 1.1.5-b20130111
 * Origin: http://www.vlist.eu (2:280/5555)

.