I made a Tokyo Night emacs theme, and I need some feedback!
reddit / emacs

----------------------------------------------------------------------
ivan_linux · 2022-09-29 18:37

Hey folks. Recently I tried to make a emacs version of the Tokyo Night
theme for NeoVim, I think I did an okay job. I am mostly looking for
some feedback in how I can improve this theme (my first time writing
any custom emacs lisp). All suggestions/criticisms are welcome :D

[https://github.com/rawleyfowler/tokyo-
theme.el/](https://github.com/rawleyfowler/tokyo-theme.el/)

----------------------------------------------------------------------
nv-elisp · 2022-09-29 20:22

You have a syntax error in the `eval` of your flle local variables
which prevents the package from building properly.

This:

    ;; eval: (when (fboundp 'rainbow-mode (rainbow-mode +1))

Should be:

    ;; eval: (when (fboundp 'rainbow-mode) (rainbow-mode +1))


You also have some easy-to-fix linter warnings. I suggest turning on
flymake-mode in the source buffer or using the `checkdoc` command to
fix those.

You also need a space between `lexcial-binding:` and the `t` to enable
lexical binding for the file.

----------------------------------------------------------------------
ivan_linux · 2022-09-29 20:39

Thanks! I just pushed an update!

----------------------------------------------------------------------
agumonkey · 2022-09-29 20:42

just an excuse to show off your caml skills :p

----------------------------------------------------------------------
ivan_linux · 2022-09-29 20:49

If anyone wants to make improvements and get a PR in, the modeline is
not styled yet, and I have no idea how to do it!

----------------------------------------------------------------------
Schievel1 · 2022-09-29 21:50

Hey I use Tokyo night all the time. Love it because of the contrasts.

But sorry I have to say it :(
https://github.com/doomemacs/themes/blob/master/themes/doom-tokyo-
night-theme.el

Gonna try your theme  tommorow regardless

----------------------------------------------------------------------
ivan_linux · 2022-09-29 21:54

Don't you need doom to use that?

----------------------------------------------------------------------
Lucaskek · 2022-09-29 22:17

Nop you can use doom themes without doom

----------------------------------------------------------------------
ivan_linux · 2022-09-29 22:19

The more you know!

----------------------------------------------------------------------
[deleted] · 2022-09-30 02:35

[deleted]

----------------------------------------------------------------------
raskolnikov_104 · 2022-09-30 07:02

looks better than doom-tokyonight

----------------------------------------------------------------------
Freyr90 · 2022-09-30 07:53

Kudos for OCaml.

----------------------------------------------------------------------
Schievel1 · 2022-09-30 18:15

Yours is still closes to the original neo I'm theme I think

----------------------------------------------------------------------
Schievel1 · 2022-10-06 12:19

Tested it out real quick. I like your theme, but if you want this to
become more popular, add some instructions on how to use this.

e.g.https://github.com/Theory-of-Everything/everforest-
emacs#installation