Buffer overruns, license violations, and bad code: FreeBSD 13’s close call reddit / BSD ---------------------------------------------------------------------- minus_minus · 2021-03-26 14:59 > “I'd suffered through years of verbal abuse from non-doers” Anybody else smell a whiff of Ayn Rand coming off this crook? ---------------------------------------------------------------------- [deleted] · 2021-03-26 17:33 [deleted] ---------------------------------------------------------------------- cthart · 2021-03-26 18:36 There’s no way in h*ll I’m ever going to be using or recommending pfSense in the future. ---------------------------------------------------------------------- deux3xmachina · 2021-03-26 19:23 Thankfully OPNSense exists and should be an easy migration ---------------------------------------------------------------------- Tireseas · 2021-03-26 21:16 Yikes. Might be the biggest black eye for the project since FreeBSD 5.0's development cycle. ---------------------------------------------------------------------- BumpitySnook · 2021-03-26 22:35 This article is possibly the least accurate take on this situation lately. The LWN one is more accurate. ---------------------------------------------------------------------- [deleted] · 2021-03-27 00:16 [deleted] ---------------------------------------------------------------------- crocflamingo · 2021-03-27 02:56 good thing I use openbsd ---------------------------------------------------------------------- MultiplyAccumulate · 2021-03-27 04:41 Actually, kernel code written by convicted felons is potentially a serious issue. This code has access to all of your sensitive data and networks as well as that of various security conscious government entities. One of the concerns is the potential for the deliberate introduction of security holes access to which could then be sold or used for personal gain or revenge. And guess what, deliberate or not, the code includes security holes. We generally don't trust felons with patients, kids, money, inventory, prescription drugs, facility security/locks/security cameras, power over other people, etc. and jobs and even volunteer positions in those areas require criminal background checks. In fact there are so few jobs that can be done by someone untrustworthy that it is difficult to provide employment to ex-cons, let alone felons that the government has to pay employers about $9600 a year to hire a felon within one year of release. This is not to say they are all bad employees; some have gone straight and are very loyal to their companies. "40,000 lines"? That is about ten times the size of the real wireguard, last I heard. Indeed low code size is one of the points of wireguard. ---------------------------------------------------------------------- NoInterest4 · 2021-03-27 07:47 Wasn't the same story back in August with NetBSD? They had a complete new implementation of wg, though. How did that fly? ---------------------------------------------------------------------- Tireseas · 2021-03-27 11:29 If code review were actually a thing in this case trust would be a nonissue. ---------------------------------------------------------------------- 0O00O00O0O000OOO0O · 2021-03-27 13:10 I see that the following ports have been created: net/wireguard net/wireguard-kmod Is this the same code as described in the article or is this of better code quality? ---------------------------------------------------------------------- alien234 · 2021-03-27 13:15 Good thing I use the flinstones car instead of a tesla. You compare prehistoric chicken shit with no features with modern computing. ---------------------------------------------------------------------- [deleted] · 2021-03-27 14:58 [deleted] ---------------------------------------------------------------------- grahamperrin · 2021-03-27 14:59 `net/wireguard` is not new. https://lists.freebsd.org/pipermail/freebsd- hackers/2021-March/057118.html The links within the histories might help to summarise. ---------------------------------------------------------------------- grahamperrin · 2021-03-27 15:01 > The LWN one , yes? ---------------------------------------------------------------------- grahamperrin · 2021-03-27 15:04 For clarity: code *was* reviewed before the commit. Please, did the Ars Technica article lead to you to believe that no review occurred? ---------------------------------------------------------------------- grahamperrin · 2021-03-27 15:06 > All that casts a really bad light … Alternatively, for example, https://lobste.rs/s/sh2kcf/buffer_overruns _license_violations_bad#c_mvpnvk ---------------------------------------------------------------------- jurimasa · 2021-03-27 15:12 More like a stentch ---------------------------------------------------------------------- minus_minus · 2021-03-27 16:09 Ah, a man of culture. ---------------------------------------------------------------------- Tireseas · 2021-03-27 16:25 Obviously it was caught at some point. It got much farther than it should've for much longer. ---------------------------------------------------------------------- NitroNilz · 2021-03-27 16:26 Explanation of why it's out-of-tree now. https://lists.zx2c4.com/pipermail/wireguard/2021-March/006504.html ---------------------------------------------------------------------- BumpitySnook · 2021-03-27 16:36 Yes. ---------------------------------------------------------------------- BumpitySnook · 2021-03-27 16:41 > However, my personal belief is that neither Netgate, pfSense, nor the original developer deserved the level of scorn and criticism that they've received in the past days from both the press and the community at large. > Did the original implementation have issues? Yes, it did. 💯 ---------------------------------------------------------------------- grahamperrin · 2021-03-27 16:57 Such things happen, rarely. This is not to downplay the importance of review processes, but the past year or so *has* been extraordinary. Food for thought: https://lo bste.rs/s/sh2kcf/buffer_overruns_license_violations_bad#c_mvpnvk ---- My current priority is to determine whether https://lists.freebsd.org/pipermail/freebsd- current/2021-March/079272.html is a bug in FreeBSD `13.0-RC3`; in FreeBSD `14.0-CURRENT`; in VirtualBox `6.1.18`; in the recent port of `6.1.18⋯` (the first port of `6.⋯`) to FreeBSD; my chosen configuration for the guest; or some combination of the five. There's a somewhat provocative subject line to my e-mail, which some might view as careless. Some carelessness with words was largely contributory to the recent controversy involving WireGuard, so I should know better, but we're all human :-) ---------------------------------------------------------------------- Tireseas · 2021-03-27 17:35 Fair enough. The best thing that can be done is to use it as a learning experience to inform how the process can be improved in the future not only for FreeBSD but for other projects with similar needs and challenges. ---------------------------------------------------------------------- [deleted] · 2021-03-28 08:37 [deleted] ---------------------------------------------------------------------- grahamperrin · 2021-03-28 16:14 +1 > … a learning experience to inform how the process can be improved in the future [statement on FreeBSD development processes](https://lists.freebsd.org/pipermail/freebsd- hackers/2021-March/057127.html) ◀ [discussion](https://old.reddit.com/ r/freebsd/comments/mf33tb/statement_on_freebsd_development_processes/) > not only for FreeBSD but for other projects with similar needs and challenges. ---------------------------------------------------------------------- grahamperrin · 2021-03-28 16:19 /u/0O00O00O0O000OOO0O … I omitted a relevant link: (the text that appears following installation of the port or package): > For FreeBSD < 12.1 only the userland implementation wireguard-go is available. > > For FreeBSD >= 12.1 we default to use the kernel module if_wg(4). > > If you experience problems with it you can switch back to wireguard- go by removing net/wireguard-kmod and making sure net/wireguard-go is installed. > > The userland tools wg-quick(8) and wg(8) try to use kernel support if the kernel module is available and otherwise fall back to wireguard-go automatically. Config files are fully compatible. ---------------------------------------------------------------------- grahamperrin · 2021-03-28 17:18 💯 ---------------------------------------------------------------------- semanticallysatiated · 2021-04-09 12:46 That's a completely pointless comparison. A better one would be you wouldn't race a tank round a race track, or take a ferrari to a war zone.