I think it's a Bug
lazarus / 9-Editor

----------------------------------------------------------------------
JLWest · 2019-10-25 19:55

Opened the Lazarus IDE with current project.

Added a button to the form. Went to the source editor and opened up a
large section 40 lines ofe of blank lines near the top of the code
section. Went back to the form and doubled clicked on the new button.
Returned to the IDE and I bow had a large number of empty procedures
and functions matching procedures and functions I have in the unit but
without code.

Example:
procedure TForm1.ListBox1Click(Sender: TObject);
  begin

 end; 

                               
procedure TForm1.ListBox1Click(Sender: TObject);
 Var i : Integer = -1;
  Format     : String =  '';
  FileName   : String = 'FileList.txt';
  Path       : String = '';
  Item       : String = '';
  Bit1       : String = '';
 begin
  i := ListBox1.ItemIndex;
  if i = -1 then begin Exit; end;
  Listbox2.Clear;
  Item := Listbox1.Items;
  Bit1 := Copy2SpaceDel(Item);
  Bit1 := Trim(Bit1);
  Item := Trim(Item);
  Path := Copy2SpaceDel(Item);
  Path := Trim(Path);
  Format := Trim(Item);
  Editxx.Text := Format;
  FileName := Path + Bit1;
  LoadFile(FILENAME,Listbox2);
 end;

----------------------------------------------------------------------
Thaddy · 2019-10-25 20:18

If you did not manually edited config or form files then it is a bug.

----------------------------------------------------------------------
JLWest · 2019-10-25 21:42

No I didn't.

The steps described are pretty acurate.

----------------------------------------------------------------------
Thaddy · 2019-10-25 21:52

Then report it. (note I can not reproduce it) It may well be a bug.

----------------------------------------------------------------------
GAN · 2019-10-25 22:04

I have had similar issue too, empty procedures (OnClick), but no empty
lines.
I thought it was my fault for being distracted. It doesn't always
happen, so it's hard to reproduce.

----------------------------------------------------------------------
JuhaManninen · 2019-10-26 06:44

Quote from: GAN on October 26, 2019, 12:04:21 amIt doesn't always
happen, so it's hard to reproduce.
In a bug report we would need clear steps to reproduce. Bugs that are
hard to reproduce are also very difficult to fix.

----------------------------------------------------------------------
Thaddy · 2019-10-26 07:08

If the versions in your signature are still correct it may already be
fixed: I can/will not test against Lazarus 1.8.2 anymore. Current is
Lazarus 2.0.4 and 2.0.6 will soon be released.
"JLWEST
Lazuras ver 2.0.2  <------????
 FPC 3.0.4, Lazarus IDE v1.8.2" <-------???

----------------------------------------------------------------------
JLWest · 2019-10-26 15:51

Lazarus is v2.0.2

----------------------------------------------------------------------
Thaddy · 2019-10-26 15:53

So it may already be fixed? You are using an un-maintained version.
And there won't be any fixes for that.

----------------------------------------------------------------------
Martin_fr · 2019-10-26 17:40

Looking at the merges since 2.0.2 ... unlikely it is fixed.

And reporting issues from a recent fixes release, is definitely ok. If
that means occasionally an reported issue can be closed because it is
fixed already, so be it. (reporting for 1.8 would be a bit
outdated...)

The issue here is reproducibility...

But before that, I am not actually sure what exactly happened?


Lets assume you have code like
Code: Pascal  [Select][+][-]window.onload = function(){var x1 =
document.getElementById("main_content_section"); if (x1) { var x =
document.getElementsByClassName("geshi");for (var i = 0; i   TForm1 =
class(TForm)  private  public    procedure foo;  end; And you do not
yet have a body for "foo" (not even an empty body)

Now if you create an event on that form (from the designer / object
inspector), then the IDE does do a completion for that class. (shift
ctrl C)
It will create the body for "foo".

But if I understand this, then your form did have 
TForm1.ListBox1Click but this already had an implementation?
Yet a 2nd empty implementation was created?

If so then it will need reproducibility to fix.
Codetools have a copy of the source, that is updated on demand. This
may have failed. Or codetool had the correct copy, but did not parse
it....
Or maybe something else, I am no expert on codetools.

If you can not reproduce it, but it happens again: Collect at least
the following info.
- as very first action in the IDE: view > ide internals > show
codetool node info => content of all 3 tabs
- Whatever you did/changed
- source file after change / then use undo, source before change

----------------------------------------------------------------------
Thaddy · 2019-10-26 17:45

As I said on my platforms I can not reproduce it.

----------------------------------------------------------------------
aducom · 2019-10-26 18:03

I had/have the same issues. One cause (afaik) is when you have a
declaration like procedure myfunction; but have implemented it as
procedure myfunction(); It will not generate a syntax error, but under
certain circumstances, it will generate (duplicate) empty function
prototypes. Same for the other way around.
Hope this helps.

----------------------------------------------------------------------
JLWest · 2019-10-27 07:12

I'm not reporting the issue if it is an issue.

You know if everyone is called a equus asinus that will probably cut
down on the reported issues. Worked in my case.