Ignored patches? lazarus / 8-Other ---------------------------------------------------------------------- JuhaManninen · 2013-05-03 16:29 I went through many bug reports and patches in them. I applied many and rejected some. The open issue count in now little under 1600 for Lazarus project which is still much. I remember a while ago it was 1000. Does anyone know of more valid patches that should be applied? ... and yes, more patches are welcome. ---------------------------------------------------------------------- Timewarp · 2013-05-03 18:48 Atleast patch for bug 20361 should be applied. It fixes many PNG images. In FPC there are many. 21916 remains without further feedback. Why, patch can't possibly hurt anyone. Lazarus is useless regarding some Photoshop jpg images, and there is no workaround other than compile fpc your self (or just use Delphi) I could sometimes look into bugs / suggest patches. But when patches are ignored without comments for months, it's kind of disappointing and seems waste of time. ---------------------------------------------------------------------- Chronos · 2013-05-03 20:26 It is always good to hear that time spent on creating patches are not wasted. Are you able also apply FPC patches or just Lazarus ones? Sometimes problems are not only with IDE or LCL but also with FCL. But frankly fixing FCL and FPC is rather more complicated as FPC behave as separated product which is somehow integrated to Lazarus with different directory organization. On Linux it is even installed as multiple separated packages. Then usage of custom fpc downloaded from svn with Lazarus is a trial of intellect. It is not as easy as open fpc project and hit Ctrl+F9 to build it. ---------------------------------------------------------------------- JuhaManninen · 2013-05-03 21:18 Quote from: Timewarp on May 03, 2013, 08:48:00 pmAtleast patch for bug 20361 should be applied. It fixes many PNG images. There are competing patches from ocean and José Mejuto, and one older patch from ocean. Which one is good? QuoteI could sometimes look into bugs / suggest patches. But when patches are ignored without comments for months, it's kind of disappointing and seems waste of time. Yes it is bad and nobody wants it. As you can see I try to improve the situation. One reason for this situation is that Lazarus is big and some parts of the code are not well known by anybody. The author has left or is busy with other things, and other developers think like "somebody else knows this code better". I don't know much of the graphics libs, I feel uncomfortable applying patches there. I can still do it as we have many testers here. IMO some of the regular graphics contributors could well get write access to SVN. It seems like many graphics related patches are waiting for long. ---------------------------------------------------------------------- JuhaManninen · 2013-05-03 21:28 Quote from: Chronos on May 03, 2013, 10:26:48 pmIt is always good to hear that time spent on creating patches are not wasted. Are you able also apply FPC patches or just Lazarus ones? Sometimes problems are not only with IDE or LCL but also with FCL. I can do only Lazarus. QuoteBut frankly fixing FCL and FPC is rather more complicated as FPC behave as separated product which is somehow integrated to Lazarus with different directory organization. On Linux it is even installed as multiple separated packages. Then usage of custom fpc downloaded from svn with Lazarus is a trial of intellect. It is not as easy as open fpc project and hit Ctrl+F9 to build it. The many (like 44) .deb packages is a Debian policy. There is now also a single package for FPC and another for its sources, made by Mattias. Sometimes different FPC versions require IFDEFs in Lazarus code but it is not a big problem. ---------------------------------------------------------------------- Timewarp · 2013-05-04 08:51 QuoteWhich one is good? Just apply last by José.. Also results can be verified by using testsuite you added few days ago There are also bugs, where it's not clear how or what should be done. Like bug 24222 needs decisions, or it's going to remain open forever. QuoteAs you can see I try to improve the situation.Thanks, who would the same for FPC? ---------------------------------------------------------------------- JuhaManninen · 2013-05-04 09:41 Quote from: Timewarp on May 04, 2013, 10:51:40 amJust apply last by José.. Also results can be verified by using testsuite you added few days ago Done in r41020. QuoteThere are also bugs, where it's not clear how or what should be done. Like bug 24222 needs decisions, or it's going to remain open forever. There is no patch. What kind of decision you mean? QuoteThanks, who would the same for FPC? Good question. Ask the FPC development team. ---------------------------------------------------------------------- Timewarp · 2013-05-04 10:41 QuoteThere is no patch. What kind of decision you mean? Comment 0066783, Remove them, or add support? Third is doing nothing. (Best option would have been to remove them immediately, when problem was first discovered over a year ago. Waiting has made it more difficult) I meant, for some bugs there is no chance for a patch, if it's not first clear what it should do. ---------------------------------------------------------------------- JuhaManninen · 2013-05-04 12:10 Quote from: Timewarp on May 04, 2013, 12:41:09 pmComment 0066783, Remove them, or add support? Third is doing nothing. (Best option would have been to remove them immediately, when problem was first discovered over a year ago. Waiting has made it more difficult) Lazarus is primarily cross-platform. Removing such cross-platform functions is not a good idea. To me it looks like moving the functions to lclintf is the right choice. It already ports many Windows functions the same way. See lcl/lclintf.pas, lcl/include/winapih.inc, lcl/include/winapi.inc I added a note also to the issue report. ---------------------------------------------------------------------- marcov · 2013-05-04 15:51 Quote from: Chronos on May 03, 2013, 10:26:48 pm  On Linux it is even installed as multiple separated packages. Then usage of custom fpc downloaded from svn with Lazarus is a trial of intellect. This is not true. The FPC reference release is a single .tar.  You probably mean some 3rd party distro specific packages. QuoteIt is not as easy as open fpc project and hit Ctrl+F9 to build it. It never will, because compiler self compile defies that. Of course you can put a complete build system somewhere (like Delphi tries with MSBUILD), but that doesn't make it prettier or more transparent than the current situation. I think GUI helpers like FPCUP are a better direction for this. Basically friendly scripting to automate the tasks to do, but not as terse as make. ---------------------------------------------------------------------- jwdietrich · 2013-05-05 11:01 The bug 0023982 is still open, although wp uploaded a patch that solves the problem. ---------------------------------------------------------------------- JuhaManninen · 2013-05-05 11:32 Quote from: jwdietrich on May 05, 2013, 01:01:22 pmThe bug 0023982 is still open, although wp uploaded a patch that solves the problem. I don't know anything of TAChart code and it is assigned to its author. This is a bit of gray area. Can you please add a note on the issue confirming that the patch works. I will apply it in few days if "Ask" has not reacted. ---------------------------------------------------------------------- zamtmn · 2013-05-05 16:36 Small patch http://bugs.freepascal.org/view.php?id=23968 increases LazFreeType usability left unattended ---------------------------------------------------------------------- JuhaManninen · 2013-05-05 18:03 Quote from: zamtmn on May 05, 2013, 06:36:17 pmSmall patch http://bugs.freepascal.org/view.php?id=23968 increases LazFreeType usability left unattended Thanks. I applied it. Felipe and "Ask" are the experts in this area but they seem to be busy. ---------------------------------------------------------------------- zamtmn · 2013-05-05 18:07 JuhaManninen Thank you!