Bug Verification
lazarus / 64-FPC development

----------------------------------------------------------------------
taazz · 2018-09-16 03:16

I would like to verify that the following is a bug or if not what I
missunderstood.
Unit  :fpexprpars.pas
proc :TFPExpressionParser.Primitive
Line  : 1721 highlighted bellow.
Code: Pascal  [Select][+][-]window.onload = function(){var x1 =
document.getElementById("main_content_section"); if (x1) { var x =
document.getElementsByClassName("geshi");for (var i = 0; i     if
TryStrToInt64(CurrentToken,I) then     
Result:=TFPConstExpression.CreateInteger(I)    else      begin     
Val(CurrentToken,X,C);      If (I=0) then       
Result:=TFPConstExpression.CreateFloat(X)      else       
ParserError(Format(SErrInvalidFloat,[CurrentToken]));      end;   
end according my reading  skills I would expect the line to read If
(C=0) then instead of I. Is my assumption correct?

PS:
  the code comes from a lazarus 1.8.4 64bit installation. So if its a
bug I need confirmation that its still present in trunk before I
report it.

----------------------------------------------------------------------
WooBean · 2018-09-16 06:23

Hello  tazz,

in my opinion it is a bug and it is harmful when CurrentToken cannot
be parsed to int64 nor float value. In such a case snipped line 9.
"ParserError(Format(SErrInvalidFloat,[CurrentToken]));" is not called
despite it should be - according to a common logic.


The bug, definitely

WooBean

----------------------------------------------------------------------
zamtmn · 2018-09-16 06:29

Yes, it present in trunk https://svn.freepascal.org/cgi-
bin/viewvc.cgi/trunk/packages/fcl-base/src/fpexprpars.pp?view=markup

I confirm, this is a bug (typo)

----------------------------------------------------------------------
taazz · 2018-09-16 11:56

Thank you gentlemen, I'll report it later tonight if there is no
active report on the subject.