[SOLVED] Simplified function TPasRecordType.IsAdvancedRecord: Boolean;
lazarus / 64-FPC development

----------------------------------------------------------------------
lagprogramming · 2023-11-23 16:28

packages/fcl-passrc/src/pastree.pp has
Code: Pascal  [Select][+][-]window.onload = function(){var x1 =
document.getElementById("main_content_section"); if (x1) { var x =
document.getElementsByClassName("geshi");for (var i = 0; i function
TPasRecordType.IsAdvancedRecord: Boolean; Var  I : Integer;  Member:
TPasElement; begin  Result:=False;  I:=0;  While (Not Result) and
(I<Members.Count) do    begin    Member:=TPasElement(Members[i]);   
if (Member.Visibility<>visPublic) then exit(true);    if
(Member.ClassType<>TPasVariable) then exit(true);    Inc(I);   
end;end;The while loop contains a useless "(Not Result)" condition.
The result is false at the loop entry and it's changed only using
"exit(true);" statements.
The attached patch changes "While (Not Result) and (I<Members.Count)
do" to "While I<Members.Count do".

----------------------------------------------------------------------
AlexTP · 2023-11-23 17:09

Reported to
https://gitlab.com/freepascal.org/fpc/source/-/issues/40539