Generic AVLTree
lazarus / 62-General

----------------------------------------------------------------------
Pascal · 2017-06-27 10:20

I am just porting unit Laz_AVL_Tree to generics.
Where should i put it to be suitable for integration into FPC?
Generics.Trees? Generics.Collections?

----------------------------------------------------------------------
hnb · 2017-06-27 11:05

Rather Generics.Collections. The preferred way for large code base is
separate .inc, maybe generics.treesh.inc (interface) and
generics.trees.inc (implementation) like for dictionaries. Interface
of TAVLTree can be changed in the future in the case when Delphi also
implements it (so AVLTree tree must be marked as experimental). Be
aware that Integration isn't sure so 3rd library might be also good
idea (can be integrated in any time, when will be finished).

----------------------------------------------------------------------
Thaddy · 2017-06-27 13:57

@Pascal
Yes, just like Maciej wrote. Keep in mind the conventions that are
already in place for rtl-generics.

----------------------------------------------------------------------
Pascal · 2017-06-27 14:06

Quote from: Thaddy on June 27, 2017, 03:57:08 pm@Pascal
Yes, just like Maciej wrote. Keep in mind the conventions that are
already in place for rtl-generics.
Which conventions do you mean? Delphi mode?

----------------------------------------------------------------------
Thaddy · 2017-06-27 14:27

No, I mean the way how it is structured and the means that are already
provided. Outside of the units it doesn't really matter what syntax
you use in your own units.
What I am referring to is to keep the code consistent if you
eventually want to have it included in rtl-generics (which is indeed
in delphi mode,not quirks mode)