LHelp changes
lazarus / 5-Lazarus Extra Components

----------------------------------------------------------------------
AlexTP · 2009-06-03 11:14

i modified LHelp source (Andrew Haines) a little. Added:

- View - Show panel: working and hides panel like in MS viewer
- graying items (File - Close, etc.) working
- Help - About item added

how can I contact Andrew H. for changes to submit?

----------------------------------------------------------------------
Paul Ishenin · 2009-06-03 14:19

LHelp is included into lazarus svn. Feel free to submit a patch to the
bug tracker. If you have problems with the bug tracker then submit
your changes here. Any developer can review/commit them.

----------------------------------------------------------------------
AlexTP · 2009-06-03 18:32

chmcontentprovider.pas
--------

Code: [Select]after
    procedure GoHome; override;
    procedure GoBack; override;
    procedure GoForward; override;
add
    property TabsControl: TPageControl read fTabsControl;

lhelpcore.pas/.lfm
---------
many changes. I put my file here:
http://atorg.net.ru/temp/lh.zip
Pls view changes.

----------------------------------------------------------------------
AlexTP · 2009-06-07 16:12

Anybody can post changes to Laz tracker? Thanks.

----------------------------------------------------------------------
Drewski · 2009-06-08 01:20

Hi, yes anyone can open an account to submit bugs and attach patches.
I'm looking at your patch now to see what has changed. As you said
there are many changes.

Regards,

Andrew Haines

----------------------------------------------------------------------
Drewski · 2009-06-08 01:51

OK First thanks for taking the time to improve lhelp.

Second, it looks like you've made changes to a release version or
older snapshot of lazarus. Which means the files you posted are out of
date so it's hard to see the changes you've made.

Please use a svn version of lazarus and make a patch.

http://wiki.lazarus.freepascal.org/Getting_Lazarus#Development_version
s_from_SVN
http://wiki.lazarus.freepascal.org/Creating_A_Patch

Thanks,

Andrew Haines

PS I overwrote my local files with the ones in the link you posted and
here is a sample of the diff from current svn. Obviously most of the
changes are not yours so you can see the difficulty of checking your
changes.
http://www.hu.freepascal.org/fpcircbot/cgipastebin?msgid=12832

----------------------------------------------------------------------
AlexTP · 2009-06-08 11:26

QuotePlease use a svn version of lazarus and make a patch.

I change files in SVN version, and make additional change, so
I put my fiels here :
atorg.net.ru/temp/lh.zip (wait)

----------------------------------------------------------------------
AlexTP · 2009-06-08 14:39

Andrew
i also see bug: if I open english chm, then russian chm, I get AV (in
some unit). If i open russian first, no error. You can get both chms
(en, ru) at this link.

----------------------------------------------------------------------
Drewski · 2009-06-09 02:08

Thanks, this is much easier for me. I'm looking at it now.

----------------------------------------------------------------------
Drewski · 2009-06-09 02:41

Applied with small change in svn revision 20532

----------------------------------------------------------------------
AlexTP · 2009-06-09 11:55

1- what about bug (above)?
2- What URL can be opened? Maybe change 'Please Enter a URL'
to 'Please Enter a URL (xxx://, xxxx:// allowed)'.
3- a change:

Code: [Select]    OpenURL('file://'+OpenDialog1.FileName);
to
    OpenURL('file://'+OpenDialog1.FileName);
    fFileName := ExtractFileName(OpenDialog1.FileName);
--

    OpenURL(fRes);
to
    OpenURL(fRes);
    fFileName := fRes;
--

    Caption := 'LHelp - ' + ExtractFileName(OpenDialog1.FileName)
to
    Caption := 'LHelp - ' + fFileName

----------------------------------------------------------------------
Drewski · 2009-06-11 00:13

Please make a patch.
http://wiki.lazarus.freepascal.org/Creating_A_Patch

For #1 I downloaded the zip containing the chms and was able to open
them in the order you described without problem.

#2 Seems like a good idea. I wil do it soon.

#3 Please make a patch

Thanks

----------------------------------------------------------------------
AlexTP · 2009-06-11 19:22

1- maybe you closed en.chm before opening ru?
3- I'll see it

----------------------------------------------------------------------
AlexTP · 2009-06-11 19:25

4- see ru.chm and left panel: all ru letters are encoded as '&'
No encoding should visible on left.