Proposing an enhancement
lazarus / 43-Android

----------------------------------------------------------------------
zebu1er · 2019-09-04 15:24

Hi !
I'd like to participate to LAMW. My first goal is to propose an
implemenation of GetAccuracy to jLocation.
However I face to problems :
- After pressing Ctrl-F1, in case of error inside the jLocation.java,
I don't know where to find the error description thrown by the java
compiler !
- Which way my modifications can be reported to the official code
repository (patches, via owned SVN account, ...) ?
Thanks.

----------------------------------------------------------------------
Handoko · 2019-09-04 15:32

LAMW is actively developed and maintained by @jmpessoa, you should
contact him:
https://forum.lazarus.freepascal.org/index.php?action=profile;u=47362

If you're familiar with GitHub, then here it is:
https://github.com/jmpessoa/lazandroidmodulewizard

----------------------------------------------------------------------
jmpessoa · 2019-09-04 22:58

QuoteI'd like to participate to LAMW.

Welcome!

Quote I don't know where to find the error description thrown by the
java compiler !

Yes, debuging Android not an easy task...

You can try:

1) Adb command line tool...

or
2)Lazarus menu "Tools" --> "[LAMW] ..." --> "Adb Logcat" --> "Dump"

or

3)https://github.com/jmpessoa/lazandroidmodulewizard/blob/master/docs/
How_to_open_LAMW_project_with_AndroidStudio.txt

Yes! My java codes are produced using (3)!

QuoteWhich way my modifications can be reported to the official code
repository...

1) Modified ".java" code need be put in LAMW folder:
"......\android_wizard\smartdesigner\java"

2)  After clone LAMW from github your can do a "pull request"  or send
here in the forum or email it to me...

----------------------------------------------------------------------
zebu1er · 2019-09-05 13:30

Ok fine JM,

The 3) sounds good for me as I don't have Eclipse but AndroidStudio,
and that actually the jLocation.java visibly doesn't compile anymore
since I modified it !

I'm not aware of pull request despite of reading github's doc, so I'll
probably give you my work for that first contribution !

Thanks.

----------------------------------------------------------------------
zebu1er · 2019-09-05 16:19

Here are the patches.
However I'm not convinced by the result. Should the accuracy be
updated alongside the lat/lng/alt ...

----------------------------------------------------------------------
jmpessoa · 2019-09-16 15:30

Hi, zebu1er!

Please,  can you put here your complete code:

"location.pas"

"jLocation.java"

Thank you!

----------------------------------------------------------------------
jmpessoa · 2019-09-18 16:14

Ok.

Commited!!!

Thank you!