I've created a TJSONPropStorage, dunno where to announce... lazarus / 31-LCL ---------------------------------------------------------------------- Gustavo 'Gus' Carreno · 2017-02-12 00:51 Hi there, I've created a package with a TJSONPropStorage here. Don't really know where to announce, or if , by any chance, it could included on the main Lazarus dist? Any help, suggestions or being shouted at, will be appreciated. Thanks, Gus ---------------------------------------------------------------------- Leledumbo · 2017-02-12 05:23 Read this first, then report an issue to the bugtracker with category "Patch" attaching the patch you created from the first step. ---------------------------------------------------------------------- Gustavo 'Gus' Carreno · 2017-02-12 18:07 Quote from: Leledumbo on February 12, 2017, 06:23:35 amRead this first, then report an issue to the bugtracker with category "Patch" attaching the patch you created from the first step. Well, it's not really a patch as it's a whole new component that is not present in the main distribution. Should I still go through the patch hoops? Thanks, Gus ---------------------------------------------------------------------- Leledumbo · 2017-02-12 19:45 Quote from: gcarreno on February 12, 2017, 07:07:57 pmWell, it's not really a patch as it's a whole new component that is not present in the main distribution. Should I still go through the patch hoops? Yes, you're patching the components folder with your component. That's how it gets into the repository as you want it. Otherwise, you could just host it somewhere like github. ---------------------------------------------------------------------- jmpessoa · 2017-02-12 21:34 Hi gcarreno! First: Thank you! Suggestion for Android compatibility: 1. Drop LCL package dependency ["fcl-json" is a FCL package!]    [yes, add FCL dependency!]  2. Put the "register" procedure in another file...    [yes, add LCLBase dependency, if you will provide a custom component icon!] ex: Code: Pascal  [Select][+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i unit register_tjsonpropstorage;  {$mode objfpc}{$H+} interfaceuses   Classes,  SysUtils,  LResources,    // [optional] need if you will provide a custom  component icon  JSONPropStorage;  Procedure Register;  implementation Procedure Register;begin  {$I tjsonpropstorage_icon.lrs}   // [optional] if you have a custom component icon [as generate by "lazres.exe"]  RegisterComponents('Misc', [TJSONPropStorage]);end;  end.  3. Include  "register_tjsonpropstorage.pas" file in your package. Good Work! ---------------------------------------------------------------------- minesadorada · 2017-02-13 11:38 Quote from: gcarreno on February 12, 2017, 01:51:19 amHi there, I've created a package with a TJSONPropStorage here. Don't really know where to announce, or if , by any chance, it could included on the main Lazarus dist? Any help, suggestions or being shouted at, will be appreciated. Thanks, Gus User @GetMem is in charge of OnlinePackageManager which will be in the next version of Lazarus.  Send him your component, and I expect he will include it. ---------------------------------------------------------------------- Gustavo 'Gus' Carreno · 2017-02-13 15:42 Quote from: jmpessoa on February 12, 2017, 10:34:48 pmFirst: Thank you! You're quite welcome!! Quote from: jmpessoa on February 12, 2017, 10:34:48 pm1. Drop LCL package dependency ["fcl-json" is a FCL package!]    [yes, add FCL dependency!]  2. Put the "register" procedure in another file...    [yes, add LCLBase dependency, if you will provide a custom component icon!] I'll have a gander at it. I'm not sure I can drop the LCL completely since this component uses JSONConf and LazUTF8. Quote from: jmpessoa on February 12, 2017, 10:34:48 pm3. Include  "register_tjsonpropstorage.pas" file in your package. Okydokes, I'll do this if it's current "correct" way of doing things. Cheers, Gus ---------------------------------------------------------------------- Gustavo 'Gus' Carreno · 2017-02-13 15:45 Quote from: minesadorada on February 13, 2017, 12:38:13 pmUser @GetMem is in charge of OnlinePackageManager which will be in the next version of Lazarus.  Send him your component, and I expect he will include it. Many thanks for this, but... I'm sorry for being such a newb with insistence, but when you say "Send him your component...", could you be more specific in terms of channels? Use this forum's private messages? Or some other way? Many, many thanks, Gus ---------------------------------------------------------------------- Gustavo 'Gus' Carreno · 2017-02-13 16:00 Quote from: jmpessoa on February 12, 2017, 10:34:48 pmSuggestion for Android compatibility: All that you suggested has now been committed to GitHub's HEAD. I still don't have an icon and I'm struggling a bit with it since I really suck at Graphic Applications (GIMP, Photoshop, etc...) I'll tag it and do a proper release once I get the icon done. AGAIN: Many thanks all of you for the help and welcoming messages!! Cheers, Gus ---------------------------------------------------------------------- minesadorada · 2017-02-13 16:19 Quote from: gcarreno on February 13, 2017, 04:45:41 pmQuote from: minesadorada on February 13, 2017, 12:38:13 pmUser @GetMem is in charge of OnlinePackageManager which will be in the next version of Lazarus.  Send him your component, and I expect he will include it. Many thanks for this, but... I'm sorry for being such a newb with insistence, but when you say "Send him your component...", could you be more specific in terms of channels? Use this forum's private messages? Or some other way? Many, many thanks, Gus Use the private messaging facility in this forum. ---------------------------------------------------------------------- Gustavo 'Gus' Carreno · 2017-02-13 16:38 Quote from: minesadorada on February 13, 2017, 05:19:35 pmUse the private messaging facility in this forum. Done! Thanks, so very much!! Cheers, Gus ---------------------------------------------------------------------- avra · 2017-02-14 09:20 I hate to spoil work already done, but I really do not think that TJSONPropStorage should be downloaded with OnlinePackageManager. I think it belongs to Lazarus in directory where TINIPropStorage and TXMLPropStorage are already placed. That would avoid any confusion. So, a patch for Lazarus would be more prefered by me. Btw. nice work ---------------------------------------------------------------------- balazsszekely · 2017-02-14 09:58 Quote@avra I hate to spoil work already done, but I really do not think that TJSONPropStorage should be downloaded with OnlinePackageManager. I think it belongs to Lazarus in directory where TINIPropStorage and TXMLPropStorage are already placed. That would avoid any confusion. So, a patch for Lazarus would be more prefered by me.For now it can be downloaded/installed through OPM. Consider it as an extra possibility. After it's added to Lazarus SVN, I will remove it from the central repository. ---------------------------------------------------------------------- Gustavo 'Gus' Carreno · 2017-02-14 17:18 Quote from: avra on February 14, 2017, 10:20:28 amI hate to spoil work already done, but I really do not think that TJSONPropStorage should be downloaded with OnlinePackageManager. I think it belongs to Lazarus in directory where TINIPropStorage and TXMLPropStorage are already placed. That would avoid any confusion. So, a patch for Lazarus would be more prefered by me. I also agree with you. I'll initiate the process of trying to get it unto the main SVN with a patch request once I have an icon. And it seems that @GetMem is willing to remove it from the OPM once it gets integrated into the main tree, so we're all good Quote from: avra on February 14, 2017, 10:20:28 amBtw. nice work  Thanks!!! Cheers, GUs ---------------------------------------------------------------------- Gustavo 'Gus' Carreno · 2017-02-14 17:19 Quote from: GetMem on February 14, 2017, 10:58:19 amFor now it can be downloaded/installed through OPM. Consider it as an extra possibility. After it's added to Lazarus SVN, I will remove it from the central repository. Thanks mate, you ARE a star Cheers, Gus ---------------------------------------------------------------------- Gustavo 'Gus' Carreno · 2017-02-14 23:03 Hey peeps, First of all I want to thank all and everyone of you that helped in this endeavour!! I've finally added an icon to v1.0.5.10 of the package. You can find all of it on the GitHub page I've also went through the hoops of creating a PATCH and submitted it to the FPC bugtracker. Fingers crossed, it'll be included into the main tree. Cheers, Gus ---------------------------------------------------------------------- balazsszekely · 2017-02-15 09:23 @gcarreno Now your component is part of Lazarus SVN, so I removed from OPM. Thanks for sharing! ---------------------------------------------------------------------- Thaddy · 2017-02-15 12:33 Useful and well done! compliments. ---------------------------------------------------------------------- jacmoe · 2017-02-15 15:31 I love this - thanks a lot for making Lazarus better! Perfect timing, as I am going to need a JSON property storage for my next project.