Fixing LCL lazarus / 31-LCL ---------------------------------------------------------------------- EdyKnopfler · 2013-04-01 19:39 I have fixed some bugs in 3 files of LCL and would like to share them. Note: modifications were made on Lazarus 1.0.8; If possible, I recommend to change only the methods listed below: lcl/include/dbcustomnavigator.inc An incorrect cast in TDBCustomNavigator.ButtonClickHandler was preventing the option navFocusableButtons from working. Solution : I put an *if* to see what the cast should be done. lcl/dbgrids.pas In TCustomDBGrid.EditorCanAcceptKey was not treating  Backspace, preventing the user from using it in numeric fields. Solution : added checking for the character code 8 (backspace) lcl/grids.pas I altered two methods: TCustomGrid.SetFocus and TCustomGrid.DoEditorHide . With the dsAlwaysShowEditor option activated, when I do a SetFocus, the focus was not going to the editor. Solution: I modified the focus to go to the editor and return it to the DBGrid when the editor is hidden. ---------------------------------------------------------------------- JuhaManninen · 2013-04-01 19:52 Your patch.rar is not really a patch. See here how to make a proper one:   http://wiki.lazarus.freepascal.org/Creating_A_Patch It should be made against Lazarus trunk and uploaded to bug-tracker. Juha ---------------------------------------------------------------------- EdyKnopfler · 2013-04-02 04:17 Is that why my corrections to LCL aren't marked as "resolved" by the team at the tracker? ---------------------------------------------------------------------- avra · 2013-04-02 07:05 Edy, just 5 messages and already fixing LCL! Thank you very much! However, there isn't anyone with a role of watching forum for proposed patches so please don't feel disappointed and discouraged. Your effort is much appreciated, you just need to do it properly. Most of us love to code and hate the paper work, but without following the procedure you can imagine how many ideas different people can have about a way to contribute a patch. That procedure might not be perfect and not to everyone's taste, but we have to live with it until there is a better one. Cheers and keep up the good work! ---------------------------------------------------------------------- BigChimp · 2013-04-02 08:05 Totally agreed with avra. Noticed you got a diff in at http://bugs.freepascal.org/view.php?id=24213 hope it gets processed soon & gets committed to Lazarus. Thanks for your help!