[SOLVED] Conditional Defines in PQConnection.pp in branch fixes_3_2
lazarus / 16-Databases

----------------------------------------------------------------------
chrisv5 · 2024-02-09 15:07

I have finally given up working around the countless bugs in
PQConnection in FPC "stable". I had decided to start using fixes_3_2,
but that has yet another problem:

Code: Pascal  [Select][+][-]window.onload = function(){var x1 =
document.getElementById("main_content_section"); if (x1) { var x =
document.getElementsByClassName("geshi");for (var i = 0; i    
{$IFNDEF VER3_2}   
SEVERITY:=PQresultErrorField(res,PG_DIAG_SEVERITY);   
SQLSTATE:=PQresultErrorField(res,PG_DIAG_SQLSTATE);   
MESSAGE_PRIMARY:=PQresultErrorField(res,PG_DIAG_MESSAGE_PRIMARY);   
MESSAGE_DETAIL:=PQresultErrorField(res,PG_DIAG_MESSAGE_DETAIL);   
MESSAGE_HINT:=PQresultErrorField(res,PG_DIAG_MESSAGE_HINT);    STATEME
NT_POSITION:=PQresultErrorField(res,PG_DIAG_STATEMENT_POSITION);   
SCHEMA_NAME:=PQresultErrorField(res,PG_DIAG_SCHEMA_NAME);   
TABLE_NAME:=PQresultErrorField(res,PG_DIAG_TABLE_NAME);   
COLUMN_NAME:=PQresultErrorField(res,PG_DIAG_COLUMN_NAME);   
DATATYPE_NAME:=PQresultErrorField(res,PG_DIAG_DATATYPE_NAME);   
CONSTRAINT_NAME:=PQresultErrorField(res,PG_DIAG_CONSTRAINT_NAME);   
{$ENDIF} 
Why is this important piece of code essentially commented out?

----------------------------------------------------------------------
marcov · 2024-02-09 16:24

I asked around, and some people used trunk fcl-db with FPC 3.2.2, and
those tests got merged back to fixes 3.2.

I'll have a look and test if I can remove them in fixes tonight.

----------------------------------------------------------------------
marcov · 2024-02-09 17:40

Done

----------------------------------------------------------------------
chrisv5 · 2024-02-09 18:01

Many, many thanks! Awesome service!