Focus rect on breakpoint line.
lazarus / 12-Debugger

----------------------------------------------------------------------
440bx · 2025-06-03 16:33

Hello,

When the caret is on a line that has a breakpoint on it, the focus
rectangle is not drawn. 

Should this be considered a bug ?

The first part of the attachment shows the caret on a line that has a
breakpoint set on it and there is no focus rectangle.  The second part
shows the caret on the following line (which has no breakpoint set on
it) and the focus rectangle is drawn/visible as expected.

Comments welcome.

----------------------------------------------------------------------
Martin_fr · 2025-06-03 18:04

What is a "focus rectangle"? The source editor does not have that. At
least not by that name...
I can only assume you mean the "current line highlight", and you have
set that to a dotted frame?

Yes, there are both "special line highlights". The editor currently
applies only one line highlight (and the order which is chosen is
hardcoded: error, gutter marks, current line.

Please add a feature request.

----------------------------------------------------------------------
440bx · 2025-06-03 18:11

Quote from: Martin_fr on June 03, 2025, 08:04:01 pmWhat is a "focus
rectangle"? The source editor does not have that. At least not by that
name...
I can only assume you mean the "current line highlight", and you have
set that to a dotted frame?
Yes, that dotted frame is called the focus rectangle in the Windows
API which is why I referred to it that way (that's what I'm used to.)

Quote from: Martin_fr on June 03, 2025, 08:04:01 pmYes, there are both
"special line highlights". The editor currently applies only one line
highlight (and the order which is chosen is hardcoded: error, gutter
marks, current line.

Please add a feature request.
I'll add a feature request but, there is one thing I don't see... what
other "highlight" is applied to the breakpoint line when editing ?


ETA:

added feature request:
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/41691
ticket: 41691

----------------------------------------------------------------------
Martin_fr · 2025-06-03 18:39

The highlight for "active breakpoint" or whatever other state the
breakpoint has.

I haven't tested, possible that it takes priority, even if it has  no
color. That part still contains some very old code (been move around a
bit, but still old...)

----------------------------------------------------------------------
Martin_fr · 2025-06-03 18:43

I know the term focus rect.

I have however only seen it with edits, when applied to the entire
edit (not some part, not some line => because the entire edit has the
focus).

And with lists and grids, where focus is used for a single line or
cell.

After all, why in an editor should the focus be limited to the line,
when it could be on the word or on the char?