https://github.com/tc39/ecma262/pull/3176 Skip to content Toggle navigation Sign in * Product + Actions Automate any workflow + Packages Host and manage packages + Security Find and fix vulnerabilities + Codespaces Instant dev environments + Copilot Write better code with AI + Code review Manage code changes + Issues Plan and track work + Discussions Collaborate outside of code Explore + All features + Documentation + GitHub Skills + Blog * Solutions For + Enterprise + Teams + Startups + Education By Solution + CI/CD & Automation + DevOps + DevSecOps Resources + Learning Pathways + White papers, Ebooks, Webinars + Customer Stories + Partners * Open Source + GitHub Sponsors Fund open source developers + The ReadME Project GitHub community articles Repositories + Topics + Trending + Collections * Pricing Search or jump to... Search code, repositories, users, issues, pull requests... Search [ ] Clear Search syntax tips Provide feedback We read every piece of feedback, and take your input very seriously. [ ] [ ] Include my email address so I can be contacted Cancel Submit feedback Saved searches Use saved searches to filter your results more quickly Name [ ] Query [ ] To see all available qualifiers, see our documentation. Cancel Create saved search Sign in Sign up You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session. Dismiss alert {{ message }} tc39 / ecma262 Public * Notifications * Fork 1.4k * Star 14.5k * Code * Issues 314 * Pull requests 121 * Actions * Projects 1 * Wiki * Security * Insights Additional navigation options * Code * Issues * Pull requests * Actions * Projects * Wiki * Security * Insights New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Pick a username [ ] Email Address [ ] Password [ ] [ ] Sign up for GitHub By clicking "Sign up for GitHub", you agree to our terms of service and privacy statement. We'll occasionally send you account related emails. Already on GitHub? Sign in to your account Jump to bottom Normative: add Object.groupBy and Map.groupBy #3176 Merged ljharb merged 1 commit into tc39:main from ljharb:grouping Dec 4, 2023 Merged Normative: add Object.groupBy and Map.groupBy #3176 ljharb merged 1 commit into tc39:main from ljharb:grouping Dec 4, 2023 +96 -0 Conversation 25 Commits 1 Checks 10 Files changed 1 Conversation This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters ljharb Copy link Member @ljharb ljharb commented Sep 15, 2023 See https://tc39.es/proposal-array-grouping/ Sorry, something went wrong. 3 feliperaul, maniac1122, and styfle reacted with thumbs up emoji [?] 4 D4llo, JudahGabriel, styfle, and danielterwiel reacted with heart emoji All reactions * 3 reactions * [?] 4 reactions @ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. has test262 tests proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Sep 15, 2023 @ljharb ljharb requested a review from a team September 15, 2023 17:47 @ljharb ljharb mentioned this pull request Sep 15, 2023 Stage 4 Criteria tc39/proposal-array-grouping#60 Closed 10 tasks @ljharb ljharb force-pushed the grouping branch 2 times, most recently from 97ca5f2 to a9a7ed3 Compare September 15, 2023 19:00 @ljharb ljharb added the editor call to be discussed in the next editor call label Nov 16, 2023 syg syg approved these changes Nov 16, 2023 View reviewed changes Copy link Contributor @syg syg left a comment There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment lgtm, just some wordsmithing comments. Sorry, something went wrong. All reactions spec.html Outdated Show resolved Hide resolved spec.html Outdated Show resolved Hide resolved spec.html Outdated Show resolved Hide resolved jmdyck jmdyck previously requested changes Nov 17, 2023 View reviewed changes spec.html Outdated Show resolved Hide resolved spec.html Outdated Show resolved Hide resolved spec.html Outdated Show resolved Hide resolved spec.html Outdated Show resolved Hide resolved spec.html Outdated Show resolved Hide resolved @ljharb ljharb force-pushed the grouping branch from a9a7ed3 to 5bd2a9b Compare November 18, 2023 02:17 @ljharb ljharb requested a review from jmdyck November 18, 2023 02:17 ljharb added a commit to ljharb/ecma262 that referenced this pull request Nov 21, 2023 @ljharb Normative: add Object.groupBy and Map.groupBy (tc39#3176) ... a759171 See https://tc39.es/proposal-array-grouping/ @ljharb ljharb force-pushed the grouping branch from 5bd2a9b to a759171 Compare November 21, 2023 01:37 @ljharb ljharb dismissed jmdyck's stale review November 21, 2023 12:28 changes addressed jmdyck jmdyck reviewed Nov 22, 2023 View reviewed changes Copy link Collaborator @jmdyck jmdyck left a comment There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Looks okay to me. Sorry, something went wrong. All reactions spec.html Show resolved Hide resolved michaelficarra michaelficarra approved these changes Nov 23, 2023 View reviewed changes ljharb added a commit to ljharb/ecma262 that referenced this pull request Nov 23, 2023 @ljharb Normative: add Object.groupBy and Map.groupBy (tc39#3176) ... 671eaca See https://tc39.es/proposal-array-grouping/ @ljharb ljharb force-pushed the grouping branch from a759171 to 671eaca Compare November 23, 2023 03:01 bakkot bakkot approved these changes Nov 23, 2023 View reviewed changes @ljharb ljharb removed the editor call to be discussed in the next editor call label Nov 23, 2023 ljharb added a commit to ljharb/ecma262 that referenced this pull request Nov 23, 2023 @ljharb Normative: add Object.groupBy and Map.groupBy (tc39#3176) ... 5afb528 See https://tc39.es/proposal-array-grouping/ @ljharb ljharb force-pushed the grouping branch from 671eaca to 5afb528 Compare November 23, 2023 04:18 bakkot bakkot reviewed Nov 23, 2023 View reviewed changes spec.html Show resolved Hide resolved @ljharb ljharb added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Nov 27, 2023 @ljharb Copy link Member Author ljharb commented Nov 27, 2023 This achieved consensus today at TC39. 11 bergus, agaborvf, aendra-rininsland, sylvaindumont, zadeviggers, chalkers, GauBen, hyldmo, useffc, turadg, and styfle reacted with hooray emoji All reactions * 11 reactions Sorry, something went wrong. @ljharb ljharb marked this pull request as ready for review November 27, 2023 19:07 @ljharb Normative: add Object.groupBy and Map.groupBy (tc39#3176) ... 3a9c9dc See https://tc39.es/proposal-array-grouping/ @ljharb ljharb force-pushed the grouping branch from 5afb528 to 3a9c9dc Compare November 28, 2023 17:47 @aliscco aliscco mentioned this pull request Nov 30, 2023 [Snyk] Fix for 4 vulnerabilities aliscco/ecma262#13 Open @Pyrolistical Pyrolistical mentioned this pull request Dec 1, 2023 Add Array.prototype.groupBy[toMap] to JS lib definitions. microsoft/ TypeScript#47171 Open @michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Dec 4, 2023 Hide details View details @ljharb ljharb merged commit 3a9c9dc into tc39:main Dec 4, 2023 10 checks passed @ljharb ljharb deleted the grouping branch December 4, 2023 16:24 Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment Reviewers @bakkot bakkot bakkot approved these changes @jmdyck jmdyck jmdyck left review comments @syg syg syg approved these changes @michaelficarra michaelficarra michaelficarra approved these changes Assignees No one assigned Labels has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/ merged when the proposal reaches stage 4. ready to merge Editors believe this PR needs no further reviews, and is ready to land. Projects None yet Milestone No milestone Development Successfully merging this pull request may close these issues. None yet 5 participants @ljharb @syg @michaelficarra @bakkot @jmdyck Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later. Footer (c) 2023 GitHub, Inc. Footer navigation * Terms * Privacy * Security * Status * Docs * Contact * You can't perform that action at this time.