https://github.com/chromium/chromium/commit/6f47a22906b2899412e79a2727355efa9cc8f5bd Skip to content Toggle navigation Sign up * Product + Actions Automate any workflow + Packages Host and manage packages + Security Find and fix vulnerabilities + Codespaces Instant dev environments + Copilot Write better code with AI + Code review Manage code changes + Issues Plan and track work + Discussions Collaborate outside of code Explore + All features + Documentation + GitHub Skills + Blog * Solutions For + Enterprise + Teams + Startups + Education By Solution + CI/CD & Automation + DevOps + DevSecOps Resources + Customer Stories + White papers, Ebooks, Webinars + Partners * Open Source + GitHub Sponsors Fund open source developers + The ReadME Project GitHub community articles Repositories + Topics + Trending + Collections * Pricing Search or jump to... Search code, repositories, users, issues, pull requests... Search [ ] Clear Search syntax tips Provide feedback We read every piece of feedback, and take your input very seriously. [ ] [ ] Include my email address so I can be contacted Cancel Submit feedback Saved searches Use saved searches to filter your results more quickly Name [ ] Query [ ] To see all available qualifiers, see our documentation. Cancel Create saved search Sign in Sign up You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session. {{ message }} chromium / chromium Public * Notifications * Fork 5.7k * Star 15.3k * Code * Pull requests 79 * Actions * Security * Insights More * Code * Pull requests * Actions * Security * Insights Commit Permalink This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository. Browse files Browse the repository at this point in the history [wei] Ensure Origin Trial enables full feature This CL moves the base::Feature from content_features.h to a generated feature from runtime_enabled_features.json5. This means that the base::Feature can be default-enabled while the web API is controlled by the RuntimeFeature, which will still be default-disabled. An origin trial can enable the RuntimeFeature, which will allow full access to the API, provided the base::Feature is also enabled (see change to origin_trial_context.cc). Meanwhile, the base::Feature can be disabled through Finch as a kill-switch for the whole feature, and prevent origin trials from turning the feature on. Tests have been added to WebView test, as it allowed for easy spoofing of responses on a known origin. Bug: 1439945 Change-Id: Ifa0f5d4f5e0a0bf882dd1b0207698dddd6f71420 Fixed: b/278701736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4681552 Reviewed-by: Rayan Kanso Commit-Queue: Peter Pakkenberg Reviewed-by: Dmitry Gozman Reviewed-by: Richard Coles Reviewed-by: Kinuko Yasuda Cr-Commit-Position: refs/heads/main@{#1173344} * Loading branch information Peter Birk Pakkenberg authored and Chromium LUCI CQ committed Jul 21, 2023 1 parent 05e71c3 commit 6f47a22 Show file tree Hide file tree Showing 15 changed files with 173 additions and 18 deletions. * Split * Unified [ ] * android_webview + browser o android_webview/browser/DEPS DEPS o android_webview/browser/ aw_content_browser_client_receiver_bindings.cc aw_content_browser_client_receiver_bindings.cc + java/src/org/chromium/android_webview/common o android_webview/java/src/org/chromium/android_webview/ common/ProductionSupportedFlagList.java ProductionSupportedFlagList.java + javatests o android_webview/javatests/DEPS DEPS o src/org/chromium/android_webview/test # android_webview/javatests/src/org/chromium/ android_webview/test/ AwWebEnvironmentIntegrityTest.java AwWebEnvironmentIntegrityTest.java + test o android_webview/test/BUILD.gn BUILD.gn * chrome/browser + chrome/browser/chrome_browser_interface_binders.cc chrome_browser_interface_binders.cc * components/environment_integrity/android + components/environment_integrity/android/ android_environment_integrity_service.cc android_environment_integrity_service.cc + components/environment_integrity/android/ android_environment_integrity_service_unittest.cc android_environment_integrity_service_unittest.cc * content + browser o content/browser/browser_interface_binders.cc browser_interface_binders.cc + child o content/child/runtime_features.cc runtime_features.cc + public/common o content/public/common/content_features.cc content_features.cc o content/public/common/content_features.h content_features.h * third_party/blink/renderer + core/origin_trials o third_party/blink/renderer/core/origin_trials/ origin_trial_context.cc origin_trial_context.cc + platform o third_party/blink/renderer/platform/ runtime_enabled_features.json5 runtime_enabled_features.json5 There are no files selected for viewing 1 change: 1 addition & 0 deletions 1 android_webview/browser/DEPS [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original file Diff line Diff line change line number number Expand Up @@ -104,6 +104,7 @@ include_rules = [ "+third_party/blink/public/common/ client_hints/enabled_client_hints.h", "+third_party/blink/public/common/features.h" , "+third_party/blink/public/common/ features_generated.h", "+third_party/blink/public/common/ origin_trials/origin_trial_feature.h", "+third_party/blink/public/common/ origin_trials/ origin_trials_settings_provider.h", "+third_party/blink/public/common/ origin_trials/trial_token_validator.h", Expand Down 4 changes: 3 additions & 1 deletion 4 android_webview/browser/ aw_content_browser_client_receiver_bindings.cc [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line Diff line change line number number Expand Up @@ -8,6 +8,7 @@ #include "android_webview/browser/aw_print_manager.h" #include "android_webview/browser/renderer_host/ aw_render_view_host_ext.h" #include "android_webview/browser/safe_browsing/ aw_url_checker_delegate_impl.h" #include "base/feature_list.h" #include "components/autofill/content/browser/ content_autofill_driver_factory.h" #include "components/cdm/browser/media_drm_storage_impl.h" #include "components/content_capture/browser/ onscreen_content_provider.h" Expand All @@ -29,6 +30,7 @@ #include "mojo/public/cpp/bindings/self_owned_receiver.h" #include "services/service_manager/public/cpp/binder_registry.h" #include "third_party/blink/public/common/associated_interfaces/ associated_interface_registry.h" #include "third_party/blink/public/common/features_generated.h" #include "third_party/blink/public/mojom/environment_integrity/ environment_integrity_service.mojom.h" #if BUILDFLAG(ENABLE_SPELLCHECK) Expand Down @@ -215,7 +217,7 @@ void Expand Up AwContentBrowserClient::RegisterBrowserInterfaceBindersForFrame( map->Add( base::BindRepeating(&BindNetworkHintsHandler)); if (base::FeatureList::IsEnabled(features::kWebEnvironmentIntegrity )) { if (base::FeatureList::IsEnabled(blink::features:: kWebEnvironmentIntegrity)) { map->Add( base::BindRepeating( & environment_integrity::AndroidEnvironmentIntegrityService::Create)); } Expand Down 2 changes: 1 addition & 1 deletion 2 ...oid_webview/java/src/org/ chromium/android_webview/common/ProductionSupportedFlagList.java [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line line Diff line change number number Expand Up @@ -472,7 +472,7 @@ private ProductionSupportedFlagList() {} + "Only onNetwork(Connected|Disconnected| SoonToDisconnect|MadeDefault) signals are propagated."), Flag.baseFeature(BlinkFeatures. REMOVE_NON_STANDARD_APPEARANCE_VALUE, "Remove non-standard CSS appearance values."), Flag.baseFeature(ContentFeatures. WEB_ENVIRONMENT_INTEGRITY, Flag.baseFeature(BlinkFeatures. WEB_ENVIRONMENT_INTEGRITY, "Enables Web Environment Integrity APIs. " + "See https://chromestatus.com/feature/ 5796524191121408."), // Add new commandline switches and features above. The final entry should have a Expand Down 1 change: 1 addition & 0 deletions 1 android_webview/javatests/DEPS [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original file line Diff line Diff line change number number Expand Up @@ -4,6 +4,7 @@ include_rules = [ "+components/background_task_scheduler /android/java", "+components/component_updater/android /java", "+components/embedder_support/android/ metrics/java", "+components/environment_integrity/ android/java", "+components/minidump_uploader/android /java", "+components/minidump_uploader/android /javatests", "+components/policy/android/java", Expand Down 146 changes: 144 additions & 2 deletions 146 ...ebview/javatests/src/ org/chromium/android_webview/test/AwWebEnvironmentIntegrityTest.java [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line Diff line change line number number Expand Up @@ -4,8 +4,13 @@ package org.chromium.android_webview.test; import android.webkit.JavascriptInterface; import androidx.test.filters.SmallTest; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; import org.junit.After; import org.junit.Assert; import org.junit.Before; Expand All @@ -14,12 +19,22 @@ import org.junit.runner.RunWith; import org.chromium.android_webview.AwContents; import org.chromium.android_webview.test.TestAwContentsClient. ShouldInterceptRequestHelper; import org.chromium.base.test.util.Batch; import org.chromium.base.test.util.CallbackHelper; import org.chromium.base.test.util.CommandLineFlags; import org.chromium.content_public.common.ContentFeatures; import org.chromium.blink_public.common.BlinkFeatures; import org.chromium.components.embedder_support.util. WebResourceResponseInfo; import org.chromium.components.environment_integrity. IntegrityServiceBridge; import org.chromium.components.environment_integrity. IntegrityServiceBridgeDelegate; import org.chromium.net.test.util.TestWebServer; import java.io.ByteArrayInputStream; import java.nio.charset.StandardCharsets; import java.util.Collections; import java.util.Map; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; /** * Tests for WebEnvironmentIntegrity in WebView. Expand All @@ -29,7 +44,6 @@ * and only supposed to test WebView-specific differences. */ @RunWith(AwJUnit4ClassRunner.class) @CommandLineFlags.Add({"enable-features=" + ContentFeatures. WEB_ENVIRONMENT_INTEGRITY}) @Batch(Batch.PER_CLASS) public class AwWebEnvironmentIntegrityTest { @Rule Expand All @@ -39,6 +53,17 @@ public class AwWebEnvironmentIntegrityTest { private AwContents mAwContents; private TestWebServer mWebServer; private static final String ORIGIN_TRIAL_URL = "https://example.com/" ; private static final String ORIGIN_TRIAL_HEADER = "Origin-Trial"; private static final String ORIGIN_TRIAL_TOKEN = "A1GBGCeaLBRlky1ITf9uRak5iluqLWnUdSTKVTO0Ce/ I7a35nik6DKqPJNZSPd9KEAIuJKmi2dmL9HWThDWgdA" + "cAAABheyJvcmlnaW4iOiAiaHR0cHM6Ly9leGFtcGxlLmNvbTo0NDMiLCAiZmVhdHVyZSI6ICJXZWJFbnZpcm" + "9ubWVudEludGVncml0eSIsICJleHBpcnkiOiAyMDAwMDAwMDAwfQ=="; private static final long HANDLE = 123456789L; private static final byte[] TOKEN = {1, 2, 3, 4}; private static final String TOKEN_BASE64 = "AQIDBA=="; @Before public void setUp() throws Exception { Expand All @@ -58,6 +83,24 @@ public void tearDown() throws Exception { @Test @SmallTest public void testWebEnvironmentIntegrityApiNotAvailableByDefault() throws Throwable { // Load a web page from localhost to get a secure context mWebServer.setResponse("/", "", Collections.emptyList()); mActivityTestRule.loadUrlSync( mAwContents, mContentsClient.getOnPageFinishedHelper(), mWebServer. getBaseUrl()); // Check that the 'getEnvironmentIntegrity' method is available. final String script = "'getEnvironmentIntegrity' in navigator ? 'available': 'missing'"; String result = mActivityTestRule.executeJavaScriptAndWaitForResult( mAwContents, mContentsClient, script); // The result is expected to have extra quotes as a JSON-encoded string. Assert.assertEquals("This test is expected to fail if runtime_enabled_features.json5" + " is updated to mark the feature as 'stable'.", "\"missing\"", result); } @Test @SmallTest @CommandLineFlags.Add({"enable-features=" + BlinkFeatures. WEB_ENVIRONMENT_INTEGRITY}) public void testWebEnvironmentIntegrityApiAvailable() throws Throwable { // Load a web page from localhost to get a secure context mWebServer.setResponse("/", "", Collections.emptyList()); Expand All @@ -70,4 +113,103 @@ public void testWebEnvironmentIntegrityApiAvailable() throws Throwable { // The result is expected to have extra quotes as a JSON-encoded string. Assert.assertEquals("\"available\"", result); } @Test @SmallTest @CommandLineFlags.Add({"disable-features=" + BlinkFeatures. WEB_ENVIRONMENT_INTEGRITY}) public void testWebEnvironmentIntegrityApiCanBeDisabled() throws Throwable { // Load a web page from localhost to get a secure context mWebServer.setResponse("/", "", Collections.emptyList()); mActivityTestRule.loadUrlSync( mAwContents, mContentsClient.getOnPageFinishedHelper(), mWebServer. getBaseUrl()); // Check that the 'getEnvironmentIntegrity' method is available. final String script = "'getEnvironmentIntegrity' in navigator ? 'available': 'missing'"; String result = mActivityTestRule.executeJavaScriptAndWaitForResult( mAwContents, mContentsClient, script); // The result is expected to have extra quotes as a JSON-encoded string. Assert.assertEquals("\"missing\"", result); } @Test @SmallTest @CommandLineFlags.Add({"origin-trial-public-key= dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNA="}) public void testAppIdentityEnabledByOriginTrial() throws Throwable { // Set up a response with the origin trial header. // Since origin trial tokens are tied to the origin, we use an request intercept to load // the content when making a request to the origin trial URL, instead of relying on the // server, which serves from an unknown port. var body = new ByteArrayInputStream( "Hello, World".getBytes(StandardCharsets. UTF_8)); var responseInfo = new WebResourceResponseInfo("text/html", "utf-8", body, 200, "OK", Map.of(ORIGIN_TRIAL_HEADER, ORIGIN_TRIAL_TOKEN)); final ShouldInterceptRequestHelper requestInterceptHelper = mContentsClient.getShouldInterceptRequestHelper(); requestInterceptHelper.setReturnValueForUrl(ORIGIN_TRIAL_URL, responseInfo); final TestIntegrityServiceBridgeDelegateImpl delegateForTesting = new TestIntegrityServiceBridgeDelegateImpl(); mActivityTestRule.runOnUiThread( () -> IntegrityServiceBridge.setDelegateForTesting(delegateForTesting )); final ExecutionCallbackListener listener = new ExecutionCallbackListener(); AwActivityTestRule.addJavascriptInterfaceOnUiThread(mAwContents, listener, "testListener"); mActivityTestRule.loadUrlSync( mAwContents, mContentsClient.getOnPageFinishedHelper(), ORIGIN_TRIAL_URL); final String script = "(() => {" + "if ('getEnvironmentIntegrity' in navigator) {" + " navigator.getEnvironmentIntegrity('contentBinding')" + " .then(s => testListener.result(s.encode()))" + " .catch(e => testListener.result('error: ' + e));" + " return 'available';" + "} else {return 'unavailable';}" + "})();"; String scriptResult = mActivityTestRule. executeJavaScriptAndWaitForResult( mAwContents, mContentsClient, script); // The result is expected to have extra quotes as a JSON-encoded string. Assert.assertEquals("\"available\"", scriptResult); // Wait until the result callback has been triggered, to inspect the state of the delegate // The actual result should just be an error we don't care about. String result = listener.waitForResult(); Assert.assertEquals(TOKEN_BASE64, result); } static class ExecutionCallbackListener { private final CallbackHelper mCallbackHelper = new CallbackHelper(); private String mResult; @JavascriptInterface public void result(String s) { mResult = s; mCallbackHelper.notifyCalled(); } String waitForResult() throws TimeoutException { mCallbackHelper.waitForNext(5, TimeUnit.SECONDS); return mResult; } } private static class TestIntegrityServiceBridgeDelegateImpl implements IntegrityServiceBridgeDelegate { @Override public ListenableFuture createEnvironmentIntegrityHandle( boolean bindAppIdentity, int timeoutMilliseconds) { return Futures.immediateFuture(HANDLE); } @Override public ListenableFuture getEnvironmentIntegrityToken( long handle, byte[] requestHash, int timeoutMilliseconds) { return Futures.immediateFuture(TOKEN); } @Override public boolean canUseGms() { return true; } } } 2 changes: 2 additions & 0 deletions 2 android_webview/test/BUILD.gn [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line Diff line change line number number Expand Up @@ -279,6 +279,7 @@ instrumentation_test_apk ("webview_instrumentation_test_apk") { "//components/embedder_support/android:util_java", "//components/embedder_support/ android:web_contents_delegate_java", "//components/embedder_support/android/metrics:java", "//components/environment_integrity/android:java", "//components/heap_profiling/ multi_process:heap_profiling_java_test_support", "//components/metrics:metrics_java", "//components/minidump_uploader:minidump_uploader_java", Expand Down @@ -314,6 +315,7 @@ instrumentation_test_apk Expand Up ("webview_instrumentation_test_apk") { "//third_party/androidx:androidx_test_runner_java", "//third_party/ androidx_javascriptengine:javascriptengine_common_java", "//third_party/ androidx_javascriptengine:javascriptengine_java", "//third_party/blink/public/common:common_java", "//third_party/blink/public/mojom:mojom_platform_java", "//third_party/blink/public/ mojom:web_feature_mojo_bindings_java", "//third_party/hamcrest:hamcrest_core_java", Expand Down 3 changes: 2 additions & 1 deletion 3 chrome/browser/ chrome_browser_interface_binders.cc [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line Diff line change line number number Expand Up @@ -102,6 +102,7 @@ #include "mojo/public/cpp/bindings/self_owned_receiver.h" #include "services/image_annotation/public/mojom/ image_annotation.mojom.h" #include "third_party/blink/public/common/features.h" #include "third_party/blink/public/common/features_generated.h" #include "third_party/blink/public/mojom/credentialmanagement/ credential_manager.mojom.h" #include "third_party/blink/public/mojom/lcp_critical_path_predictor /lcp_critical_path_predictor.mojom.h" #include "third_party/blink/public/mojom/loader/ navigation_predictor.mojom.h" Expand Down @@ -880,7 +881,7 @@ void PopulateChromeFrameBinders( Expand Up } map->Add(base::BindRepeating( &ForwardToJavaWebContents)); if (base::FeatureList::IsEnabled(features::kWebEnvironmentIntegrity )) { if (base::FeatureList::IsEnabled(blink::features:: kWebEnvironmentIntegrity)) { map->Add( base::BindRepeating( & environment_integrity::AndroidEnvironmentIntegrityService::Create)); } Expand Down 5 changes: 3 additions & 2 deletions 5 components/ environment_integrity/android/ android_environment_integrity_service.cc [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line Diff line change line number number Expand Up @@ -16,6 +16,7 @@ #include "mojo/public/cpp/bindings/callback_helpers.h" #include "mojo/public/cpp/bindings/message.h" #include "mojo/public/cpp/bindings/pending_receiver.h" #include "third_party/blink/public/common/ features_generated.h" #include "url/origin.h" namespace environment_integrity { Expand Down @@ -82,12 +83,12 @@ Expand Up AndroidEnvironmentIntegrityService::GetDataManager() { void AndroidEnvironmentIntegrityService::GetEnvironmentIntegrity ( const std::vector& content_binding, GetEnvironmentIntegrityCallback callback) { if (!base::FeatureList::IsEnabled(features:: kWebEnvironmentIntegrity)) { if (!base::FeatureList::IsEnabled( blink::features::kWebEnvironmentIntegrity)) { ReportBadMessageAndDeleteThis( "Feature not enabled. IPC call not expected."); return; } if (!integrity_service_->IsIntegrityAvailable()) { std::move(callback).Run(EnvironmentIntegrityResponseCode:: kInternalError, std::vector()); Expand Down 7 changes: 5 additions & 2 deletions 7 components/ environment_integrity/android/ android_environment_integrity_service_unittest.cc [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line Diff line change line number number Expand Up @@ -22,6 +22,7 @@ #include "content/public/test/test_renderer_host.h" #include "content/public/test/web_contents_tester.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/blink/public/common/ features_generated.h" #include "third_party/blink/public/mojom/ environment_integrity/ environment_integrity_service.mojom.h" namespace environment_integrity { Expand Down @@ -109,7 +110,8 @@ class Expand Up AndroidEnvironmentIntegrityServiceTest public: void SetUp() override { BaseAndroidEnvironmentIntegrityServiceTest::SetUp(); feature_list_.InitAndEnableFeature(features:: kWebEnvironmentIntegrity); feature_list_.InitAndEnableFeature( blink::features::kWebEnvironmentIntegrity); } }; Expand Down @@ -467,7 +469,8 @@ class Expand Up AndroidEnvironmentIntegrityServiceDisabledFeatureTest public: void SetUp() override { BaseAndroidEnvironmentIntegrityServiceTest::SetUp(); feature_list_.InitAndDisableFeature(features:: kWebEnvironmentIntegrity); feature_list_.InitAndDisableFeature( blink::features::kWebEnvironmentIntegrity); } }; Expand Down 2 changes: 1 addition & 1 deletion 2 content/browser/ browser_interface_binders.cc [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line line Diff line change number number Expand Up @@ -1139,7 +1139,7 @@ void PopulateBinderMapWithContext( map->Add ( base::BindRepeating(& BrowsingTopicsDocumentHost::CreateMojoService)); } if (base::FeatureList::IsEnabled(features:: kWebEnvironmentIntegrity)) { if (base::FeatureList::IsEnabled(blink:: features::kWebEnvironmentIntegrity)) { map->Add ( base::BindRepeating( &EmptyBinderForFrame )); } Expand Down 1 change: 0 additions & 1 deletion 1 content/child/ runtime_features.cc [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line Diff line change line number number Expand Up @@ -392,7 +392,6 @@ void SetRuntimeFeaturesFromChromiumFeatures() { {"WebAppTabStrip", raw_ref(features::kDesktopPWAsTabStrip )}, {"WebAppTabStripCustomizations", raw_ref(blink::features:: kDesktopPWAsTabStripCustomizations)}, {"WebEnvironmentIntegrity", raw_ref(features:: kWebEnvironmentIntegrity)}, {"WebSerialBluetooth", raw_ref(features:: kEnableBluetoothSerialPortProfileInSerialApi)}, {"WGIGamepadTriggerRumble", Expand Down 5 changes: 0 additions & 5 deletions 5 content/public/common/ content_features.cc [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original file Diff line Diff line change line number number Expand Up @@ -1418,11 +1418,6 @@ BASE_FEATURE (kWebBluetoothNewPermissionsBackend, "WebBluetoothNewPermissionsBackend", base::FEATURE_DISABLED_BY_DEFAULT); // Enables the Web Environment Integrity API. BASE_FEATURE(kWebEnvironmentIntegrity, "WebEnvironmentIntegrity", base::FEATURE_DISABLED_BY_DEFAULT); // If WebGL Image Chromium is allowed, this feature controls whether it is // enabled. BASE_FEATURE(kWebGLImageChromium, Expand Down 1 change: 0 additions & 1 deletion 1 content/public/common/ content_features.h [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original file Diff line Diff line change line number number @@ -318,7 +318,6 @@ CONTENT_EXPORT Expand Up BASE_DECLARE_FEATURE (kWebAssemblyTrapHandler); CONTENT_EXPORT BASE_DECLARE_FEATURE( kWebAuthnTouchToFillCredentialSelection); CONTENT_EXPORT BASE_DECLARE_FEATURE( kWebBluetooth); CONTENT_EXPORT BASE_DECLARE_FEATURE( kWebBluetoothNewPermissionsBackend); CONTENT_EXPORT BASE_DECLARE_FEATURE( kWebEnvironmentIntegrity); CONTENT_EXPORT BASE_DECLARE_FEATURE( kWebGLImageChromium); CONTENT_EXPORT BASE_DECLARE_FEATURE(kWebMidi ); CONTENT_EXPORT BASE_DECLARE_FEATURE( kWebOtpBackendAuto); Expand Down 4 changes: 4 additions & 0 deletions 4 third_party/blink/renderer/ core/origin_trials/origin_trial_context.cc [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original Diff file line line Diff line change number number @@ -548,6 +548,10 @@ bool Expand Up OriginTrialContext::CanEnableTrialFromName (const StringView& trial_name) { return base::FeatureList::IsEnabled(features:: kComputePressure); } if (trial_name == "WebEnvironmentIntegrity") { return base::FeatureList::IsEnabled(features:: kWebEnvironmentIntegrity); } return true; } Expand Down 7 changes: 6 additions & 1 deletion 7 third_party/blink/renderer/ platform/runtime_enabled_features.json5 [*] Show comments View file Edit file Delete file This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters Original file Diff line Diff line change line number number Expand Up @@ -3906,8 +3906,13 @@ { name: "WebEnvironmentIntegrity", status: "experimental", base_feature: "none", origin_trial_feature_name: "WebEnvironmentIntegrity", // base_feature is meant as kill-switch. The RuntimeFeature should follow // the `status` field or Origin Trial unless explicitly overriden by // Finch / command line flags. base_feature_status: "enabled", copied_from_base_feature_if: "overridden", origin_trial_allows_third_party: true, }, { name: "WebFontResizeLCP", Expand Down Toggle all file notes Toggle all file annotations 127 comments on commit 6f47a22 Load more comments... @aeharding Copy link @aeharding aeharding commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Are you kidding me? edit: Sorry, something went wrong. 12 Technetium1, kyletolle, AlexLoyola, ad-daniel, tptee, ms-jpq, RIGIK93, sal-git, fchristant, TheLastProject, and 2 more reacted with thumbs up emoji All reactions * 12 reactions @macniel Copy link @macniel macniel commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Would please somebody think of the poor Ads!!! Sorry, something went wrong. 14 omgtehlion, kyletolle, sudoCss, ad-daniel, wallmenis, tptee, kautzz, amogusussy, MarcusWolschon, Hanmac, and 4 more reacted with laugh emoji All reactions * 14 reactions @4oo4 Copy link @4oo4 4oo4 commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Why even have a repository to solicit feedback when you're shipping this anyway and refuse to respond to even polite and thoughtful criticisms of the extremely weak and vague proposal, which as it stands has a very large risk of reinforcing Chromium browser monopoly and creates many opportunities for abuse? Does Google still think that antitrust laws don't apply to it? For everyone commenting here, please consider getting in touch with the relevant antitrust authorities. Comments alone will not work. US: https://www.ftc.gov/enforcement/report-antitrust-violation antitrust@ftc.gov EU: https://competition-policy.ec.europa.eu/antitrust/contact_en comp-greffe-antitrust@ec.europa.eu UK: https://www.gov.uk/guidance/ tell-the-cma-about-a-competition-or-market-problem general.enquiries@cma.gov.uk India: https://www.cci.gov.in/antitrust/ https://www.cci.gov.in/filing/atd Canada: https://www.competitionbureau.gc.ca/eic/site/cb-bc.nsf/frm-eng/ GH%C3%89T-7TDNA5 Sorry, something went wrong. 16 rfkat, joaogeada, ad-daniel, tptee, wojtekregis, floriantraber, Wilkolicious, rndrr, herrherrmann, raziel100, and 6 more reacted with thumbs up emoji 6 aeharding, herrherrmann, kyletolle, AlexLoyola, vluz, and arturh85 reacted with eyes emoji All reactions * 16 reactions * 6 reactions @th3maid Copy link @th3maid th3maid commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Snapshot_2023-07-26_12-46-06 A peaceful protest againt Web Environment Integrity #187 https://github.com/chromium/chromium/pull/187/files Sorry, something went wrong. 6 nitrixion, kyletolle, ad-daniel, wallmenis, Henning-K, and marklai1998 reacted with thumbs up emoji 2 sudoCss and wallmenis reacted with rocket emoji All reactions * 6 reactions * 2 reactions @TsukiZero Copy link @TsukiZero TsukiZero commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Google, please Shut Seagull Sorry, something went wrong. 15 th3maid, kyletolle, AlexLoyola, sudoCss, ad-daniel, astubenbord, tptee, srockw, wallmenis, Henning-K, and 5 more reacted with thumbs up emoji 6 RPiAwesomeness, kyletolle, sudoCss, ms-jpq, wallmenis, and OhaDerErste reacted with laugh emoji All reactions * 15 reactions * 6 reactions @sudoCss Copy link @sudoCss sudoCss commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Just Google being nasty and smelly as always[?] Sorry, something went wrong. 9 th3maid, Technetium1, kyletolle, rfkat, ad-daniel, AlexLoyola, TomicekRosic, Henning-K, and sal-git reacted with thumbs up emoji All reactions * 9 reactions @sudoCss Copy link @sudoCss sudoCss commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Perhaps a movement by developers and corporations all over the world to stop supporting Chromium based browsers will remind Google that people made Google a monopoly and people can throw it back in the gutter. Sorry, something went wrong. 8 toruzz, srockw, kyletolle, AlexLoyola, rndrr, wallmenis, Henning-K, and OhaDerErste reacted with thumbs up emoji All reactions * 8 reactions @pashynskykh Copy link @pashynskykh pashynskykh commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment It's a sad day for free and open Internet. We should stop supporting Google and its Chromium from dictating over how Internet should work. Google with all of its products should be avoided like a plague. Because it is a plague for the Internet. Sorry, something went wrong. 11 nitrixion, kyletolle, rfkat, sudoCss, ad-daniel, AlexLoyola, salif, tptee, rndrr, Henning-K, and smythp reacted with thumbs up emoji All reactions * 11 reactions @TsukiZero Copy link @TsukiZero TsukiZero commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment It's a sad day for free and open Internet. We should stop supporting Google and its Chromium from dictating over how Internet should work. Google with all of its products should be avoided like a plague. Because it is a plague for the Internet. We need to go back to the olde Firefox before they adopted Chromium. Which really won't be bad! Before Firefox adopted Chromium we had a greater deal of customization and flexibility! Sorry, something went wrong. 7 kyletolle, sudoCss, ad-daniel, AlexLoyola, tptee, Henning-K, and smythp reacted with thumbs up emoji All reactions * 7 reactions @kyletolle Copy link @kyletolle kyletolle commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Disgusting work here. The worst part about all the current tech megacorps is that they came into existence because of the very web they today despise, reject, and now want to end. Success breeds greed. Greed breeds hubris. The enshitification of all technology continues so a few rich and empty people can become a little richer and a lot emptier. Sorry, something went wrong. 3 AlexLoyola, rndrr, and Henning-K reacted with thumbs up emoji [?] 5 rfkat, sudoCss, ad-daniel, tptee, and smythp reacted with heart emoji All reactions * 3 reactions * [?] 5 reactions @kyletolle Copy link @kyletolle kyletolle commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment We will all welcome our CorpoAuthoritarian Overlords! Sorry, something went wrong. 2 Henning-K and zeitgenosse reacted with thumbs up emoji All reactions * 2 reactions @Seb24285 Copy link @Seb24285 Seb24285 commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Firefox exists. Sorry, something went wrong. 9 sudoCss, ad-daniel, astubenbord, AlexLoyola, tptee, TechScribe-Deaf, sn02, Henning-K, and zeitgenosse reacted with thumbs up emoji 3 sudoCss, AlexLoyola, and zaratropia reacted with rocket emoji All reactions * 9 reactions * 3 reactions @Kommynct Copy link @Kommynct Kommynct commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment So, isn't everyone going to be finding a way to work around this? Anybody got a project going for that yet? Sorry, something went wrong. 1 Henning-K reacted with thumbs up emoji All reactions * 1 reaction @telemakhos Copy link @telemakhos telemakhos commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Shame on Rayan Kanso rayankans@chromium.org Shame on Peter Pakkenberg pbirk@chromium.org Shame on Dmitry Gozman dgozman@chromium.org Shame on Richard Coles torne@chromium.org Shame on Kinuko Yasuda kinuko@chromium.org Shame on Rupert Ben Wiser: https://github.com/RupertBenWiser/ Web-Environment-Integrity Imagine the smelly spot in these guys CVs, forever Nice way to finish your career as an engineer... wtf were they thinking about? Sorry, something went wrong. 9 sudoCss, ad-daniel, dimaaan, rndrr, nicolaskopp, wallmenis, Henning-K, fernandescristo, and zaratropia reacted with laugh emoji All reactions * 9 reactions @HeroGamers Copy link @HeroGamers HeroGamers commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Well, I guess I'm done using Chromium. Long live the open and free internet. Sorry, something went wrong. 16 TCB13, sudoCss, kyletolle, ad-daniel, sciencemath, astubenbord, AlexLoyola, tptee, rndrr, srockw, and 6 more reacted with thumbs up emoji [?] 1 AlexLoyola reacted with heart emoji All reactions * 16 reactions * [?] 1 reaction @sebyx07 Copy link @sebyx07 sebyx07 commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Well, we can use it against google and the other bandits, like cloudflare. Fork the project, modify the source to give 'correct' values for the attestation, compile and run. Get the tokens. Profit, now we have bots that have human tokens Sorry, something went wrong. 2 gdprdatasubect and DarkenLM reacted with thumbs up emoji 1 Henning-K reacted with rocket emoji 1 sudoCss reacted with eyes emoji All reactions * 2 reactions * 1 reaction * 1 reaction @HeyBanditoz Copy link @HeyBanditoz HeyBanditoz commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Put me in the screenshot Sorry, something went wrong. All reactions @MrDanielHarka Copy link @MrDanielHarka MrDanielHarka commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Sorry, something went wrong. 1 Henning-K reacted with thumbs up emoji 1 rfkat reacted with rocket emoji All reactions * 1 reaction * 1 reaction @Daniel-Griffiths Copy link @Daniel-Griffiths Daniel-Griffiths commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Such a disappointment that this got merged... Sorry, something went wrong. 7 AlexLoyola, sudoCss, rfkat, rndrr, kautzz, smythp, and zaratropia reacted with thumbs up emoji [?] 1 rfkat reacted with heart emoji All reactions * 7 reactions * [?] 1 reaction @TechScribe-Deaf Copy link @TechScribe-Deaf TechScribe-Deaf commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment People need to stop using Chromium based browser altogether and switch to Firefox. It's purely out of necessity to deny Google the control of the internet. I have blacklisted Chrome and Chromium based browser from my office, I know it's not much. For everyone, please use literally anything else than Google's services or software. Libreoffice instead of Google Docs, PeerTube instead of YouTube, Kagi/Duckduckgo/Presearch/Anything else instead of Google Search and so go on. Literally anything else. Sorry, something went wrong. 8 AlexLoyola, sudoCss, salif, rndrr, gdprdatasubect, TomicekRosic, Henning-K, and smythp reacted with thumbs up emoji All reactions * 8 reactions @wallmenis Copy link @wallmenis wallmenis commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Time to install magisk props on my firefox browser Seriously though... With that type of skill, you can buy yourselves a much more respectable job at a much more humane company... Sorry, something went wrong. 4 AlexLoyola, sudoCss, Henning-K, and smythp reacted with thumbs up emoji 1 sudoCss reacted with laugh emoji All reactions * 4 reactions * 1 reaction @feribg Copy link @feribg feribg commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment lol 7ttrzh Sorry, something went wrong. 7 sudoCss, TechScribe-Deaf, gdprdatasubect, sn02, wallmenis, Henning-K, and dev-sda1 reacted with laugh emoji All reactions * 7 reactions @rfkat Copy link @rfkat rfkat commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Names (incomplete) of the people creating, and contributing to this abomination: Rupert Ben Wiser ben@chromium.org ben@benwiser.com Borbala Katalin Benko bbenko@google.com Philipp Pfeiffenberger philippp@gmail.com Sergey Kataev sergeyka@chromium.org sergeyka@google.com Rayan Kanso rayankans@chromium.org Peter Birk Pakkenberg pbirk@chromium.org Eric Trouton erictrouton@chromium.org Mihai Cirlanaru mcirlanaru@google.com Ryan Kalla ryankalla@google.com Dmitry Gozman dgozman@chromium.org Richard Coles torne@chromium.org Kinuko Yasuda kinuko@chromium.org Nick Gaw (Google) Public sources: * https://github.com/RupertBenWiser/Web-Environment-Integrity/blob/ main/explainer.md * 6f47a22 * https://groups.google.com/a/chromium.org/g/blink-dev/c/ Ux5h_kGO22g Sorry, something went wrong. 9 herrherrmann, Ultrabenosaurus, maxterry, Henning-K, arazilsongweaver, nitrixion, fernandescristo, zaratropia, and DarkenLM reacted with thumbs up emoji 1 rndrr reacted with eyes emoji All reactions * 9 reactions * 1 reaction @nickwinn Copy link @nickwinn nickwinn commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment "Those willing to give up their freedoms for security, deserve neither. " - Someone important Web Environment Integrity is DRM for websites, it will allow google (who is the biggest ad player on the web) to lock down and prevent adblock solutions. Web Environment Integrity will prevent the hiding or spoofing of any fingerprinting that may be occurring when you visit a site. Those fingerprints are logged, and sold to marketing companies and malicious actors posing as marketing companies, in addition to any information you've voluntarily shared. This technology will be abused and have major privacy implications against every internet user, greater than any benefits that might come from it. Side note: I encourage everybody to stop and think about how you're using google and consider the risk of google sharing all of it's information it's collected on you. Your information might not be important now, but you can't predict how it can be used against you in the future. Sorry, something went wrong. 12 TechScribe-Deaf, sudoCss, oyvindsk, rndrr, Ultrabenosaurus, maxterry, paoloap, TomicekRosic, wallmenis, arazilsongweaver, and 2 more reacted with thumbs up emoji 2 rfkat and wallmenis reacted with rocket emoji All reactions * 12 reactions * 2 reactions @overflowy Copy link @overflowy overflowy commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Sorry, something went wrong. 7 CalRobert, TechScribe-Deaf, maxterry, Henning-K, Blindmikey, zaratropia, and DarkenLM reacted with thumbs up emoji All reactions * 7 reactions @jfmcbrayer Copy link @jfmcbrayer jfmcbrayer commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment On the specification GitHub: "It's just a proposal! We don't even know what it is going to look like!" On the Chromium GitHub: implementation begun. Sorry, something went wrong. 12 rndrr, gdprdatasubect, sn02, TomicekRosic, Hanmac, lyptt, TomTheGeek, emanuelserpa, Henning-K, arazilsongweaver, and 2 more reacted with thumbs up emoji 6 sudoCss, msloth, b166er, Djcd, kescherCode, and dertuxmalwieder reacted with laugh emoji All reactions * 12 reactions * 6 reactions @linux-cultist Copy link @linux-cultist linux-cultist commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Not sure what to say. It's Google. It's like being surprised that Darth Vader kills people. The battle was 5 years ago but everyone had to use Chrome, use Google Mail and use Google Search because hey, it's free. Google just give away free stuff! Such nice guys. The interesting thing is that the involved parties here most likely think they are doing something good. There are many intelligent people who are incredibly stupid like that. Sorry, something went wrong. 4 sudoCss, gdprdatasubect, TomTheGeek, and Henning-K reacted with thumbs up emoji 1 sudoCss reacted with laugh emoji All reactions * 4 reactions * 1 reaction @adithya-s-sekhar Copy link @adithya-s-sekhar adithya-s-sekhar commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment @linux-cultist the sheer audacity to announce a discussion only through an employees personal git, which was then locked and then merging it into chrome with no official announcements from Google's part. It's clear that they know what they're doing is wrong. Don't be evil died a long time ago. Sorry, something went wrong. 9 rfkat, linux-cultist, sudoCss, Ultrabenosaurus, TomicekRosic, Henning-K, arazilsongweaver, nitrixion, and kescherCode reacted with thumbs up emoji All reactions * 9 reactions @PaulusParssinen Copy link @PaulusParssinen PaulusParssinen commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Sorry, something went wrong. 2 maxterry and Henning-K reacted with thumbs up emoji All reactions * 2 reactions @kautzz Copy link @kautzz kautzz commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Doctorow is right with everything: https://pluralistic.net/2023/07/24 /rent-to-pwn/#kitt-is-a-demon You are part of the problem not the solution. Rethink your employer choice if you have a shred of conscience left. Sorry, something went wrong. 5 maxterry, T3rminat0r, diederikdehaas, nitrixion, and kescherCode reacted with thumbs up emoji All reactions * 5 reactions @gdprdatasubect Copy link @gdprdatasubect gdprdatasubect commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment For me it seems like a bit liability issue to use an employees private code in your corporate project... What if someone distributes CSAM via these new channels, will they be complicit? Sorry, something went wrong. All reactions @Ultrabenosaurus Copy link @Ultrabenosaurus Ultrabenosaurus commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Don't forget to report this repo and @RupertBenWiser's "proposal" as malicious code. This is a blatant attack on the fundamental privacy and security of all web users, intentionally and crudely bypassing W3C and directly attacking open web standards. By infiltrating the Chromium project like this, rather than trialling it in their own Chrome browser, Google are intentionally seeking to infect the vast majority of Internet users' devices without most of them even knowing, even if they intentionally boycott Google over this attack. If WEI is implemented in web browsers, all users will be held hostage by companies to only use approved devices in approved ways to access approved websites, being tracked and exploited while doing so. This is infinitely malicious in every way except holding a knife to someone's throat. Then uninstall / disable all Chromium browsers on your devices and replace them with Firefox and / or Fennec F-Droid. Sorry, something went wrong. 7 rfkat, maxterry, Ph4te, sudoCss, T3rminat0r, kujaw, and wallmenis reacted with thumbs up emoji 2 kautzz and kujaw reacted with laugh emoji All reactions * 7 reactions * 2 reactions @krystofbe Copy link @krystofbe krystofbe commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Google turned to Evil Corp Sorry, something went wrong. 3 maxterry, kujaw, and wallmenis reacted with rocket emoji All reactions * 3 reactions @Hrxn Copy link @Hrxn Hrxn commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Bad move, very bad move. Sorry, something went wrong. 3 rfkat, kujaw, and Henning-K reacted with thumbs up emoji All reactions * 3 reactions @garfieldairlines Copy link @garfieldairlines garfieldairlines commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment No. Sorry, something went wrong. 2 rfkat and Henning-K reacted with thumbs up emoji All reactions * 2 reactions @sweidac Copy link @sweidac sweidac commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment We have been afraid of this since we have seen Chromium win the last browser war. Holy monopoly. I am mostly using FF, which isn't so bad that it could explain it's poor marketshare. It even supports extensions/adblockers on android To the big G: Sorry, something went wrong. 5 Ultrabenosaurus, TomicekRosic, kujaw, wallmenis, and Henning-K reacted with thumbs up emoji All reactions * 5 reactions @aspensmonster Copy link @aspensmonster aspensmonster commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Not with a bang, but a whimper. Sorry, something went wrong. 2 TomicekRosic and Henning-K reacted with confused emoji All reactions * 2 reactions @ryuukk Copy link @ryuukk ryuukk commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment it's part of the plan guys https://qz.com/1145669/ googles-true-origin-partly-lies-in-cia-and-nsa-research-grants-for-mass-surveillance same story with bitcoin/eth, it's for the digitial ID and the digital $ Sorry, something went wrong. 1 TomicekRosic reacted with thumbs up emoji All reactions * 1 reaction @ryuukk Copy link @ryuukk ryuukk commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment We have been afraid of this since we have seen Chromium win the last browser war. Holy monopoly. I am mostly using FF, which isn't so bad that it could explain it's poor marketshare. It even supports extensions/adblockers on android +1 To the big G: middle_finger mozilla is no different, it's like the left/right wing, the illusion of choice, you are just getting brainwashed, they'll follow google while telling you they are "against", it's called "controlling the opposition, pretend you oppose, just so they don't stray away" Sorry, something went wrong. All reactions @kujaw Copy link @kujaw kujaw commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment RupertBenWiser/Web-Environment-Integrity#134 Sorry, something went wrong. All reactions @wallmenis Copy link @wallmenis wallmenis commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Google turned to Evil Corp Ah yes! Finally some Mr. Robot refferences! But yeah, personally, back when the show aired, I'd say Microsoft is the Evil Corp... But now, Google looks like a WAY more likely candidate. Sundar should get his head straight and wake up from this greed inducing fantasy that every tech giant ceo has... No consideration for anyone else... These people are complete psychopaths. There is no way you haven't lost your soul and also do stuff like this... Sorry, something went wrong. 1 Henning-K reacted with thumbs up emoji All reactions * 1 reaction @wallmenis Copy link @wallmenis wallmenis commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment We have been afraid of this since we have seen Chromium win the last browser war. Holy monopoly. I am mostly using FF, which isn't so bad that it could explain it's poor marketshare. It even supports extensions/ adblockers on android +1 To the big G: middle_finger mozilla is no different, it's like the left/right wing, the illusion of choice, you are just getting brainwashed, they'll follow google while telling you they are "against", it's called "controlling the opposition, pretend you oppose, just so they don't stray away" It is the best thing we have for now... Personaly I would trust a non-profit instead a corporation any day! Sorry, something went wrong. All reactions @nicolaskopp Copy link @nicolaskopp nicolaskopp commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment The whole purpose of this feature in one sentence explained by google themselves: Users like visiting websites that are expensive to create and maintain, but they often want or need to do it without paying directly. Translation: Disable your adblocker or you can't visit this site. That is what this feature does. Nothing more, nothing less. The rest is fluff and smoke grenades. Sorry, something went wrong. 6 smythp, jfinkhaeuser, Henning-K, arazilsongweaver, Blindmikey, and kescherCode reacted with thumbs up emoji All reactions * 6 reactions @ii14 Copy link @ii14 ii14 commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment cringe Sorry, something went wrong. 1 gpanders reacted with thumbs up emoji All reactions * 1 reaction @emanuelserpa Copy link @emanuelserpa emanuelserpa commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment I will never use Chromium-based browsers again. Brave and Vivaldi should change to Gecko engine!!! Sorry, something went wrong. 2 jfinkhaeuser and CowCowFuture reacted with thumbs up emoji All reactions * 2 reactions @r7l Copy link @r7l r7l commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment People are better off with ungoogled software. Sorry, something went wrong. 1 smythp reacted with thumbs up emoji All reactions * 1 reaction @shanet Copy link @shanet shanet commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment If you're angry at Google for such a terrible proposal and use Google for search, vote with your wallet and consider a paid alternative like Kagi. (I have no affiliation with them, I'm just someone who decided to make the switch because Google is obviously an unchecked monopoly at this point). Sorry, something went wrong. All reactions @VegaDeftwing Copy link @VegaDeftwing VegaDeftwing commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment The whole purpose of this feature in one sentence explained by google themselves: Users like visiting websites that are expensive to create and maintain, but they often want or need to do it without paying directly. Translation: Disable your adblocker or you can't visit this site. That is what this feature does. Nothing more, nothing less. The rest is fluff and smoke grenades. And we shouldn't pretend that this is Google just looking out for other website's bottom line. They're an advertising business at their core. They want their cut and to be able to promise to ad buyers that each ad is actually seen by real eye ball. FWIW, Google does have a point - many of us do rely on ad supported websites - but the solution to that isn't to stop ad blockers, it's to invest in smaller, decentralized systems that don't require ads to fund their existence. Sorry, something went wrong. 3 Henning-K, Ultrabenosaurus, and Blindmikey reacted with thumbs up emoji All reactions * 3 reactions @r7l Copy link @r7l r7l commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment @VegaDeftwing Google is talking about a problem they've helped to create in the first place. Instead of keeping a single ad on a website people in marketing positions decided to add ads to every possible spot on their websites in order to earn more money. This turned into a race to bottom with ads being cheaper and cheaper and websites adding more and more of them. This is what turned news sites into barely readable ad invested shitholes. And even worse this so called expensive content has been optimized up to the point where the only reason the content has even been created is for baiting people in clicks. That's the state of ad driven content these days. And on top of that ads are a walking a privacy invasion. They want to optimize their ads more and more by collecting every click and even further in order to build better advertising profiles. Quality content is behind paywalls lately anyways. Sorry, something went wrong. 3 Ultrabenosaurus, VegaDeftwing, and Henning-K reacted with thumbs up emoji [?] 1 Ultrabenosaurus reacted with heart emoji All reactions * 3 reactions * [?] 1 reaction @Blindmikey Copy link @Blindmikey Blindmikey commented on 6f47a22 Jul 26, 2023 * edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Users like visiting websites that are expensive to create and maintain, but they often want or need to do it without paying directly. Then those websites can develop their own paywalls. This "Web Environment Integrity" work by Google is an afront to everyone. It's a disgusting money grab and vehemently against the open web. Sorry, something went wrong. 1 Henning-K reacted with thumbs up emoji All reactions * 1 reaction @kescherCode Copy link @kescherCode kescherCode commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment I made a much better proposal https://github.com/kescherCode/ Web-Disintegration Sorry, something went wrong. All reactions @fchristant Copy link @fchristant fchristant commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment I ran into Satan today and he was devastated. He was bewildered how not even from the darkest pits of his depraved imagination he was able to produce a proposal the likes of this. He had a sudden case of imposter syndrome, as if he no longer was in charge of darkness. Just before he strolled back into the flames he did offer some enhancement requests, which I'll hereby pass on: * When visiting a website, the webcam should power on forcefully after which AI will detect if you're watching the ad. * A new "Enthusiastic Consent API" will monitor cooperative ad viewing so that disinterested haters can be blocked from the website. * Experimental: hidden flashing pixels that codify and trigger an immediate buy action in the human brain. * Forced integration with Google wallet to close the loop: watch, buy, pay are fully automated so that users can browse the web with convenience. * Moonshot: flash ads so hard that it destroy people's eyesight, so that they all need glasses which will project ads. * Eradicate the outdated idea of "content", replace with ads such that ads are the content. * Sue everybody on the dark web because we're in need of that name. * Get some congress members on the payroll to explain that this is great for GDP. * Poor people are to be blocked from websites since they have no money to buy the advertised things. Send them to the ad moderation fields. * Ensure advertised goods are so crappy as to break down during shipping, fueling the need for continuous ads of the same thing. It's a lot, but I guess every step towards eternal flames is a win. Sorry, something went wrong. 2 Ultrabenosaurus and Henning-K reacted with thumbs up emoji [?] 2 Ultrabenosaurus and dertuxmalwieder reacted with heart emoji All reactions * 2 reactions * [?] 2 reactions @OhaDerErste Copy link @OhaDerErste OhaDerErste commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment shut up google Sorry, something went wrong. All reactions @747475838291 Copy link @747475838291 747475838291 commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment It is unfortunate yet entirely unsurprising that Google would move forward with this despite public outcry. This in no way benefits users or websites and is objectively harmful to an open web. Sorry, something went wrong. 2 Henning-K and Blindmikey reacted with thumbs up emoji All reactions * 2 reactions @n3ph Copy link @n3ph n3ph commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Sorry, something went wrong. 1 Henning-K reacted with thumbs up emoji All reactions * 1 reaction @atharvashukla Copy link @atharvashukla atharvashukla commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Are there any WEI blockers in development? Sorry, something went wrong. All reactions @Betanc0urt Copy link @Betanc0urt Betanc0urt commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Remember when Internet Explorer was the default? Chrome can die too, Google. Sorry, something went wrong. All reactions @TechScribe-Deaf Copy link @TechScribe-Deaf TechScribe-Deaf commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Firefox is a natural WEI blocker. Sorry, something went wrong. All reactions @geeknik Copy link @geeknik geeknik commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment Long live the open web! Sorry, something went wrong. All reactions @alyssarowan Copy link @alyssarowan alyssarowan commented on 6f47a22 Jul 26, 2023 There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. [Choose a reason] Hide comment NAK. This doesn't belong on the World Wide Web. Sorry, something went wrong. All reactions Please sign in to comment. Footer (c) 2023 GitHub, Inc. Footer navigation * Terms * Privacy * Security * Status * Docs * Contact GitHub * Pricing * API * Training * Blog * About You can't perform that action at this time.