https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

Skip to content
GitLab [gif]

  *  

Projects Groups Snippets

  * [                    ]
    /
  *  

  * Help
      + 
      + Help
      + Support
      + Community forum
      + Keyboard shortcuts ?
      + 
      + Submit feedback
      + Contribute to GitLab
  * Register
  * Sign in

Toggle navigation Menu

  * wine wine
  * Project information
      + Project information
      + 
      + Activity
      + Labels
      + Members
  * Repository
      + Repository
      + 
      + Files
      + Commits
      + Branches
      + Tags
      + Contributors
      + Graph
      + Compare
  * Bugzilla
      + Bugzilla
  * Merge requests 219
      + Merge requests 219
  * CI/CD
      + CI/CD
      + 
      + Pipelines
      + Jobs
      + Schedules
  * Deployments
      + Deployments
      + 
      + Releases
  * Packages and registries
      + Packages and registries
      + 
      + Container Registry
  * Analytics
      + Analytics
      + 
      + Value stream
      + CI/CD
      + Repository
  * External wiki
      + External wiki
  * Snippets
      + Snippets
  * Activity
  * Graph
  * Jobs
  * Commits

Collapse sidebar Close sidebar
Open sidebar

  * winewine
  * winewine
  * Merge requests
  * !2275

winewayland.drv: part 1: Introduce the Wayland driver

Code

  * Review changes
  * Check out branch
  * -----------------------------------------------------------------
  * Download
  *  
    Email patches
  *  
    Plain diff

Open Alexandros Frantzis requested to merge afrantzis/
wine:wayland-part-1 into master Feb 24, 2023

  * Overview 4
  * Commits 10
  * Pipelines 1
  * Changes 18

  Introduction

 

This is the first of (many) parts in the upstreaming of the Wayland
driver for Wine. Since the amount of code and commits is large, my
approach is to upstream the driver in multiple parts in a serial
fashion, with each part being a cohesive (to the degree possible) set
of not too many commits. When each part is reviewed and merged, I
will move on to proposing the next part. My main goal with this
approach is to make reviewing easier and more focused. If you have
other ideas about how to improve this process for the reviewers,
please let me know.

 

A lot of pieces need to fall into place before the driver becomes
even remotely functional, so, some MRs (especially the initial ones)
will be a bit more preparatory in nature. To aid in the understanding
of and justification for some of the code introduced in such MRs, all
the remaining driver commits are always going to be available at
https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland.

 

  Part 1

 

This MR introduces the Wayland driver PE and unixlib components with
some basic code, and prepares the makedep tool to be able to handle
Wayland protocol files. Please see the individual commit message for
more details.

 

Some questions I would appreciate some feedback on in the context of
this MR:

 

     
 1. Should the Wayland driver build be enabled by default at this
    point? (currently it's explicitly opt-in with --with-wayland) 
 2. How should the Wayland driver build be integrated with CI?
    (currently piggybacking on gitlab/build-linux by adding
    --with-wayland) 

 

Note that building the Wayland driver should not affect running/
testing on X11/Xwayland etc, since it's placed lower in the driver
priority list.

 

Part 2 preview: We will handle basic Wayland wl_output (i.e.,
display) events and populate the Wine monitor information.

[                    ]
Assignee
Select assignee
Assign to
[                    ]
Reviewers
Select reviewer(s)
Request review from
[                    ]
Time tracking
Source branch: wayland-part-1