https://github.com/github/feedback/discussions/12341 Skip to content Sign up * Product + Features + Mobile + Actions + Codespaces + Packages + Security + Code review + Issues + Integrations + GitHub Sponsors + Customer stories * Team * Enterprise * Explore + Explore GitHub + Learn and contribute + Topics + Collections + Trending + Learning Lab + Open source guides + Connect with others + The ReadME Project + Events + Community forum + GitHub Education + GitHub Stars program * Marketplace * Pricing + Plans + Compare plans + Contact Sales + Education [ ] * # In this repository All GitHub | Jump to | * No suggested jump to results * # In this repository All GitHub | Jump to | * # In this organization All GitHub | Jump to | * # In this repository All GitHub | Jump to | Sign in Sign up {{ message }} github / feedback Public * Notifications * Fork 463 * Star 1.8k * Code * Pull requests 0 * Discussions * Actions * Security * Insights More * Code * Pull requests * Discussions * Actions * Security * Insights Pull Request File Tree Feedback #12341 Unanswered willsmythe asked this question in Pull Requests Feedback Pull Request File Tree Feedback #12341 @willsmythe willsmythe Mar 3, 2022 * 146 answers * 95 replies Return to top [250] willsmythe Mar 3, 2022 Collaborator - For the past few months, we've been working hard to improve the Pull Request experience. One of the features we're most excited about: Pull Request File Tree. The new tree: * Improves ease of navigation between files * Gives you a quick understanding of the number and types of changes * Helps you focus your review by letting you filter the tree by file or folder name [156570120-574a6f58-75fa-4cf8-af1a-12fb78cc021b] How to enable the preview The feature preview is rolling out now. Once it is available to you, it will appear in Feature Previews. Just enable the Pull Request File Tree feature. Known issues We're still working on the feature. Here are a few known issues that you may encounter: 1. The state of the "Show/Hide file tree" toggle is not remembered (the plan is to store in local browser storage) 2. There are a few quirks related to the scroll position when a file is clicked in certain cases (like when clicking the same file twice in succession) Feedback Your feedback will help inform what's ultimately shipped in the public release, so please let us know what you think below. We're excited to hear from you :octocat: 151 248 1 2 57 2 [?] 209 46 6 Replies 146 suggested answers * 95 replies Oldest Newest Top [288] dpromanko Mar 3, 2022 - Great addition to PR reviews! This is a much easier way to navigate and visualize changes in a PR. If/when this hits public release please give the option to pin it to the right side instead of only the left! 46 1 1 reply @willsmythe willsmythe Mar 3, 2022 Collaborator Author - Thanks for the feedback! We'll look into it. [211] zoispag Mar 3, 2022 - Looks good! Even if really big PRs, I can finally filter using part of the filename, which was close to impossible before! 19 3 [?] 6 1 0 replies edited [280] TheFruxz Mar 3, 2022 - Great addition! But I think, that a indicator should be added, at which File you are currently looking (because you can scroll like before, but the indicator itself does not update its location) 63 9 3 7 replies @gwillcox-r7 gwillcox-r7 Mar 3, 2022 - If you click the file name on the left it should highlight the file view for the file you are looking at in a blue outline? 3 1 @aubergine10 edited aubergine10 Mar 3, 2022 - Maybe highlight background of the tree showing which files are currently in view? A bit like sidebar in some code editors (eg. this from Atom minimap addon): image 6 @TheFruxz TheFruxz Mar 3, 2022 - Maybe highlight background of the tree showing which files are currently in view? A bit like sidebar in some code editors (eg. this from Atom minimap addon): image I think, that this would be a great addition too View more [826] stephenwf Mar 3, 2022 - Looks great so far if I had some suggestions for improvements: * Hiding/marking files after being marked as "viewed" * Resizing of the left size panel, for those longer files and folders And a single bug I've come across * The top file or folder is hidden when stickied to the top after scrolling if you have a notification banner visible 129 11 12 replies @gwillcox-r7 gwillcox-r7 Mar 3, 2022 - +1 on option for hiding reviewed files from the file tree, sometimes we have PRs with 300+ files and it becomes a hassle to navigate such a file tree in this case. Having the option to hide reviewed/viewed files would help tremendously. 30 @tngranados tngranados Mar 3, 2022 - +1 I think it would be great if viewed files and folder containing only viewed files had a green tick or something like that indicating that they have been marked as "viewed". Also, a good default could be that folders containing only viewed files are collapsed by default 34 @matteokov matteokov Mar 3, 2022 - @tngranados Yea, a green mark or any kind of indicator would be enough :) 5 View more [478] nubcake94 Mar 3, 2022 - Great addition! Found a possible bug: * The first file/folder in the file tree is scrolled under the notification bar when scrolling. 11 3 replies @ansballard ansballard Mar 3, 2022 - Same here, will tag on with my detail. Looks like when selecting the first directory/file in the tree ([class^=file-tree-item]), the window scrolls down to match the top of the "Conversation", "Commits", etc tabs (.tabnav). When clicking either any file in the tree other than the first, it scrolls down past the first previewed file (.file), which then uses the floating pr toolbar (.pr-toolbar). Seems like this might be because the floating header only shows once your viewport meets the top of the first previewed file. Not sure if that scrollto logic needs to have the offset updated to make sure it scrolls enough to show the floating toolbar without hiding the file title (.file-info). Sorry for the lack of screenshot/video, can't share from this repo. @heaths heaths Mar 3, 2022 - I'm seeing this as well. Here's a couple of screenshots if that helps: folder hidden under top bar Screenshot 2022-03-03 100538 Then if I scroll the main page all the way up, only then does it show: folder shown at top of main page Screenshot 2022-03-03 100445 1 @agusmba agusmba Mar 4, 2022 - I'm seeing this too. If I dismiss the notification banner, it works as expected, but I think it should also show the first files even if I haven't dismissed the notification. [571] skunert Mar 3, 2022 - Looks good. As a suggestion I would like to see which files have comments in the tree. 47 2 replies @TimWerdin TimWerdin Mar 3, 2022 - +1 I'm also missing this after using Better Pull Request for GitHub Chrome plugin for years already 5 @StingyJack StingyJack Mar 4, 2022 - I had to disable this preview and keep using that plugin. 1 edited [121] rafaelrenanpacheco Mar 3, 2022 - Looks not so good on 4k resolution: image 14 3 replies @johannesvollmer johannesvollmer Mar 3, 2022 - Transforming this into constructive feedback: It would be great if long file names and deeply nested files would be shown completely, especially where large screens offer a lot of space. Maybe make it a resizable pane? 23 @rafaelrenanpacheco rafaelrenanpacheco Mar 3, 2022 - I agree, if they keep the 100% width, then there's room to enhance the tree max width based on resolution. The main issue I see is actually the code diff, it is hard to read (and compare) texts spread across the entire screen. Even the side-by-side code diff still has a lot of empty spaces. Another suggestion would be to let the user choose the screen layout, between full-width or limited to a shorter range. If I remember gitlab has an option like this that affects the entire app. 3 @Consolatis Consolatis Mar 3, 2022 - Code diff of 100% is way too big on higher resolution screens (especially if the project is using a col limit of 80) and doesn't change to the old width if hiding the tree either. I had to enable the feature preview and disable it again to get back to a sane width of the diff. Please provide an option so the diff is limited in size + centered like without this new feature. In the current state it makes reading through a diff way too difficult. 5 [579] DmitryBarskov Mar 3, 2022 - I like it but I wanted to disable it to test something but disabling it in feature preview does nothing and I still seeing file tree. 6 5 replies @aubergine10 aubergine10 Mar 3, 2022 - You can hide tree via small text link that appears above tree image @DanielRamp DanielRamp Mar 3, 2022 - I think I had the same problem. Just do a reload with F5 or Ctrl+R or even Ctrl+F5 or Ctrl+Shift+R. The enabled disabled status seems a bit unstable. @willsmythe willsmythe Mar 7, 2022 Collaborator Author - Thanks for the feedback. There was an issue on Friday where the tree was enabled for everyone, but nobody could disable it as a feature preview. This has been addressed. We're also working to save the state of the hide/show toggle, so you don't have to continually toggle it off to hide. View more [251] jpbnetley Mar 3, 2022 - Love the new feature. I have a potential feature suggestion. Could a shade of colour be added to the tree for all of the files that are marked as viewed? So for argument's sake, if we mark a file as viewed, a light grey color gets set in the file tree. Here is a mock up of how it could look if a file is marked as viewed Screenshot 2022-03-03 165139 12 2 replies @aubergine10 aubergine10 Mar 3, 2022 - Maybe just dim viewed files, and also a button to hide them completely (also hiding any folders that are fully viewed)? 6 @kowolm kowolm Mar 11, 2022 - Agree! It would be very useful! edited [458] rochacbruno Mar 3, 2022 - This is a great feature! I am already using an extension for PR tree, is in the road map to implement the features of the browser extension? * diff stats next to file * count of the changed lines * icons * indication that there are comments on the file Screenshot_2022-03-03_14-59-02 28 10 4 replies @oleg-andreyev oleg-andreyev Mar 3, 2022 - In addition, it would be great to show "checked" icon near file if files a "Viewed" (checkbox) 7 @DanielRamp edited DanielRamp Mar 3, 2022 - Aren't we soon gonna have a vscode instance built-in with this many features? Don't get me wrong, the seem cool but just a little (to) much. 2 @Klaster1 Klaster1 Mar 3, 2022 - Really love that extension, all the indicators it adds really contribute to the efficiency of reviews, which I do a lot of. View more [145] aunsbjerg Mar 3, 2022 - Nice addition. The feature does not seem to work in the commits tab of the PR. In our shop, we typically do commit-by-commit reviews and rarely use the files changed. It would be nice to have the file tree in commits as well. 15 2 replies @iomariani iomariani Mar 4, 2022 - Second that! Commits tab and commits comparison as well! @EzraLopez EzraLopez Mar 5, 2022 - +1 Please add support for commit-by-commit reviews. I love how @berzniz handles it in his chrome extension. [110] tfevan Mar 3, 2022 - This is such a great feature. 3 0 replies [201] senhalil Mar 3, 2022 - First of all amazing feature, cheers! In a long diff, clicking a file name for the first time correctly positions the view and highlights the file with blue marker but clicking a second time moves the view a bit down and obscures the highlight. I would expect the second click do nothing -- maybe fold/unfold the file. 3 1 reply @willsmythe willsmythe Mar 7, 2022 Collaborator Author - Thanks for the feedback. We're looking into this. edited [138] aubergine10 Mar 3, 2022 - It's really useful but some minor points: * It's eating lots of horizontal room, making side-by-side diffs a bit harder to read * Maybe shrink the font size a bit? * Maybe have a splitter that allows tree width to be reduced/ increased? * Tooltips on the glyphs at right hand side of tree (eg. denoting new file, changed file, etc) would help new users * Maybe dim the folders + their names (unless they are added/ removed) to make changed file names stand out more? * Would changing colour/hue/whatever of / slashes in folder paths help differentiate from the folder names? * Maybe file type icons, except for the most common filetype in a repo? (eg. in csharp repo, things like csproj and sln would get custom icons to make them stand out, but cs files would use default icon to reduce visual complexity) * An option to view only file selected in the tree (eg. hide everything else so I can focus on that file) * Some way to see in the tree whether file is marked viewed? 19 1 reply @etarasoff-va edited etarasoff-va Mar 3, 2022 - An option to view only file selected in the tree (eg. hide everything else so I can focus on that file) I'd be happy with just having the search show/hide the file in the main view, rather than just in the tree side-panel. Because some projects commit their library files into the repo (for reliability), some of the PRs I need to review have 1000+ files. If I could do something like hide all files under vendor/ (Golang) or under Node_modules/ (Angular) that would be amazing! :) 2 [240] markstory Mar 3, 2022 - I like the ability to navigate the file tree, but I wish it would remember whether the drawer/sidebar was open/closed. I often have GitHub in a narrow window (as GitHub is fits comfortably in a narrow window), but with the file tree defaulting to open the space for the diff is greatly reduced. 9 2 replies @nickvanw nickvanw Mar 3, 2022 - I came here to say exactly this! There are some PRs and repositories that I want it on, and some that I usually don't. It would be great if the tree would stay hidden if I've hidden it before - even as a global setting - instead of requiring me to hide it every time. 6 @willsmythe willsmythe Mar 7, 2022 Collaborator Author - Thanks for the feedback. We're working on saving the state of the hide/show toggle. 116 hidden items Load more... [519] wayne-shih Mar 10, 2022 - THIS FEATURE IS GLORIOUS! didn't ask for it, but man this is exactly what I needed 1 0 replies [593] stefanmatar Mar 10, 2022 - Hey, can we have a simple tooltip if I hover over a filename? They are cut off and I can't view the full filename without clicking on an element 3 0 replies [536] Dorukyum Mar 10, 2022 - I really like this addition. Navigating through the files was always a big problem for me, especially on big pull requests. I couldn't keep track of the locations of all the files. This is very helpful, and I also like the design. 1 0 replies [346] imbdb Mar 10, 2022 - Great feature that eases up code review process. Very helpful. 1 0 replies [970] ayush-sha256 Mar 10, 2022 - Very helpful feature. 1 0 replies [625] christopher-caldwell Mar 10, 2022 - I absolutely love this! I have used Azure DevOps previously and really missed this file tree feature. Big thumbs up and it works really well. 1 0 replies [440] RussKie Mar 11, 2022 - Please have a look at how https://github.com/berzniz/github_pr_tree provided this experience. 1 0 replies [427] lfades Mar 11, 2022 - I would like to see folders first in the order, like in VS Code. 3 1 reply @themisir themisir Mar 11, 2022 - Yes I agree. Seems a bit confusing when a new package added to nodejs project so you see items in this order: package.json src/ -- src/something ---- src/something/something yarn.lock I used to see package.json alongside with yarn.lock [162] wdanilo Mar 11, 2022 - It's almost perfect. Could it also display files not changed by the PR? Very often I want to see other filets get context information. 2 0 replies [112] spnkr Mar 11, 2022 - I really like this!! 1 0 replies [284] Jericho1060 Mar 11, 2022 - really apreciated feature. One thing i would love to see : a small badge on collapse directories to display how many changed files are in 1 0 replies [784] martinbrunodev Mar 11, 2022 - Great feature! 1 0 replies [120] djcprinse Mar 11, 2022 - Great feature. I would like to have directories and files sorted the same way as in the source view. So directories on top, files at the bottom, ordered alphabetically. It is something I am missing in the current diff view too. I'm working with Bitbucket Server mainly for work, where this is the default. With large PR's, GitHub is a little confusing in my opinion mixing up directories and files. 1 0 replies [837] KUTlime Mar 11, 2022 - I tried the feature, but I have to say that I don't need this. Most of my PRs are small with low number of changed files. In such PR, the feature doesn't bring any value to me, only take space on the screen which is a reason why I disabled it. On big PR, it would be helpful, but a button Show tree would be enough to display the tree if I need it. The default - tree hidden works better for me. 1 0 replies [532] Ph0tonic Mar 11, 2022 - This is a really great feature, and maybe it could also be integrated in the compare view. I believe it's the same principle as we just show 2 versions of some files. * laravel/framework@v9.3.0...v9.4.0 2 0 replies Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment Category [?] Pull Requests Feedback Labels feedback wanted ANNOUNCEMENT pull requests Beta 31 participants @spnkr @markstory @zellyn @danuker @flatcap @rmehner @foosel @ecartz @MaxDesiatov @teastburn @Plasma @elsassph @BevanR @vcsjones @tomdcc @tevelee @rochacbruno @riverar @rmuir @miketheman @tlhunter and others Add heading text Add bold text, Add italic text, Add a quote, Add code, Insert Link Link Text [ ] URL [ ] Add Add a link, Add a bulleted list, Add a numbered list, Add a task list, Directly mention a user or team Reference an issue or pull request Add heading text Add bold text, Add italic text, Add a bulleted list, Add a numbered list, Add a task list, 1 1 1 1 1 [?] 1 1 1 * (c) 2022 GitHub, Inc. * Terms * Privacy * Security * Status * Docs * Contact GitHub * Pricing * API * Training * Blog * About You can't perform that action at this time. You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.