https://github.com/notepad-plus-plus/notepad-plus-plus/commit/06657c82b3b9a1871c483982282f046b1ac7b3be Skip to content Sign up * Why GitHub? Features - + Mobile - + Actions - + Codespaces - + Packages - + Security - + Code review - + Project management - + Integrations - + GitHub Sponsors - + Customer stories- * Team * Enterprise * Explore + Explore GitHub - Learn and contribute + Topics - + Collections - + Trending - + Learning Lab - + Open source guides - Connect with others + The ReadME Project - + Events - + Community forum - + GitHub Education - + GitHub Stars program - * Marketplace * Pricing Plans - + Compare plans - + Contact Sales - + Education - [ ] [search-key] * # In this repository All GitHub | Jump to | * No suggested jump to results * # In this repository All GitHub | Jump to | * # In this organization All GitHub | Jump to | * # In this repository All GitHub | Jump to | Sign in Sign up {{ message }} notepad-plus-plus / notepad-plus-plus * Notifications * Star 13.4k * Fork 3.2k * Code * Issues 1.3k * Pull requests 36 * Actions * Projects 0 * Wiki * Security * Insights More * Code * Issues * Pull requests * Actions * Projects * Wiki * Security * Insights Permalink This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository. Browse files Remove Microsoft Bing from search engines for Search on Internet command Ref: https://www.reuters.com/technology/microsoft-bing-raises-concerns-over-lack-image-results-tiananmen-tank-man-2021-06-04/ When a search engin does the censorship instead of its job, the search result loses its quality and it's not reliable anymore. Hence, Microsoft Bing is removed from Notepad++ for "Search on Internet" command. * Loading branch information @donho donho committed Jun 6, 2021 1 parent 0e1a466 commit 06657c82b3b9a1871c483982282f046b1ac7b3be Unified Split Showing 4 changed files with 12 additions and 22 deletions. 1. +1 -5 PowerEditor/src/NppCommands.cpp 2. +7 -8 PowerEditor/src/WinControls/Preference/preference.rc 3. +3 -8 PowerEditor/src/WinControls/Preference/preferenceDlg.cpp 4. +1 -1 PowerEditor/src/WinControls/Preference/preference_rc.h 6 PowerEditor/src/NppCommands.cpp [*] Show comments View file Edit file Delete file @@ -497,18 +497,14 @@ void Notepad_plus::command(int id) url = TEXT("https://www.google.com/search?q=$(CURRENT_WORD)"); } } else if (nppGui._searchEngineChoice == nppGui.se_duckDuckGo) else if (nppGui._searchEngineChoice == nppGui.se_duckDuckGo || nppGui._searchEngineChoice == nppGui.se_bing) { url = TEXT("https://duckduckgo.com/?q=$(CURRENT_WORD)"); } else if (nppGui._searchEngineChoice == nppGui.se_google) { url = TEXT("https://www.google.com/search?q=$(CURRENT_WORD)"); } else if (nppGui._searchEngineChoice == nppGui.se_bing) { url = TEXT("https://www.bing.com/search?q=$(CURRENT_WORD)"); } else if (nppGui._searchEngineChoice == nppGui.se_yahoo) { url = TEXT("https://search.yahoo.com/search?q=$(CURRENT_WORD)"); 15 PowerEditor/src/WinControls/Preference/preference.rc [*] Show comments View file Edit file Delete file @@ -432,14 +432,13 @@ STYLE DS_SETFONT | DS_FIXEDSYS | DS_CONTROL | WS_CHILD FONT 8, "MS Shell Dlg", 0, 0, 0x1 BEGIN GROUPBOX "Search Engine (for command ""Search on Internet"") ",IDC_SEARCHENGINES_GB_STATIC,74,24,297,145,BS_CENTER CONTROL "DuckDuckGo",IDC_SEARCHENGINE_DUCKDUCKGO_RADIO,"Button",BS_AUTORADIOBUTTON,105,37,180,10 CONTROL "Google",IDC_SEARCHENGINE_GOOGLE_RADIO,"Button",BS_AUTORADIOBUTTON,105,52,180,10 CONTROL "Bing",IDC_SEARCHENGINE_BING_RADIO,"Button",BS_AUTORADIOBUTTON,105,67,180,10 CONTROL "Yahoo! ",IDC_SEARCHENGINE_YAHOO_RADIO,"Button",BS_AUTORADIOBUTTON,105,82,180,10 CONTROL "Stack Overflow",IDC_SEARCHENGINE_STACKOVERFLOW_RADIO,"Button",BS_AUTORADIOBUTTON,105,97,180,10 CONTROL "Set your search engine here:",IDC_SEARCHENGINE_CUSTOM_RADIO, "Button",BS_AUTORADIOBUTTON,105,112,180,10 EDITTEXT IDC_SEARCHENGINE_EDIT,114,128,179,14,ES_AUTOHSCROLL LTEXT "Example: https://www.google.com/search?q=$(CURRENT_WORD) ",IDD_SEARCHENGINE_NOTE_STATIC,114,143,245,20 CONTROL "DuckDuckGo",IDC_SEARCHENGINE_DUCKDUCKGO_RADIO,"Button",BS_AUTORADIOBUTTON,105,43,180,10 CONTROL "Google",IDC_SEARCHENGINE_GOOGLE_RADIO,"Button",BS_AUTORADIOBUTTON,105,58,180,10 CONTROL "Yahoo! ",IDC_SEARCHENGINE_YAHOO_RADIO,"Button",BS_AUTORADIOBUTTON,105,73,180,10 CONTROL "Stack Overflow",IDC_SEARCHENGINE_STACKOVERFLOW_RADIO,"Button",BS_AUTORADIOBUTTON,105,88,180,10 CONTROL "Set your search engine here:",IDC_SEARCHENGINE_CUSTOM_RADIO,"Button",BS_AUTORADIOBUTTON,105,103,180,10 EDITTEXT IDC_SEARCHENGINE_EDIT,114,119,179,14,ES_AUTOHSCROLL LTEXT "Example: https://www.google.com/search?q=$(CURRENT_WORD) ",IDD_SEARCHENGINE_NOTE_STATIC,114,134,245,20 END 11 PowerEditor/src/WinControls/Preference/preferenceDlg.cpp [*] Show comments View file Edit file Delete file @@ -3688,10 +3688,12 @@ INT_PTR CALLBACK SearchEngineSubDlg::run_dlgProc(UINT message, WPARAM wParam, LP nppGUI._searchEngineChoice = nppGUI.se_google; } } if (nppGUI._searchEngineChoice == nppGUI.se_bing) nppGUI._searchEngineChoice = nppGUI.se_duckDuckGo; ::SendDlgItemMessage(_hSelf, IDC_SEARCHENGINE_CUSTOM_RADIO, BM_SETCHECK, nppGUI._searchEngineChoice == nppGUI.se_custom ? BST_CHECKED : BST_UNCHECKED, 0); ::SendDlgItemMessage(_hSelf, IDC_SEARCHENGINE_DUCKDUCKGO_RADIO, BM_SETCHECK, nppGUI._searchEngineChoice == nppGUI.se_duckDuckGo ? BST_CHECKED : BST_UNCHECKED, 0); ::SendDlgItemMessage(_hSelf, IDC_SEARCHENGINE_GOOGLE_RADIO, BM_SETCHECK, nppGUI._searchEngineChoice == nppGUI.se_google ? BST_CHECKED : BST_UNCHECKED, 0); ::SendDlgItemMessage(_hSelf, IDC_SEARCHENGINE_BING_RADIO, BM_SETCHECK, nppGUI._searchEngineChoice == nppGUI.se_bing ? BST_CHECKED : BST_UNCHECKED, 0); ::SendDlgItemMessage(_hSelf, IDC_SEARCHENGINE_YAHOO_RADIO, BM_SETCHECK, nppGUI._searchEngineChoice == nppGUI.se_yahoo ? BST_CHECKED : BST_UNCHECKED, 0); ::SendDlgItemMessage(_hSelf, IDC_SEARCHENGINE_STACKOVERFLOW_RADIO, BM_SETCHECK, nppGUI._searchEngineChoice == nppGUI.se_stackoverflow ? BST_CHECKED : BST_UNCHECKED, 0); @@ -3718,13 +3720,6 @@ INT_PTR CALLBACK SearchEngineSubDlg::run_dlgProc(UINT message, WPARAM wParam, LP } break; case IDC_SEARCHENGINE_BING_RADIO: { nppGUI._searchEngineChoice = nppGUI.se_bing; ::EnableWindow(::GetDlgItem(_hSelf, IDC_SEARCHENGINE_EDIT), false); } break; case IDC_SEARCHENGINE_YAHOO_RADIO: { nppGUI._searchEngineChoice = nppGUI.se_yahoo; 2 PowerEditor/src/WinControls/Preference/preference_rc.h [*] Show comments View file Edit file Delete file @@ -152,7 +152,7 @@ #define IDC_SEARCHENGINES_GB_STATIC (IDD_PREFERENCE_SUB_SEARCHENGINE + 1) #define IDC_SEARCHENGINE_DUCKDUCKGO_RADIO (IDD_PREFERENCE_SUB_SEARCHENGINE + 2) #define IDC_SEARCHENGINE_GOOGLE_RADIO (IDD_PREFERENCE_SUB_SEARCHENGINE + 3) #define IDC_SEARCHENGINE_BING_RADIO (IDD_PREFERENCE_SUB_SEARCHENGINE + 4) //#define IDC_SEARCHENGINE_BING_RADIO (IDD_PREFERENCE_SUB_SEARCHENGINE + 4) #define IDC_SEARCHENGINE_YAHOO_RADIO (IDD_PREFERENCE_SUB_SEARCHENGINE + 5) #define IDC_SEARCHENGINE_CUSTOM_RADIO (IDD_PREFERENCE_SUB_SEARCHENGINE + 6) #define IDC_SEARCHENGINE_EDIT (IDD_PREFERENCE_SUB_SEARCHENGINE + 7) Toggle all file notes Toggle all file annotations 21 comments on commit 06657c8 @FireController1847 This comment has been minimized. Sign in to view Copy link Quote reply @FireController1847 FireController1847 replied Jun 7, 2021 * edited I don't think this is a good idea. It's an open-source community project removing a feature due to choices made by others completely unrelated to the project. It's introducing politics into something that really shouldn't have anything to do with politics... Bing has done much, much more for the better than the worse (and to say Google's made similar mistakes would be an understatement)... Seems like an unnecessary bias toward a genuinely good search engine. Why not just keep it as an option? I don't see the benefit in removing this. 32 71 1 @FreeHongKong-PP This comment has been minimized. Sign in to view Copy link Quote reply @FreeHongKong-PP FreeHongKong-PP replied Jun 7, 2021 * edited I don't think this is a good idea. It's an open-source community project removing a feature due to choices made by others completely unrelated to the project. It's introducing politics into something that really shouldn't have anything to do with politics... Bing has done much, much more for the better than the worse (and to say Google's made similar mistakes would be an understatement)... Seems like an unnecessary bias toward a genuinely good search engine. Why not just keep it as an option? I don't see the benefit in removing this. I think we have the responsibility as part of the "open source" community and such action from the author is trying to point out there is zero tolerance to dictatorship/censorship in an open source community. it's introducing politics into something that really shouldn't have anything to do with politics. Sorry but I disagree, everything is related to politics, it's just whether you ignore it or not. "Just because you do not take an interest in politics doesn't mean politics won't take an interest in you. " 65 9 2 @AllenBrook This comment has been minimized. Sign in to view Copy link Quote reply @AllenBrook AllenBrook replied Jun 7, 2021 Zhe Chong Zuo Fa Ke Yi Ti Xing Bie Ren bingBu Zai Ke Xin ,Xin Ren Shi Zhu Jian Liu Shi Diao De ,Liang Bian Dao Zhi Bian This approach can remind others that bing is not credible, trust is gradually lost, and the quantity changes to the qualitative change. @FireController1847 This comment has been minimized. Sign in to view Copy link Quote reply @FireController1847 FireController1847 replied Jun 7, 2021 * edited @FreeHongKong-PP While it is our responsibility as people to be involved in politics, it is not our responsibility to remove features relating to these services for accusations as simple as that one. If you actually put a few ounces of research into this instead of baselessly going off into believing the first words you see, you'd find that Bing is actually far more trustworthy than Google, and that Bing has done far more for the community. Simply put if we're removing Bing, remove Google too. I will note though, the bias towards Google due to popularity would get more pushback. I guess popularity excuses their actions though, doesn't it? Bing is a trustworthy source, now whether or not you agree with me is fine, but it should continue to be the choice of the users of the application to choose whether or not they want to use the service, not the application developers to force users into using different services. 18 9 @logg-sar This comment has been minimized. Sign in to view Copy link Quote reply @logg-sar logg-sar replied Jun 7, 2021 Sorry but I disagree, everything is related to politics, it's just whether you ignore it or not. "Just because you do not take an interest in politics doesn't mean politics won't take an interest in you. " Well - you are complaining that bing wasn't showing one specific picture and you seems to believe in censorship, so you remove bing. But with this removal you censor and limit the free choice of every user. Why is a censorship done by you OK but a (*) censorship done by bing not? (*) possible insertions * accidentally * temporarily * by human error * already reverted Will you revert it with the next release? As bing corrected th error? 14 11 @jonasnordlund This comment has been minimized. Sign in to view Copy link Quote reply @jonasnordlund jonasnordlund replied Jun 7, 2021 * edited Since it was fixed within hours, for all we know it could be a mistake leading to censorship leak into international results. I mean, Google and others has at one point or another wanted to censor results for the Chinese market. With this move, Notepad++ devs must also answer to the question on why they give the Chinese government a free pass and only react to when censorship issues arise within the Western market. I'd rather say: Don't go there altogether. 15 1 @dertuxmalwieder This comment has been minimized. Sign in to view Copy link Quote reply @dertuxmalwieder dertuxmalwieder replied Jun 7, 2021 there is zero tolerance to dictatorship/censorship in an open source community. Then maybe Google should be removed as well. 19 2 @AGlezB This comment has been minimized. Sign in to view Copy link Quote reply @AGlezB AGlezB replied Jun 7, 2021 @FreeHongKong-PP While it is our responsibility as people to be involved in politics, it is not our responsibility to remove features relating to these services for accusations as simple as that one. If you actually put a few ounces of research into this instead of baselessly going off into believing the first words you see, you'd find that Bing is actually far more trustworthy than Google, and that Bing has done far more for the community. Simply put if we're removing Bing, remove Google too. I will note though, the bias towards Google due to popularity would get more pushback. I guess popularity excuses their actions though, doesn't it? Bing is a trustworthy source, now whether or not you agree with me is fine, but it should continue to be the choice of the users of the application to choose whether or not they want to use the service, not the application developers to force users into using different services. * Bing is actually far more trustworthy than Google * Bing has done far more for the community * Bing is a trustworthy source @FireController1847 would you mind sharing the evidence for those claims? It might be a lack of information on my part, but my own experience with MS it that is a very large bussines which spends a lot in implementing data collection features, more than Google and Apple and Facebook put together. If I'm mistaken I would like to know, so please share. 1 4 @waschinski This comment has been minimized. Sign in to view Copy link Quote reply @waschinski waschinski replied Jun 7, 2021 It might be a lack of information on my part, but my own experience with MS it that is a very large bussines which spends a lot in implementing data collection features, more than Google and Apple and Facebook put together. If I'm mistaken I would like to know, so please share. I have no evidence (who really can have any?) but in my book Google and Facebook are way bigger in the whole data collection business. I have more trust in Microsoft and Apple than the other two big companies. Apple even enforces some privacy (or at least privacy visibility) on their users as of lately. Regardless of what we think we know or not, I agree with @dertuxmalwieder in having to remove Google as well then. Basically any search engine run by a business because you can't trust any of them, can you? 4 1 3 @ocdtrekkie This comment has been minimized. Sign in to view Copy link Quote reply @ocdtrekkie ocdtrekkie replied Jun 7, 2021 Note that Microsoft said this was in error and intends to correct it. I would highlight that if Google is left on this list, we're saying censorship is wrong, but providing AI-based targeting services for militarized drones is not. (The Maven contract was canceled via employee protest, but the company leadership was heavily in support.) @svetob This comment has been minimized. Sign in to view Copy link Quote reply @svetob svetob replied Jun 7, 2021 * edited I'm happy that you have the guts to stand up for what is right, I would though recommend reverting this change and putting Bing back if they do indeed correct the error and allow search hits for the Tank Man picture. Bing is in many ways more trustworthy than Google, and if this is indeed a mistake, we would be hurting a smaller but more well-intentioned engine. @jbmorgado This comment has been minimized. Sign in to view Copy link Quote reply @jbmorgado jbmorgado replied Jun 7, 2021 * edited DuckDuckGo also seems to have censored it during the same period: https://news.ycombinator.com/item?id=27394925 6 @tomchapin This comment has been minimized. Sign in to view Copy link Quote reply @tomchapin tomchapin replied Jun 7, 2021 Am I the only person who finds it ironic that someone would make a statement like, "there is zero tolerance to dictatorship/censorship in an open source community" while effectively committing an act of censorship themselves by removing bing as a search option in an open source project? 7 11 1 1 @IThinkImOKAY This comment has been minimized. Sign in to view Copy link Quote reply @IThinkImOKAY IThinkImOKAY replied Jun 7, 2021 death to censorship @Gullinkambi07 This comment has been minimized. Sign in to view Copy link Quote reply @Gullinkambi07 Gullinkambi07 replied Jun 7, 2021 Hen Hao banLiao bingEr Ji Xu Shi Yong google Zhe Ge Ji Duan Hua De Shi Jie Jian Zhi Tai Mei Miao Liao Bad money drives out good @monksy This comment has been minimized. Sign in to view Copy link Quote reply @monksy monksy replied Jun 7, 2021 hours It still hasn't been fixed. The image results are from articles talking about the censure. https://imgur.com/a/P9l23Di @warent This comment has been minimized. Sign in to view Copy link Quote reply @warent warent replied Jun 7, 2021 * edited @tomchapin Am I the only person who finds it ironic that someone would make a statement like, "there is zero tolerance to dictatorship/ censorship in an open source community" while effectively committing an act of censorship themselves by removing bing as a search option in an open source project? The irony only exists if we miss the fact that this is a double negative. A censoring of censorship, or in other words a denial of censorship, is also known as free speech and information. @nick-s-b This comment has been minimized. Sign in to view Copy link Quote reply @nick-s-b nick-s-b replied Jun 7, 2021 Why is DDG still here when it too was censoring? It's just a proxy for Bing. Get rid of it as well. 1 @TemporalAgent7 This comment has been minimized. Sign in to view Copy link Quote reply @TemporalAgent7 TemporalAgent7 replied Jun 7, 2021 Please also remove Yahoo and DuckDuckGo, for the same reason. Thank you! @tihsamikah This comment has been minimized. Sign in to view Copy link Quote reply @tihsamikah tihsamikah replied Jun 7, 2021 DuckDuckGo also seems to have censored it during the same period: https://news.ycombinator.com/item?id=27394925 DDG uses Bing @AGlezB This comment has been minimized. Sign in to view Copy link Quote reply @AGlezB AGlezB replied Jun 7, 2021 I have no evidence (who really can have any?) but in my book Google and Facebook are way bigger in the whole data collection business. I have more trust in Microsoft and Apple than the other two big companies. Apple even enforces some privacy (or at least privacy visibility) on their users as of lately. You just made my point: Nobody knows. Knowing whom to trust is a problem as old as mankind and when large companies are involved the solution is even more complicated. Kicking and screaming won't change that fact. Because of that, enabling/disabling search engines citing trust issues is an endless game of Whac-A-Mole. I'm Ok with making a statement but doing it half-a**ed won't benefit anyone. These are the choices: 1. Leave everything disabled. 2. Leave everything enabled. 3. Have a group o people monitoring all search engines and enabling/ disabling them (and releasing a new version) as the situation changes, a.k.a Whac-A-Mole. At this time (3) is in the lead and winning by a wide marging... which makes no sense to me. Of course that would change if someone had solid evidence one way or another and so I did ask @FireController1847 about it, which some people obviously didn't like. Also here is my evidence: image 30 days of NextDNS logs for a single Windows host after opting out of everything MS allows. And that is only Windows and (unfortunately) Skype. I don't use any other MS product, not even Edge. Please sign in to comment. * (c) 2021 GitHub, Inc. * Terms * Privacy * Security * Status * Docs * Contact GitHub * Pricing * API * Training * Blog * About You can't perform that action at this time. You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.