https://www.phoronix.com/scan.php?page=news_item&px=Linux-5.13-UMN-Fixes Phoronix * Articles & Reviews * News Archive * Forums * Premium * Categories * Computers * Display Drivers * GPUs / Graphics Cards * Linux Gaming * Memory * Motherboards * CPUs / Processors * Software * Storage * Operating Systems * Peripherals * Close * * Articles & Reviews * News Archive * Forums * Premium * Categories Computers GPUs / Graphics Cards Linux Gaming Memory Motherboards CPUs / Processors Software Storage Operating Systems Peripherals * [ ] [Search] We Rely On Your Support: Did you know that the hundreds of articles written on Phoronix each month are mostly authored by one individual working insane hours? Phoronix.com doesn't have a whole news room with unlimited resources and relies upon people reading our content without blocking ads and alternatively by people subscribing to Phoronix Premium for our ad-free service with other extra features. You can also consider a tip via PayPal. Linux 5.13 Reverts + Fixes The Problematic University of Minnesota Patches Written by Michael Larabel in Linux Kernel on 21 May 2021 at 07:55 AM EDT. 7 Comments LINUX KERNEL -- One month ago the University of Minnesota was banned from contributing to the Linux kernel when it was revealed the university researchers were trying to intentionally submit bugs into the kernel via new patches as "hypocrite commits" as part of a questionable research paper. Linux kernel developers have finally finished reviewing all UMN.edu patches to address problematic merges to the kernel and also cleaning up / fixing their questionable patches. Sent in on Thursday by Greg Kroah-Hartman was char/misc fixes for 5.13-rc3. While char/misc fixes at this mid-stage of the kernel cycle tend to not be too exciting, this pull request has the changes for addressing the patches from University of Minnesota researchers. Greg noted in the pull: The majority here is the fallout of the umn.edu re-review of all prior submissions. That resulted in a bunch of reverts along with the "correct" changes made, such that there is no regression of any of the potential fixes that were made by those individuals. I would like to thank the over 80 different developers who helped with the review and fixes for this mess. Going by the umn.edu Git activity that puts 37 patches as having been reverted with this pull request. The reverts span from ALSA to the media subsystem, networking, and other areas. That is 37 reverts out of 150+ patches from umn.edu developers over the years. Here are some of the technical explanations for some of the problems with their patches: The original commit message for this change was incorrect as the code path can never result in a NULL dereference, alluding to the fact that whatever tool was used to "find this" is broken. It's just an optional resource reservation, so removing this check is fine ### While the original commit does keep the immediate "NULL dereference" from happening, it does not properly propagate the error back to the callers, AND it does not fix this same identical issue in the drivers/net/ethernet/cavium/liquidio/ lio_vf_main.c for some reason. ### This commit is not correct, it should not have used unlikely() and is not propagating the error properly to the calling function, so it should be reverted at this point in time. Also, if the check failed, the work queue was still assumed to be allocated, so further accesses would have continued to fail, meaning this patch does nothing to solve the root issues at all. ### Upon review, this commit was found to be not be needed at all as the change was useless because this function can only be called when of_match_device matched on something. So it should be reverted. Among the other patches that ended up being reverted for having no substantive value or at worst incorrect/incomplete code... 7 Comments Tweet [INS::INS] Related News New Patches Posted For Linux Runtime Verification Multigen LRU Patches Updated For Addressing Linux's Expensive Page Reclaimation The Growing Number Of AI Accelerator Drivers Reignites Linux Kernel Driver Debate Linux 5.13-rc2 Released With A VGA Text Mode Fix Linux 5.14 To Bring SimpleDRM Driver, VC4 HDR, Marks More AGP Code As Legacy Looking At An Early Performance Regression In Linux 5.13 - Scheduler Related About The Author Author picture Michael Larabel is the principal author of Phoronix.com and founded the site in 2004 with a focus on enriching the Linux hardware experience. Michael has written more than 20,000 articles covering the state of Linux hardware support, Linux performance, graphics drivers, and other topics. Michael is also the lead developer of the Phoronix Test Suite, Phoromatic, and OpenBenchmarking.org automated benchmarking software. He can be followed via Twitter or contacted via MichaelLarabel.com. Popular News This Week The Story Of PipeWire & How It's Getting Ready To Handle Linux Audio + Video Linux 5.13 Reverts + Fixes The Problematic University of Minnesota Patches Zstd 1.5 Released With Big Performance Improvements OpenPrinting Now Developing Upstream CUPS, Apple Bows Out Zink OpenGL-On-Vulkan Now "100%-1000% Faster" For Many Scenarios Linux 5.14 To Bring SimpleDRM Driver, VC4 HDR, Marks More AGP Code As Legacy KDE Plasma 5.22 Beta Ready For Testing With Much Better Wayland Experience KDE Continues Pushing More Wayland Fixes Into Plasma 5.22 Latest Linux News RHEL 8.4 Released With Tiger Lake Graphics, Expanded eBPF Support Wine 6.9 Released With More Improvements For Running Windows Apps/ Games On Linux SiFive HiFive Unmatched RISC-V Developer Boards Begin Shipping NVIDIA 470 Series To Be The Last Supporting GTX 600/700 Series Kepler Linux 5.13 Reverts + Fixes The Problematic University of Minnesota Patches AMD "Beige Goby" GPU Support Targeting Linux 5.14 Inclusion ASpeed AST2500 SSIF BMC Driver Being Worked On For The Linux Kernel Intel's IGC Graphics Compiler 1.0.7423 Brings 100+ Changes PipeWire 0.3.28 Released With More PulseAudio Modules Implemented Red Hat Is Hiring Even More Graphics Engineers Show Your Support, Go Premium Phoronix Premium allows ad-free access to the site, multi-page articles on a single page, and other features while supporting this site's continued operations. Latest Featured Articles Clear Linux Offers Up Advantages For Ice Lake Xeon, CentOS Comes In Strong LLVM Clang 12 Compiler Is Performing Very Well For AMD Ryzen 9 5950X / Zen 3 Ampere Is Designing Their Own Arm Server CPU Cores, Coming In 2022 Ubuntu 20.04.2 LTS / 20.10 / 21.04 Performance On Intel Xeon Scalable Ice Lake GCC 11 vs. LLVM Clang 12 Performance On The Intel Core i9 11900K Is A Heated Race Support Phoronix The mission at Phoronix since 2004 has centered around enriching the Linux hardware experience. In addition to supporting our site through advertisements, you can help by subscribing to Phoronix Premium. You can also contribute to Phoronix through a PayPal tip. Phoronix Media --------------------------------------------------------------------- * OpenBenchmarking.org Phoronix Premium --------------------------------------------------------------------- * Support Phoronix * While Having Ad-Free Browsing, * Single-Page Article Viewing Share --------------------------------------------------------------------- * Facebook * Twitter * Legal Disclaimer, Privacy Policy | Contact * Copyright (c) 2004 - 2021 by Phoronix Media. * All trademarks used are properties of their respective owners. All rights reserved.