https://github.com/brave/brave-core/pull/8468 Skip to content Sign up Sign up * Why GitHub? Features - + Mobile - + Actions - + Codespaces - + Packages - + Security - + Code review - + Project management - + Integrations - + GitHub Sponsors - + Customer stories- * Team * Enterprise * Explore + Explore GitHub - Learn and contribute + Topics - + Collections - + Trending - + Learning Lab - + Open source guides - Connect with others + The ReadME Project - + Events - + Community forum - + GitHub Education - + GitHub Stars program - * Marketplace * Pricing Plans - + Compare plans - + Contact Sales - + Education - [ ] [search-key] * # In this repository All GitHub | Jump to | * No suggested jump to results * # In this repository All GitHub | Jump to | * # In this organization All GitHub | Jump to | * # In this repository All GitHub | Jump to | Sign in Sign up Sign up {{ message }} brave / brave-core * Notifications * Star 1.1k * Fork 366 * Code * Pull requests 110 * Actions * Security * Insights More * Code * Pull requests * Actions * Security * Insights New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Pick a username [ ] Email Address [ ] Password [ ] [ ] Sign up for GitHub By clicking "Sign up for GitHub", you agree to our terms of service and privacy statement. We'll occasionally send you account related emails. Already on GitHub? Sign in to your account Jump to bottom 14942: Disable FLoC features and the provider service. #8468 Merged iefremov merged 1 commit into master from ie_disable_floc Apr 8, 2021 Merged 14942: Disable FLoC features and the provider service. #8468 iefremov merged 1 commit into master from ie_disable_floc Apr 8, 2021 +60 -0 Conversation 3 Commits 1 Checks 4 Files changed 7 Conversation @iefremov Copy link Quote reply Contributor @iefremov iefremov commented Apr 7, 2021 * edited by fmarier Resolves brave/brave-browser#14942 Submitter Checklist: * [*] I confirm that no security/privacy review is needed, or that I have requested one * [*] There is a ticket for my issue * [*] Used Github auto-closing keywords in the PR description above * [*] Wrote a good PR/commit description * [ ] Added appropriate labels (QA/Yes or QA/No; release-notes/ include or release-notes/exclude; OS/...) to the associated issue * [*] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint * [*] Ran git rebase master (if needed) Reviewer Checklist: * [ ] A security review is not needed, or a link to one is included in the PR description * [ ] New files have MPL-2.0 license header * [ ] Adequate test coverage exists to prevent regressions * [ ] Major classes, functions and non-trivial code blocks are well-commented * [ ] Changes in component dependencies are properly reflected in gn * [ ] Code follows the style guide * [ ] Test plan is specified in PR before merging After-merge Checklist: * [ ] The associated issue milestone is set to the smallest version that the changes has landed on * [ ] All relevant documentation has been updated, for instance: + [ ] https://github.com/brave/brave-browser/wiki/ Deviations-from-Chromium-(features-we-disable-or-remove) + [ ] https://github.com/brave/brave-browser/wiki/ Proxy-redirected-URLs + [ ] https://github.com/brave/brave-browser/wiki/ Fingerprinting-Protections + [ ] https://github.com/brave/brave-browser/wiki/ Brave%E2%80%99s-Use-of-Referral-Codes + [ ] https://github.com/brave/brave-browser/wiki/ Custom-Headers + [ ] https://github.com/brave/brave-browser/wiki/ Web-Compatibility-Exceptions-in-Brave + [ ] https://github.com/brave/brave-browser/wiki/QA-Guide + [ ] https://github.com/brave/brave-browser/wiki/P3A Test Plan: 1. Open brave://components and make sure that there is no Federated Learning of Cohorts component: Screenshot from 2021-04-09 17-14-41 2. Open the devtools console, type document.interestCohort() and confirm that you get an error: Screenshot from 2021-04-09 17-09-09 1 @iefremov iefremov requested review from bridiver and brave/ patch-reviewers as code owners Apr 7, 2021 @iefremov iefremov force-pushed the ie_disable_floc branch from 024c0e9 to 3ba2d20 Apr 7, 2021 @iefremov iefremov requested review from jumde and mkarolin Apr 7, 2021 @iefremov Copy link Contributor Author @iefremov iefremov commented Apr 7, 2021 As per the issue FLoC client-side determinations of cohorts The service is completely disabled Any reporting of FLoC cohort determinations to Google (or otherwise) servers (i.e., the reporting used for k-anonymity cohort protections) covered with kFlocIdComputedEventLogging FLoC JS methods (i.e. document.interestCohort) covered with kInterestCohortAPIOriginTrial Any UI related to the FloC permission (i.e., interest-cohort) not sure what it is yet @iefremov iefremov force-pushed the ie_disable_floc branch from 3ba2d20 to 8e968f5 Apr 7, 2021 @iefremov 14942: Disable FLoC features and the provider service. Loading status checks... c6a2754 @iefremov iefremov force-pushed the ie_disable_floc branch from 8e968f5 to c6a2754 Apr 7, 2021 @mkarolin mkarolin approved these changes Apr 8, 2021 View changes Copy link Quote reply Contributor @mkarolin mkarolin left a comment LGTM @bridiver bridiver approved these changes Apr 8, 2021 View changes Hide details View details @iefremov iefremov merged commit 676d293 into master Apr 8, 2021 9 of 11 checks passed 9 of 11 checks passed Analyze (javascript) Details Analyze (python) Details continuous-integration/ios/pr-head This commit cannot be built Details continuous-integration/macos/pr-head This commit cannot be built Details CodeQL No new or fixed alerts Details SonarCloud Code Analysis Quality Gate passed Details continuous-integration/android/pr-head This commit looks good Details continuous-integration/linux/pr-head This commit looks good Details continuous-integration/post-init/pr-head This commit looks good Details continuous-integration/pre-init/pr-head This commit looks good Details continuous-integration/windows/pr-head This commit looks good Details @iefremov iefremov deleted the ie_disable_floc branch Apr 8, 2021 mariospr added a commit that referenced this pull request Apr 9, 2021 @mariospr Drop use of federated_learning::kFlocIdSortingLshBasedComputation ... Loading status checks... 765039c This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992 @kjozwiak kjozwiak added this to the 1.25.x - Nightly milestone Apr 9, 2021 @kjozwiak kjozwiak mentioned this pull request Apr 9, 2021 Disable FLoC in Brave brave/brave-browser#14942 Closed @kjozwiak Copy link Member @kjozwiak kjozwiak commented Apr 9, 2021 Adding this into the 1.25.x milestone as this landed in master. Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment Reviewers @bridiver bridiver @mkarolin mkarolin @jumde jumde Assignees No one assigned Labels None yet Projects None yet Milestone 1.25.x - Nightly 4 participants @iefremov @kjozwiak @bridiver @mkarolin Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. * (c) 2021 GitHub, Inc. * Terms * Privacy * Security * Status * Docs * Contact GitHub * Pricing * API * Training * Blog * About You can't perform that action at this time. You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.