https://github.com/git/git/blob/master/banned.h

Skip to content
 
Sign up

  * Why GitHub?
    Features -
      + Mobile -
      + Actions -
      + Codespaces -
      + Packages -
      + Security -
      + Code review -
      + Project management -
      + Integrations -
      + GitHub Sponsors -
      + Customer stories-
  * Team
  * Enterprise
  * Explore
      + Explore GitHub -

    Learn and contribute

      + Topics -
      + Collections -
      + Trending -
      + Learning Lab -
      + Open source guides -

    Connect with others

      + The ReadME Project -
      + Events -
      + Community forum -
      + GitHub Education -
      + GitHub Stars program -
  * Marketplace
  * Pricing
    Plans -
      + Compare plans -
      + Contact Sales -
      + Nonprofit -
      + Education -

[                    ] [search-key]

  *  
    #
    In this repository All GitHub |
    Jump to |

  * No suggested jump to results

  *  
    #
    In this repository All GitHub |
    Jump to |
  *  
    #
    In this organization All GitHub |
    Jump to |
  *  
    #
    In this repository All GitHub |
    Jump to |

Sign in Sign up
{{ message }}

git / git

  * Notifications
  * Star 36.2k
  * Fork 21k

  * Code
  * Pull requests 52
  * Actions
  * Security
  * Insights

More

  * Code
  * Pull requests
  * Actions
  * Security
  * Insights

Permalink
master
Switch branches/tags
[                    ]
Branches Tags
Nothing to show
{{ refName }} default View all branches
Nothing to show
{{ refName }} default
View all tags

git/banned.h

Go to file

  * Go to file T
  * Go to line L
  * 
  * Copy path
  * Copy permalink

@peff
peff banned.h: mark ctime_r() and asctime_r() as banned
...
Latest commit 91aef03 Dec 1, 2020 History

The ctime_r() and asctime_r() functions are reentrant, but have
no check that the buffer we pass in is long enough (the manpage says it
"should have room for at least 26 bytes"). Since this is such an
easy-to-get-wrong interface, and since we have the much safer strftime()
as well as its more convenient strbuf_addftime() wrapper, let's ban both
of those.

Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2 contributors

Users who have contributed to this file

@peff @ttaylorr
45 lines (39 sloc) 1.08 KB
Raw Blame
   

 #ifndef BANNED_H
 #define BANNED_H
 /*
 * This header lists functions that have been banned from our code
 base,
 * because they're too easy to misuse (and even if used correctly,
 * complicate audits). Including this header turns them into
 compile-time
 * errors.
 */
 #define BANNED(func) sorry_##func##_is_a_banned_function
 #undef strcpy
 #define strcpy(x,y) BANNED(strcpy)
 #undef strcat
 #define strcat(x,y) BANNED(strcat)
 #undef strncpy
 #define strncpy(x,y,n) BANNED(strncpy)
 #undef strncat
 #define strncat(x,y,n) BANNED(strncat)
 #undef sprintf
 #undef vsprintf
 #ifdef HAVE_VARIADIC_MACROS
 #define sprintf(...) BANNED(sprintf)
 #define vsprintf(...) BANNED(vsprintf)
 #else
 #define sprintf(buf,fmt,arg) BANNED(sprintf)
 #define vsprintf(buf,fmt,arg) BANNED(vsprintf)
 #endif
 #undef gmtime
 #define gmtime(t) BANNED(gmtime)
 #undef localtime
 #define localtime(t) BANNED(localtime)
 #undef ctime
 #define ctime(t) BANNED(ctime)
 #undef ctime_r
 #define ctime_r(t, buf) BANNED(ctime_r)
 #undef asctime
 #define asctime(t) BANNED(asctime)
 #undef asctime_r
 #define asctime_r(t, buf) BANNED(asctime_r)
 #endif /* BANNED_H */

  * Copy lines
  * Copy permalink
  * View git blame

[                    ] Go
  * (c) 2021 GitHub, Inc.
  * Terms
  * Privacy
  * Security
  * Status
  * Docs

 

  * Contact GitHub
  * Pricing
  * API
  * Training
  * Blog
  * About

You can't perform that action at this time.
You signed in with another tab or window. Reload to refresh your
session. You signed out in another tab or window. Reload to refresh
your session.