From kaeptn@omnisec.de  Tue Jul  4 16:37:42 2006
Return-Path: <kaeptn@omnisec.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8B3E516A4E1
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  4 Jul 2006 16:37:42 +0000 (UTC)
	(envelope-from kaeptn@omnisec.de)
Received: from host.omnisec.de (host.omnisec.de [62.245.232.135])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 46C1A43D5C
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  4 Jul 2006 16:37:34 +0000 (GMT)
	(envelope-from kaeptn@omnisec.de)
Received: from tek.flintsbach.schmalzbauer.de (tek.flintsbach.schmalzbauer.de [172.21.2.3])
	by host.omnisec.de (8.13.7/8.13.7) with ESMTP id k64GbX8B009492
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 4 Jul 2006 18:37:33 +0200 (CEST)
	(envelope-from kaeptn@tek.flintsbach.schmalzbauer.de)
Received: from tek.flintsbach.schmalzbauer.de (localhost [127.0.0.1])
	by tek.flintsbach.schmalzbauer.de (8.13.6/8.13.6) with ESMTP id k64GbXPE039547
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 4 Jul 2006 18:37:33 +0200 (CEST)
	(envelope-from kaeptn@tek.flintsbach.schmalzbauer.de)
Received: (from root@localhost)
	by tek.flintsbach.schmalzbauer.de (8.13.6/8.13.6/Submit) id k64GbWgU039546;
	Tue, 4 Jul 2006 18:37:32 +0200 (CEST)
	(envelope-from kaeptn)
Message-Id: <200607041637.k64GbWgU039546@tek.flintsbach.schmalzbauer.de>
Date: Tue, 4 Jul 2006 18:37:32 +0200 (CEST)
From: Harald Schmalzbauer <kaeptn@omnisec.de>
Reply-To: Harald Schmalzbauer <kaeptn@omnisec.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: cups-base OPTIONS don't work and 1.2.1 has been released
X-Send-Pr-Version: 3.113
X-GNATS-Notify: asa@agava.com

>Number:         99786
>Category:       ports
>Synopsis:       cups-base OPTIONS don't work and 1.2.1 has been released
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    itetcu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 04 16:40:15 GMT 2006
>Closed-Date:    Sun Aug 06 09:16:57 GMT 2006
>Last-Modified:  Sun Aug 06 09:16:57 GMT 2006
>Originator:     Harald Schmalzbauer
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD tek.flintsbach.schmalzbauer.de 6.1-STABLE FreeBSD 6.1-STABLE #0: Fri Jun 16 15:40:20 CEST 2006 compilator@cale.flintsbach.schmalzbauer.de:/usr/obj/FlashBSD/i686/usr/src/sys/i686.intern-tek i386


	
>Description:
	Defining OPTIONS with make config has no effect since bsd.port.pre.mki
	is not .included.
	At the end of May cups 1.2.1 appeard as bugfix release
>How-To-Repeat:
	Change the default OPTIONS during regular "make" and see that there's no
        configure difference, also no libpaper dependency even if selected
>Fix:

Note that I also changed the default OPTIONS, I personally prerfere that one.
Please review!

--- print/cups-base/Makefile.old        Tue Jul  4 18:25:44 2006
+++ print/cups-base/Makefile    Tue Jul  4 18:27:01 2006
@@ -6,8 +6,7 @@
 #

 PORTNAME=      cups-base
-PORTVERSION=   1.2.0
-PORTREVISION=  2
+PORTVERSION=   1.2.1
 CATEGORIES=    print
 MASTER_SITES=  ftp://ftp.funet.fi/pub/mirrors/ftp.easysw.com/pub/cups/${PORTVERSION}/ \
                ftp://ftp.ntua.gr/pub/gnu/cups/${PORTVERSION}/ \
@@ -19,6 +18,7 @@
 MAINTAINER=    asa@agava.com
 COMMENT=       The Common UNIX Printing System

+
 INSTALLS_SHLIB=        yes
@@ -28,10 +28,12 @@
 CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
-OPTIONS=       GNUTLS          "Build with GNUTLS library" on \
+OPTIONS=       GNUTLS          "Build with GNUTLS library" off \
                PHP             "Build PHP support" off \
                PYTHON          "Build PYTHON support" off \
-               LIBPAPER        "Build with libpaper support" off
+               LIBPAPER        "Build with libpaper support" on
+
+.include <bsd.port.pre.mk>

 CUPS_FILESDIR= ${.CURDIR}/../../print/cups/files
 CUPS_ETCDIR=   ${PREFIX}/etc/cups
@@ -62,7 +64,7 @@
                        --with-rcdir=${CUPS_RCDIR}              \
                        --with-domainsocket=${CUPS_SOCKET}

-.if !defined(WITHOUT_GNUTLS)
+.if defined(WITH_GNUTLS)
 CONFIGURE_ARGS+=       --enable-gnutls --disable-openssl
 LIB_DEPENDS+=          gnutls-openssl.15:${PORTSDIR}/security/gnutls
 .endif
@@ -162,4 +164,4 @@
        ${CHMOD} -R g+w ${CUPS_SPOOLDIR}
        @${SED} -e 's#PREFIX#${PREFIX}#' ${PKGMESSAGE}

@@ -1,3 +1,3 @@
-SIZE (cups-1.2.0-source.tar.bz2) = 3456476
+SIZE (cups-1.2.1-source.tar.bz2) = 3475342
--- print/cups-base/files/patch-Makefile.old    Tue Jul  4 18:26:15 2006
+++ print/cups-base/files/patch-Makefile        Tue Jul  4 17:46:14 2006
@@ -1,11 +1,11 @@
---- Makefile.orig      Thu May 18 13:38:50 2006
-+++ Makefile   Thu May 18 13:40:07 2006
-@@ -99,56 +99,11 @@
+--- Makefile.orig      Tue Jul  4 17:43:24 2006
++++ Makefile   Tue Jul  4 17:45:14 2006
+@@ -99,57 +99,10 @@
        echo Installing cups-config script...
        $(INSTALL_DIR) -m 755 $(BINDIR)
        $(INSTALL_SCRIPT) cups-config $(BINDIR)/cups-config
--      echo Installing startup script...
 -              $(INSTALL_DIR) -m 755 $(BUILDROOT)$(INITDIR)/init.d; \
@@ -20,13 +20,16 @@
 -      if test "x$(INITDIR)" = x -a "x$(INITDDIR)" != x; then \
 -              $(INSTALL_DIR) $(BUILDROOT)$(INITDDIR); \
 -              if test "$(INITDDIR)" = "/System/Library/StartupItems/PrintingServices"; then \
+-                      echo Installing StartupItems files...; \
 -                      $(INSTALL_DATA) init/StartupParameters.plist $(BUILDROOT)$(INITDDIR)/StartupParameters.plist; \
 -                      $(INSTALL_DIR) -m 755 $(BUILDROOT)$(INITDDIR)/Resources/English.lproj; \
 -                      $(INSTALL_DATA) init/Localizable.strings $(BUILDROOT)$(INITDDIR)/Resources/English.lproj/Localizable.strings; \
 -              elif test "$(INITDDIR)" = "/System/Library/LaunchDaemons"; then \
+-                      echo Installing LaunchDaemons configuration file...; \
 -                      $(INSTALL_DATA) init/org.cups.cupsd.plist $(BUILDROOT)$(DEFAULT_LAUNCHD_CONF); \
 -              else \
+-                      echo Installing RC script...; \
 -                      $(INSTALL_SCRIPT) init/cups.sh $(BUILDROOT)$(INITDDIR)/cups; \
 -              fi \
 -      fi
@@ -34,7 +37,7 @@
                echo Installing cups.conf in $(DBUSDIR)...;\
                $(INSTALL_DIR) -m 755 $(BUILDROOT)$(DBUSDIR); \
                $(INSTALL_DATA) packaging/cups-dbus.conf $(BUILDROOT)$(DBUSDIR)/cups.conf; \
-       fi
+-      fi
 -      if test "x$(XINETD)" != x; then \
 -              echo Installing xinetd configuration file for cups-lpd...; \
 -              $(INSTALL_DIR) -m 755 $(BUILDROOT)$(XINETD); \
@@ -52,8 +55,6 @@
 -              $(INSTALL_DATA) desktop/cups-64.png $(BUILDROOT)/usr/share/icons/hicolor/64x64/apps/cups.png; \
 -              $(INSTALL_DIR) -m 755 $(BUILDROOT)/usr/share/icons/hicolor/128x128/apps; \
 -              $(INSTALL_DATA) desktop/cups-128.png $(BUILDROOT)/usr/share/icons/hicolor/128x128/apps/cups.png; \
--      fi
--
+       fi
+

- #
- # Install source and header files...

>Release-Note:
>Audit-Trail:

From: Harald Schmalzbauer <harry@schmalzbauer.de>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org
Cc:  
Subject: Re: ports/99786: cups-base OPTIONS don't work and 1.2.1 has been released
Date: Tue, 4 Jul 2006 18:55:56 +0200

 --Boundary-00=_c2pqEHviQFDiBS7
 Content-Type: text/plain;
   charset="iso-8859-15"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Am Dienstag, 4. Juli 2006 18:40 schrieb FreeBSD-gnats-submit@freebsd.org:
 > Thank you very much for your problem report.
 > It has the internal identification `ports/99786'.
 > The individual assigned to look at your
 > report is: freebsd-ports-bugs.
 >
 > You can access the state of your problem report at any time
 > via this link:
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=99786
 
 There were problems with the pasted patch.
 Please find it attached.
 
 
 >
 > >Category:       ports
 > >Responsible:    freebsd-ports-bugs
 > >Synopsis:       cups-base OPTIONS don't work and 1.2.1 has been released
 > >Arrival-Date:   Tue Jul 04 16:40:15 GMT 2006
 
 --Boundary-00=_c2pqEHviQFDiBS7
 Content-Type: text/x-diff;
   charset="iso-8859-15";
   name="cups-base.upgrade"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename="cups-base.upgrade"
 
 --- print/cups-base/Makefile.old	Tue Jul  4 18:25:44 2006
 +++ print/cups-base/Makefile	Tue Jul  4 18:27:01 2006
 @@ -6,8 +6,7 @@
  #
  
  PORTNAME=	cups-base
 -PORTVERSION=	1.2.0
 -PORTREVISION=	2
 +PORTVERSION=	1.2.1
  CATEGORIES=	print
  MASTER_SITES=	ftp://ftp.funet.fi/pub/mirrors/ftp.easysw.com/pub/cups/${PORTVERSION}/ \
  		ftp://ftp.ntua.gr/pub/gnu/cups/${PORTVERSION}/ \
 @@ -19,6 +18,7 @@
  MAINTAINER=	asa@agava.com
  COMMENT=	The Common UNIX Printing System
  
 +
  INSTALLS_SHLIB=	yes
  USE_BZIP2=	yes
  USE_GMAKE=	yes
 @@ -28,10 +28,12 @@
  CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
  		LDFLAGS="-L${LOCALBASE}/lib"
  
 -OPTIONS=	GNUTLS		"Build with GNUTLS library" on \
 +OPTIONS=	GNUTLS		"Build with GNUTLS library" off \
  		PHP		"Build PHP support" off \
  		PYTHON		"Build PYTHON support" off \
 -		LIBPAPER	"Build with libpaper support" off
 +		LIBPAPER	"Build with libpaper support" on
 +
 +.include <bsd.port.pre.mk>
  
  CUPS_FILESDIR=	${.CURDIR}/../../print/cups/files
  CUPS_ETCDIR=	${PREFIX}/etc/cups
 @@ -62,7 +64,7 @@
  			--with-rcdir=${CUPS_RCDIR}		\
  			--with-domainsocket=${CUPS_SOCKET}
  
 -.if !defined(WITHOUT_GNUTLS)
 +.if defined(WITH_GNUTLS)
  CONFIGURE_ARGS+=	--enable-gnutls --disable-openssl
  LIB_DEPENDS+=		gnutls-openssl.15:${PORTSDIR}/security/gnutls
  .endif
 @@ -162,4 +164,4 @@
  	${CHMOD} -R g+w ${CUPS_SPOOLDIR}
  	@${SED} -e 's#PREFIX#${PREFIX}#' ${PKGMESSAGE}
  
 -.include <bsd.port.mk>
 +.include <bsd.port.post.mk>
 --- print/cups-base/distinfo.old	Tue Jul  4 18:26:01 2006
 +++ print/cups-base/distinfo	Tue Jul  4 17:19:02 2006
 @@ -1,3 +1,3 @@
 -MD5 (cups-1.2.0-source.tar.bz2) = a168b0b1c8bb946060e659e1df2927c5
 -SHA256 (cups-1.2.0-source.tar.bz2) = 893a91d96e68de51f767d97d36d2d321320b3611b7178ea9a9d17ad2777f5f9f
 -SIZE (cups-1.2.0-source.tar.bz2) = 3456476
 +MD5 (cups-1.2.1-source.tar.bz2) = f804995e3f469bdefedc033510f6e6a5
 +SHA256 (cups-1.2.1-source.tar.bz2) = 10fb273b8118858fdce795608065860865432b2d9f1016b53fff1eb340385e45
 +SIZE (cups-1.2.1-source.tar.bz2) = 3475342
 --- print/cups-base/files/patch-Makefile.old	Tue Jul  4 18:26:15 2006
 +++ print/cups-base/files/patch-Makefile	Tue Jul  4 17:46:14 2006
 @@ -1,11 +1,11 @@
 ---- Makefile.orig	Thu May 18 13:38:50 2006
 -+++ Makefile	Thu May 18 13:40:07 2006
 -@@ -99,56 +99,11 @@
 +--- Makefile.orig	Tue Jul  4 17:43:24 2006
 ++++ Makefile	Tue Jul  4 17:45:14 2006
 +@@ -99,57 +99,10 @@
   	echo Installing cups-config script...
   	$(INSTALL_DIR) -m 755 $(BINDIR)
   	$(INSTALL_SCRIPT) cups-config $(BINDIR)/cups-config
 --	echo Installing startup script...
  -	if test "x$(INITDIR)" != x; then \
 +-		echo Installing init scripts...; \
  -		$(INSTALL_DIR) -m 755 $(BUILDROOT)$(INITDIR)/init.d; \
  -		$(INSTALL_SCRIPT) init/cups.sh $(BUILDROOT)$(INITDIR)/init.d/cups; \
  -		$(INSTALL_DIR) -m 755 $(BUILDROOT)$(INITDIR)/rc0.d; \
 @@ -20,13 +20,16 @@
  -	if test "x$(INITDIR)" = x -a "x$(INITDDIR)" != x; then \
  -		$(INSTALL_DIR) $(BUILDROOT)$(INITDDIR); \
  -		if test "$(INITDDIR)" = "/System/Library/StartupItems/PrintingServices"; then \
 +-			echo Installing StartupItems files...; \
  -			$(INSTALL_SCRIPT) init/PrintingServices $(BUILDROOT)$(INITDDIR)/PrintingServices; \
  -			$(INSTALL_DATA) init/StartupParameters.plist $(BUILDROOT)$(INITDDIR)/StartupParameters.plist; \
  -			$(INSTALL_DIR) -m 755 $(BUILDROOT)$(INITDDIR)/Resources/English.lproj; \
  -			$(INSTALL_DATA) init/Localizable.strings $(BUILDROOT)$(INITDDIR)/Resources/English.lproj/Localizable.strings; \
  -		elif test "$(INITDDIR)" = "/System/Library/LaunchDaemons"; then \
 +-			echo Installing LaunchDaemons configuration file...; \
  -			$(INSTALL_DATA) init/org.cups.cupsd.plist $(BUILDROOT)$(DEFAULT_LAUNCHD_CONF); \
  -		else \
 +-			echo Installing RC script...; \
  -			$(INSTALL_SCRIPT) init/cups.sh $(BUILDROOT)$(INITDDIR)/cups; \
  -		fi \
  -	fi
 @@ -34,7 +37,7 @@
   		echo Installing cups.conf in $(DBUSDIR)...;\
   		$(INSTALL_DIR) -m 755 $(BUILDROOT)$(DBUSDIR); \
   		$(INSTALL_DATA) packaging/cups-dbus.conf $(BUILDROOT)$(DBUSDIR)/cups.conf; \
 - 	fi
 +-	fi
  -	if test "x$(XINETD)" != x; then \
  -		echo Installing xinetd configuration file for cups-lpd...; \
  -		$(INSTALL_DIR) -m 755 $(BUILDROOT)$(XINETD); \
 @@ -52,8 +55,6 @@
  -		$(INSTALL_DATA) desktop/cups-64.png $(BUILDROOT)/usr/share/icons/hicolor/64x64/apps/cups.png; \
  -		$(INSTALL_DIR) -m 755 $(BUILDROOT)/usr/share/icons/hicolor/128x128/apps; \
  -		$(INSTALL_DATA) desktop/cups-128.png $(BUILDROOT)/usr/share/icons/hicolor/128x128/apps/cups.png; \
 --	fi
 --
 + 	fi
 + 
   
 - #
 - # Install source and header files...
 
 --Boundary-00=_c2pqEHviQFDiBS7--
Responsible-Changed-From-To: freebsd-ports-bugs->itetcu 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Jul 4 22:45:49 UTC 2006 
Responsible-Changed-Why:  
itetcu@ wants to have OPTIONS PRs 

http://www.freebsd.org/cgi/query-pr.cgi?pr=99786 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Jul 4 22:45:55 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=99786 
State-Changed-From-To: feedback->patched 
State-Changed-By: itetcu 
State-Changed-When: Fri Jul 7 20:27:42 UTC 2006 
State-Changed-Why:  
Should be fixed by patch in ports/99624 

http://www.freebsd.org/cgi/query-pr.cgi?pr=99786 
State-Changed-From-To: patched->closed 
State-Changed-By: itetcu 
State-Changed-When: Sun Aug 6 09:16:55 UTC 2006 
State-Changed-Why:  
Update to 1.2.2 and many fixes commiter. If problems perssist please 
open a new PR. Thanks for your effort. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=99786 
>Unformatted:
