From never@kurush.osdn.org.ua  Thu Jun 15 20:53:28 2006
Return-Path: <never@kurush.osdn.org.ua>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B984816A479
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Jun 2006 20:53:28 +0000 (UTC)
	(envelope-from never@kurush.osdn.org.ua)
Received: from kurush.osdn.org.ua (external.osdn.org.ua [212.40.34.156])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1C24343D46
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Jun 2006 20:53:27 +0000 (GMT)
	(envelope-from never@kurush.osdn.org.ua)
Received: from kurush.osdn.org.ua (never@localhost [127.0.0.1])
	by kurush.osdn.org.ua (8.12.11/8.12.11) with ESMTP id k5FKpk0I067552
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Jun 2006 23:53:26 +0300 (EEST)
	(envelope-from never@kurush.osdn.org.ua)
Received: (from never@localhost)
	by kurush.osdn.org.ua (8.12.11/8.12.11/Submit) id k5FKpkMR067548;
	Thu, 15 Jun 2006 23:51:46 +0300 (EEST)
	(envelope-from never)
Message-Id: <200606152051.k5FKpkMR067548@kurush.osdn.org.ua>
Date: Thu, 15 Jun 2006 23:51:46 +0300 (EEST)
From: Alexandr Kovalenko <never@nevermind.kiev.ua>
Reply-To: Alexandr Kovalenko <never@nevermind.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER PATCH] finance/p5-Business-OnlinePayment-PayflowPro: fix default ceritificates path
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         98990
>Category:       ports
>Synopsis:       [MAINTAINER PATCH] finance/p5-Business-OnlinePayment-PayflowPro: fix default ceritificates path
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 15 21:00:38 GMT 2006
>Closed-Date:    Thu Jun 15 21:30:56 GMT 2006
>Last-Modified:  Thu Jun 15 21:30:56 GMT 2006
>Originator:     Alexandr Kovalenko
>Release:        FreeBSD 6.1-RELEASE-p1 i386
>Organization:
PortaOne, Inc., http://portaone.com/
>Environment:
System: FreeBSD mile.zukabuka.com 6.1-RELEASE-p1 FreeBSD 6.1-RELEASE-p1 #0: Mon Jun 12 19:58:45 EEST 2006     root@mile.zukabuka.com:/usr/obj/usr/src/sys/mile  i386
>Description:
	Module didn't handle situation where cert_path was not set. Add code to
	make certificates path /usr/local/certs (as it is in finance/pfpro).
>How-To-Repeat:
	Look at code :)
>Fix:

--- finance/p5-Business-OnlinePayment-PayflowPro/files/patch-PayflowPro.pm.orig	Thu Jun 15 04:07:32 2006
+++ finance/p5-Business-OnlinePayment-PayflowPro/files/patch-PayflowPro.pm	Thu Jun 15 23:45:38 2006
@@ -1,5 +1,5 @@
---- PayflowPro.pm.orig	Tue Jun 13 01:30:27 2006
-+++ PayflowPro.pm	Tue Jun 13 01:30:41 2006
+--- PayflowPro.pm.orig	Thu Jun 15 23:38:47 2006
++++ PayflowPro.pm	Thu Jun 15 23:44:55 2006
 @@ -14,7 +14,7 @@
  @ISA = qw(Exporter AutoLoader Business::OnlinePayment);
  @EXPORT = qw();
@@ -9,3 +9,13 @@
  
  sub set_defaults {
      my $self = shift;
+@@ -186,6 +186,9 @@
+     #print "$_ => $params{$_}\n" foreach keys %params;
+ 
+     $ENV{'PFPRO_CERT_PATH'} = $self->cert_path;
++    if ($ENV{'PFPRO_CERT_PATH'} eq '') {
++      $ENV{'PFPRO_CERT_PATH'} = '/usr/local/certs';
++    };
+     my( $response, $resultstr ) = pfpro( \%params, $self->server, $self->port );
+ 
+     #if ( $response->{'RESULT'} == 0 ) {
>Release-Note:
>Audit-Trail:

From: Alexandr Kovalenko <never@nevermind.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: Re: ports/98990: [MAINTAINER PATCH] finance/p5-Business-OnlinePayment-PayflowPro: fix default ceritificates path
Date: Fri, 16 Jun 2006 00:11:25 +0300

 Hello, Alexandr Kovalenko!
 
 On Thu, Jun 15, 2006 at 11:51:46PM +0300, you wrote:
 
 > 
 > >Number:         98990
 > >Category:       ports
 > >Synopsis:       [MAINTAINER PATCH] finance/p5-Business-OnlinePayment-PayflowPro: fix default ceritificates path
 
 Sorry, too early sent PR, please close, I'll submit a new one, when it
 will be ready.
 
 > >Confidential:   no
 > >Severity:       serious
 > >Priority:       medium
 > >Responsible:    freebsd-ports-bugs
 > >State:          closed
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          maintainer-update
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Thu Jun 15 21:00:38 GMT 2006
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Alexandr Kovalenko
 > >Release:        FreeBSD 6.1-RELEASE-p1 i386
 > >Organization:
 > PortaOne, Inc., http://portaone.com/
 > >Environment:
 > System: FreeBSD mile.zukabuka.com 6.1-RELEASE-p1 FreeBSD 6.1-RELEASE-p1 #0: Mon Jun 12 19:58:45 EEST 2006     root@mile.zukabuka.com:/usr/obj/usr/src/sys/mile  i386
 > >Description:
 > 	Module didn't handle situation where cert_path was not set. Add code to
 > 	make certificates path /usr/local/certs (as it is in finance/pfpro).
 > >How-To-Repeat:
 > 	Look at code :)
 > >Fix:
 > 
 > --- finance/p5-Business-OnlinePayment-PayflowPro/files/patch-PayflowPro.pm.orig	Thu Jun 15 04:07:32 2006
 > +++ finance/p5-Business-OnlinePayment-PayflowPro/files/patch-PayflowPro.pm	Thu Jun 15 23:45:38 2006
 > @@ -1,5 +1,5 @@
 > ---- PayflowPro.pm.orig	Tue Jun 13 01:30:27 2006
 > -+++ PayflowPro.pm	Tue Jun 13 01:30:41 2006
 > +--- PayflowPro.pm.orig	Thu Jun 15 23:38:47 2006
 > ++++ PayflowPro.pm	Thu Jun 15 23:44:55 2006
 >  @@ -14,7 +14,7 @@
 >   @ISA = qw(Exporter AutoLoader Business::OnlinePayment);
 >   @EXPORT = qw();
 > @@ -9,3 +9,13 @@
 >   
 >   sub set_defaults {
 >       my $self = shift;
 > +@@ -186,6 +186,9 @@
 > +     #print "$_ => $params{$_}\n" foreach keys %params;
 > + 
 > +     $ENV{'PFPRO_CERT_PATH'} = $self->cert_path;
 > ++    if ($ENV{'PFPRO_CERT_PATH'} eq '') {
 > ++      $ENV{'PFPRO_CERT_PATH'} = '/usr/local/certs';
 > ++    };
 > +     my( $response, $resultstr ) = pfpro( \%params, $self->server, $self->port );
 > + 
 > +     #if ( $response->{'RESULT'} == 0 ) {
 > >Release-Note:
 > >Audit-Trail:
 > >Unformatted:
 > _______________________________________________
 > freebsd-ports-bugs@freebsd.org mailing list
 > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
 > To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
 
 -- 
 NEVE-RIPE, will build world for food
 Ukrainian FreeBSD User Group
 http://uafug.org.ua/
State-Changed-From-To: open->closed 
State-Changed-By: erwin 
State-Changed-When: Thu Jun 15 21:30:46 UTC 2006 
State-Changed-Why:  
Closed at submitters request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98990 
>Unformatted:
