From vanhu@zeninc.net  Wed Jun 14 12:28:59 2006
Return-Path: <vanhu@zeninc.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A48E816A47B
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Jun 2006 12:28:59 +0000 (UTC)
	(envelope-from vanhu@zeninc.net)
Received: from leia.fdn.fr (ns0.fdn.org [80.67.169.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0DBFA43D72
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Jun 2006 12:28:56 +0000 (GMT)
	(envelope-from vanhu@zeninc.net)
Received: from smtp.zeninc.net (reverse-25.fdn.fr [80.67.176.25])
	by leia.fdn.fr (8.13.3/8.13.3/FDN) with ESMTP id k5ECSsUS016464
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Jun 2006 14:28:55 +0200
Received: from jayce.zen.inc (jayce.zen.inc [192.168.1.7])
	by smtp.zeninc.net (smtpd) with ESMTP id 59C213F17
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Jun 2006 14:28:49 +0200 (CEST)
Received: by jayce.zen.inc (Postfix, from userid 1000)
	id A415F2E587; Wed, 14 Jun 2006 14:28:50 +0200 (CEST)
Message-Id: <20060614122850.A415F2E587@jayce.zen.inc>
Date: Wed, 14 Jun 2006 14:28:50 +0200 (CEST)
From: VANHULLEBUS Yvan <vanhu@zeninc.net>
Reply-To: VANHULLEBUS Yvan <vanhu@zeninc.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] xscreensaver and PAM support
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         98946
>Category:       ports
>Synopsis:       [patch] xscreensaver and PAM support
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 14 12:30:27 GMT 2006
>Closed-Date:    Tue Dec 11 17:23:18 UTC 2007
>Last-Modified:  Tue Dec 11 17:23:18 UTC 2007
>Originator:     VANHULLEBUS Yvan
>Release:        FreeBSD 6.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD jayce.zen.inc 6.1-RELEASE FreeBSD 6.1-RELEASE #0: Sun May 7 04:32:43 UTC 2006 root@opus.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386


>Description:
Actually, xscreensaver compiles with --without-pam.
For hosts with "PAM users" (NIS, LDAP, etc...), this will cause problems when
locking X session with xscreensaver.

>How-To-Repeat:
Set up a host with NIS / LDAP users, configure PAM, and try to use xscreensaver
with such an user.

>Fix:
The following patch allows to compile with PAM support. It is disabled by default as
some (old) mails reported problems with PAM support compiled when not using PAM.

Please note that actually, /etc/pam.d/xscreensaver will still need to be copied
manually, as there is a patch hook in the port to avoid copying it during install.

--- Makefile.orig	Wed Jun 14 11:29:28 2006
+++ Makefile	Wed Jun 14 11:31:21 2006
@@ -7,6 +7,7 @@
 
 PORTNAME=	xscreensaver
 PORTVERSION=	5.00
+PORTREVISION=	1
 CATEGORIES?=	x11
 MASTER_SITES=	http://www.jwz.org/xscreensaver/ \
 		http://dougbarton.us/Downloads/
@@ -24,14 +25,15 @@
 USE_GL=		yes
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--without-pam --with-gl --with-gle --with-xpm --with-xml \
+CONFIGURE_ARGS=	--with-gl --with-gle --with-xpm --with-xml \
 		--with-hackdir=${PREFIX}/bin/xscreensaver-hacks/ \
 		--with-configdir=${PREFIX}/share/xscreensaver/config/ \
 		--with-jpeg=${LOCALBASE} --without-gnome --without-kerberos \
 		--without-motif --mandir=${PREFIX}/man
 
 OPTIONS=	ALL_FORTUNES "Run fortune with -sa argument" off \
-		SETUID_HACKS "Install sonar hack suid so it can ping" off
+		SETUID_HACKS "Install sonar hack suid so it can ping" off\
+		WITH_PAM "Compiles with PAM support" off
 
 .include <bsd.port.pre.mk>
 
@@ -40,6 +42,9 @@
 .endif
 .if defined(WITH_SETUID_HACKS)
 CONFIGURE_ARGS+=	--with-setuid-hacks
+.endif
+.if !defined(WITH_PAM)
+CONFIGURE_ARGS+=	--without-pam
 .endif
 
 .undef HAVE_GNOME

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dougb 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Jun 14 12:32:42 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98946 

From: VANHULLEBUS Yvan <vanhu_bsd@zeninc.net>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re:  ports/98946: [patch] xscreensaver and PAM support
Date: Fri, 19 Jan 2007 14:19:41 +0100

 Hi. I had no news for this pr since months, and my last update
 confirms the problem is still here.
 
 Could someone have a look at my patch, and commit it, as it doesn't
 change default installation, but just lets people who wants PAM
 support simply have it, even when updating the port ?
 
 
 Thanks,
 
 Yvan.
 
 On Wed, Jun 14, 2006 at 12:30:27PM +0000, FreeBSD-gnats-submit@FreeBSD.org wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `ports/98946'.
 > The individual assigned to look at your
 > report is: freebsd-ports-bugs. 
 > 
 > You can access the state of your problem report at any time
 > via this link:
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=98946
 > 
 > >Category:       ports
 > >Responsible:    freebsd-ports-bugs
 > >Synopsis:       [patch] xscreensaver and PAM support
 > >Arrival-Date:   Wed Jun 14 12:30:27 GMT 2006

From: Doug Barton <dougb@FreeBSD.org>
To: VANHULLEBUS Yvan <vanhu_bsd@zeninc.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/98946: [patch] xscreensaver and PAM support
Date: Fri, 19 Jan 2007 12:22:58 -0800

 VANHULLEBUS Yvan wrote:
 > The following reply was made to PR ports/98946; it has been noted by GNATS.
 > 
 > From: VANHULLEBUS Yvan <vanhu_bsd@zeninc.net>
 > To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
 > Cc:  
 > Subject: Re:  ports/98946: [patch] xscreensaver and PAM support
 > Date: Fri, 19 Jan 2007 14:19:41 +0100
 > 
 >  Hi. I had no news for this pr since months, and my last update
 >  confirms the problem is still here.
 >  
 >  Could someone have a look at my patch, and commit it, as it doesn't
 >  change default installation, but just lets people who wants PAM
 >  support simply have it, even when updating the port ?
 
 Actually I have looked at this, and it's not as simple as you suggest
 because one of the patches will have to be made conditional. It's
 still on my list to fix this, but it got pushed down below some other
 stuff (both for FreeBSD and real life). Now that the release is over,
 and things are closer to normal, I'll give this some attention.
 
 
 Regards,
 
 Doug
 
 -- 
 
     This .signature sanitized for your protection
State-Changed-From-To: open->feedback 
State-Changed-By: dougb 
State-Changed-When: Sat Dec 8 07:09:14 UTC 2007 
State-Changed-Why:  

Please try the patch at 
http://dougbarton.us/Downloads/xs-504-pam-kerberos.diff 
and let me know how it goes. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98946 

From: Doug Barton <dougb@FreeBSD.org>
To: bug-followup@FreeBSD.org, vanhu@zeninc.net, 
 freebsd-ports@freebsd.org
Cc:  
Subject: Re: ports/98946: [patch] xscreensaver and PAM/kerberos support
Date: Fri, 07 Dec 2007 23:08:48 -0800

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: RIPEMD160
 
 If you're interested in xscreensaver support for pam and/or kerberos,
 please take a look at
 http://dougbarton.us/Downloads/xs-504-pam-kerberos.diff. You should
 apply the patch with the --remove-empty-files option.
 
 If I don't hear of any problems by the time the freeze is over, I plan
 to commit this update.
 
 Doug
 
 - --
 
     This .signature sanitized for your protection
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.7 (FreeBSD)
 
 iD8DBQFHWkMAyIakK9Wy8PsRA2KsAKCc55EdulCMJX/ug8DuYGhZWdzujgCfWWOb
 O2DMYTwimk07A2gyARsZcEY=
 =uMLc
 -----END PGP SIGNATURE-----

From: VANHULLEBUS Yvan <vanhu_bsd@zeninc.net>
To: Doug Barton <dougb@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, freebsd-ports@freebsd.org
Subject: Re:  ports/98946: [patch] xscreensaver and PAM/kerberos support
Date: Tue, 11 Dec 2007 17:07:06 +0100

 Hi.
 
 On Fri, Dec 07, 2007 at 11:08:48PM -0800, Doug Barton wrote:
 > -----BEGIN PGP SIGNED MESSAGE-----
 > Hash: RIPEMD160
 > 
 > If you're interested in xscreensaver support for pam and/or kerberos,
 > please take a look at
 > http://dougbarton.us/Downloads/xs-504-pam-kerberos.diff. You should
 > apply the patch with the --remove-empty-files option.
 > 
 > If I don't hear of any problems by the time the freeze is over, I plan
 > to commit this update.
 
 A part of the patch does the same thing I proposed in ports/98946:
 adding a PAM option to allow enabling PAM support.
 
 I don't have actually any working FreeBSD + X server + "PAM users" so
 I can't test it, but it was already working when I submitted
 ports/98946.
 
 I can't talk for other parts of the patch, as I never used kerberos
 support in such context, and as I didn't have a closer look to misc
 patches.
 
 
 
 Yvan.
 
 -- 
 NETASQ
 http://www.netasq.com
State-Changed-From-To: feedback->closed 
State-Changed-By: dougb 
State-Changed-When: Tue Dec 11 17:22:40 UTC 2007 
State-Changed-Why:  

Originator reports he no longer has a relevant configuration. 

I plan to commit the patch after the freeze in any case. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98946 
>Unformatted:
