From nobody@FreeBSD.org  Thu Jun  8 18:38:36 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4D7F816D56F
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Jun 2006 16:35:28 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3E36543D73
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Jun 2006 16:35:23 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k58GZMKg020445
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 8 Jun 2006 16:35:22 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k58GZMQV020444;
	Thu, 8 Jun 2006 16:35:22 GMT
	(envelope-from nobody)
Message-Id: <200606081635.k58GZMQV020444@www.freebsd.org>
Date: Thu, 8 Jun 2006 16:35:22 GMT
From: Kirk Strauser <kirk@daycos.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Added "WITH_SENDFILE" configuration knob to ftp/pure-ftpd port
X-Send-Pr-Version: www-2.3

>Number:         98715
>Category:       ports
>Synopsis:       [PATCH] Added "WITH_SENDFILE" configuration knob to ftp/pure-ftpd port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 08 18:40:15 GMT 2006
>Closed-Date:    Fri Jun 09 19:04:13 GMT 2006
>Last-Modified:  Fri Jun 09 19:04:13 GMT 2006
>Originator:     Kirk Strauser
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
The Day Companies
>Environment:
FreeBSD web2.daycos.com 6.1-STABLE FreeBSD 6.1-STABLE #0: Sun May 21 11:50:41 CDT 2006 kirk@jail1.daycos.com:/usr/obj/usr/src/sys/JAIL1 i386
>Description:
Pure-FTPd uses the sendfile(2) syscall to transmit files by default.  There
are currently some issues with sendfile and smbfs, with the end result that
users can't download files that reside on SMB mounts.  Pure-FTPd includes
a "--without-sendfile" configuration option as a workaround, and this patch
adds convenient support for that option to the port.

>How-To-Repeat:

>Fix:
--- pure-ftpd.patch begins here ---
diff -urN pure-ftpd-old/Makefile pure-ftpd/Makefile
--- pure-ftpd-old/Makefile      Wed May 17 05:16:05 2006
+++ pure-ftpd/Makefile  Thu Jun  8 11:19:56 2006
@@ -47,7 +47,8 @@
                THROTTLING      "Bandwidth throttling" off \
                BANNER  "Show ${PORTNAME} welcome upon session start" on \
                UPLOADSCRIPT "Support uploadscript daemon" off \
-               UTF8    "Support for charset conversion (expreimental)" off
+               UTF8    "Support for charset conversion (expreimental)" off \
+               SENDFILE        "Support for the sendfile syscall" on

 .include <bsd.port.pre.mk>

@@ -113,6 +114,12 @@
 .if defined(WITH_UTF8)
 USE_ICONV=     YES
 CONFIGURE_ARGS+=       --with-rfc2640
+.endif
+
+.if defined(WITH_SENDFILE)
+CONFIGURE_ARGS+=       --with-sendfile
+.else
+CONFIGURE_ARGS+=       --without-sendfile
 .endif

 .if ${OSVERSION} > 500000
--- pure-ftpd.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jun 8 22:32:14 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98715 

From: Frank Denis <j@pureftpd.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/98715: Added "WITH_SENDFILE" configuration knob to ftp/pure-ftpd port
Date: Fri, 9 Jun 2006 01:05:38 +0200

 Le Thu, Jun 08, 2006 at 10:32:09PM +0000, Edwin Groothuis ecrivait :
 >The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/98715
 
   Ok, why not :)
   
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Fri Jun 9 02:44:37 UTC 2006 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98715 
State-Changed-From-To: open->closed 
State-Changed-By: delphij 
State-Changed-When: Fri Jun 9 19:03:45 UTC 2006 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-ports-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Fri Jun 9 19:03:45 UTC 2006 
Responsible-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98715 
>Unformatted:
