From nobody@FreeBSD.org  Thu Jun  1 15:47:31 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1F64016B497
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  1 Jun 2006 15:47:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 562DB43D69
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  1 Jun 2006 15:47:24 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k51FlNHv082030
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 1 Jun 2006 15:47:23 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k51FlN4w082029;
	Thu, 1 Jun 2006 15:47:23 GMT
	(envelope-from nobody)
Message-Id: <200606011547.k51FlN4w082029@www.freebsd.org>
Date: Thu, 1 Jun 2006 15:47:23 GMT
From: Pavel Volkov <pol@iib.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: In port ports/sysutils/syslog-ng it is impossible to change parameters of start syslog-ng.
X-Send-Pr-Version: www-2.3

>Number:         98287
>Category:       ports
>Synopsis:       In port ports/sysutils/syslog-ng it is impossible to change parameters of start syslog-ng.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 01 15:50:11 GMT 2006
>Closed-Date:    Mon Mar 19 06:28:25 GMT 2007
>Last-Modified:  Mon Mar 19 06:30:05 GMT 2007
>Originator:     Pavel Volkov
>Release:        5.4-RELEASE-p6
>Organization:
IIB
>Environment:
FreeBSD test.internal.net 5.4-RELEASE-p6 FreeBSD 5.4-RELEASE-p6 #2: Sat Sep  3 10:18:33 MSD 2005     root@test.internal.net:/usr/obj/usr/src/sys/SMP  i386
>Description:
In port ports/sysutils/syslog-ng it is impossible to change parameters of start syslog-ng.
>How-To-Repeat:

>Fix:
--- files/syslog-ng.sh.in.orig  Thu Jun  1 17:20:04 2006
+++ files/syslog-ng.sh.in       Thu Jun  1 17:52:22 2006
@@ -12,6 +12,8 @@
 # to enable this service:
 #
 #syslog_ng_enable="YES"
+#syslog_ng_config="-u daemon"
+#syslog_ng_pid="/var/run/syslog-ng.pid"
 #

 . %%RC_SUBR%%
@@ -21,13 +23,14 @@

 command=%%PREFIX%%/sbin/syslog-ng
 required_files=%%PREFIX%%/etc/syslog-ng/syslog-ng.conf
-pidfile=/var/run/syslog.pid
 extra_commands=reload
 stop_postcmd=stop_postcmd

 load_rc_config $name

 : ${syslog_ng_enable:="NO"}
+pidfile=${syslog_ng_pid:-"/var/run/syslog.pid"}
+command_args="-p ${pidfile} ${syslog_ng_config}"

 stop_postcmd() {
   rm -f $pidfile

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jun 1 15:52:38 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98287 

From: "Vince Valenti" <vince@blue-box.net>
To: <bug-followup@FreeBSD.org>
Cc:  
Subject: RE: ports/98287: In port ports/sysutils/syslog-ng it is impossible to change parameters of start syslog-ng.
Date: Wed, 14 Jun 2006 20:55:01 -0700

 Edwin, sorry for the delay here...  Please go ahead and commit.
 
 Thanks,
 
 -Vince
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Thu Jun 15 04:33:29 UTC 2006 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98287 
Responsible-Changed-From-To: freebsd-ports-bugs->itetcu 
Responsible-Changed-By: itetcu 
Responsible-Changed-When: Sat Jun 17 23:02:33 UTC 2006 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98287 
State-Changed-From-To: open->feedback 
State-Changed-By: itetcu 
State-Changed-When: Sun Jun 18 10:13:07 UTC 2006 
State-Changed-Why:  
Could you please make the script resamble more closely to the example in 
Porters Hanbook ch. 6.15; also does the extra_commands=reload work ? I 
don't see it implemented anywhere. Thnaks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98287 

From: "Brian A. Seklecki" <bseklecki@collaborativefusion.com>
To: bug-followup@freebsd.org, itetcu@freebsd.org
Cc: Vince Valenti <vince@blue-box.net>, edwin@freebsd.org,
  linimon@freebsd.org, Valdis.Kletnieks@vt.edu, miwi@freebsd.org,
  ivan.lag@ifom-ieo-campus.it, Vivek Khera <vivek@khera.org>,
  sem@freebsd.org
Subject: ports/98287: In port ports/sysutils/syslog-ng it is impossible to
	change parameters of start syslog-ng.
Date: Wed, 29 Nov 2006 16:58:09 -0500

 Remember, anything that gets patched into:
 http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/syslog-ng/files/
 
 Must also now be patched into:
 http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/syslog-ng2/files/
 
 
 itetcu@:
 
 "reload" works fine.  It's part of rc.subr(4) and Syslog-NG 1.x and 2.x
 accept SIGHUP just fine as long as $pidfile is defined.
 
 All:
 
 As for the $pidfile change from static declaration to
 default-w-user-override-able, this is correct and proper.  
 
 Many places run both native in-tree syslogd(8) for the system and
 syslog-ng(8) for special purposes, so they'll want to specify a specific
 PID.
 
 I would recommend that you please commit that change.
 
 Also, I can open a separate ticket for formality, or we can commit this
 little nit as well:
 
 diff -u /usr/ports/sysutils/syslog-ng/files/syslog-ng.sh.in 
 syslog-ng.sh.in
 
 --- /usr/ports/sysutils/syslog-ng/files/syslog-ng.sh.in Wed Mar 29 
 16:20:19 2006
 +++ syslog-ng.sh.in     Fri Nov  3 20:32:59 2006
 @@ -14,6 +14,8 @@
   #syslog_ng_enable="YES"
   #
 
 +syslog_ng_purgeklog=${syslog_ng_purgeklog-"NO"}
 +
   . %%RC_SUBR%%
 
   name=syslog_ng
 @@ -23,6 +25,11 @@
   required_files=%%PREFIX%%/etc/syslog-ng/syslog-ng.conf
   extra_commands=reload
 +
 +if checkyesno syslog_ng_purgeklog; then
 +        start_precmd="echo \"Purging klog(9)\" && sysctl -w 
 kern.msgbuf_clear=1 $start_precmd";
 +fi
 +
   stop_postcmd=stop_postcmd
 
   load_rc_config $name
 
 ----
 
 -- 
 Brian A. Seklecki <bseklecki@collaborativefusion.com>
 Collaborative Fusion, Inc.
 
State-Changed-From-To: feedback->closed 
State-Changed-By: itetcu 
State-Changed-When: Sun Dec 3 22:52:33 UTC 2006 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98287 
State-Changed-From-To: closed->patched 
State-Changed-By: itetcu 
State-Changed-When: Sun Dec 3 22:55:38 UTC 2006 
State-Changed-Why:  
Un-close it waiting for syslog-ng2 maintianer's feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98287 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/98287: commit references a PR
Date: Sun,  3 Dec 2006 22:52:18 +0000 (UTC)

 itetcu      2006-12-03 22:52:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/syslog-ng/files syslog-ng.sh.in 
   Log:
   - Allow user to change parameters of start syslog-ng via vars rc.d script [1]
   - Allow user to purge klog(9) via vars rc.d script [2]
   
   PR:             ports/98287 [1] and [2]
   Submitted by:   Pavel Volkov [1], Brian A. Seklecki [2]
   
   Revision  Changes    Path
   1.2       +12 -2     ports/sysutils/syslog-ng/files/syslog-ng.sh.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Ivan Lago <ivan.lago@ifom-ieo-campus.it>
To: bug-followup@FreeBSD.org,
 pol@iib.ru
Cc:  
Subject: Re: ports/98287: In port ports/sysutils/syslog-ng it is impossible to change parameters of start syslog-ng.
Date: Mon, 4 Dec 2006 15:41:15 +0100

 Update approved for syslog-ng2 too
 
 cheers
Responsible-Changed-From-To: itetcu->freebsd-ports-bugs 
Responsible-Changed-By: itetcu 
Responsible-Changed-When: Thu Mar 15 11:03:58 UTC 2007 
Responsible-Changed-Why:  
It is of no use to keep this PRs for myself, the way real life keeps 
being I have to use en unlikely half hour of free time to sleep :( 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98287 
State-Changed-From-To: patched->closed 
State-Changed-By: rafan 
State-Changed-When: Mon Mar 19 06:28:23 UTC 2007 
State-Changed-Why:  
Committed to syslog-ng2. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98287 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/98287: commit references a PR
Date: Mon, 19 Mar 2007 06:28:14 +0000 (UTC)

 rafan       2007-03-19 06:28:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/syslog-ng2  Makefile 
     sysutils/syslog-ng2/files syslog-ng.sh.in 
   Log:
   Merge rc script changes from syslog-ng port:
   
   - Allow user to change parameters of start syslog-ng via vars rc.d script [1]
   - Allow user to purge klog(9) via vars rc.d script [2]
   
   PR:             ports/98287 [1] and [2]
   Submitted by:   Pavel Volkov [1], Brian A. Seklecki [2]
   Approved by:    Ivan Lago <ivan.lago at ifom-ieo-campus.it> (maintainer)
   
   Revision  Changes    Path
   1.3       +1 -0      ports/sysutils/syslog-ng2/Makefile
   1.2       +12 -2     ports/sysutils/syslog-ng2/files/syslog-ng.sh.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
