From freebsd@unixfreunde.de  Wed May 17 18:37:17 2006
Return-Path: <freebsd@unixfreunde.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3AB0A16B825
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 17 May 2006 18:37:17 +0000 (UTC)
	(envelope-from freebsd@unixfreunde.de)
Received: from unixfreunde.net (unixfreunde.de [85.214.35.254])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5356B43DE1
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 17 May 2006 18:36:57 +0000 (GMT)
	(envelope-from freebsd@unixfreunde.de)
Received: by unixfreunde.net (Postfix, from userid 65534)
	id 9A61450621; Wed, 17 May 2006 20:36:56 +0200 (CEST)
Received: from mwilke.ath.cx (p548D1E2C.dip0.t-ipconnect.de [84.141.30.44])
	by unixfreunde.net (Postfix) with ESMTP id 65B6A505D3
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 17 May 2006 20:36:54 +0200 (CEST)
Message-Id: <1147891012.79093@mwilke.ath.cx>
Date: Wed, 17 May 2006 20:36:52 +0200
From: "Martin Wilke" <freebsd@unixfreunde.de>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: [patch] editors/led
X-Send-Pr-Version: gtk-send-pr 0.4.7 
X-GNATS-Notify:

>Number:         97410
>Category:       ports
>Synopsis:       [patch] editors/led
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    itetcu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 17 18:40:22 GMT 2006
>Closed-Date:    Mon Jun 05 11:17:31 GMT 2006
>Last-Modified:  Mon Jun 05 11:17:31 GMT 2006
>Originator:     Martin Wilke
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:


System: FreeBSD 7.0-CURRENT #140: Mon May 15 20:42:30 CEST 2006
    root@mwilke.ath.cx:/usr/obj/usr/src/sys/BSDBOX



>Description:


- add USE_GCC3.4
- portlint -A fixed




>How-To-Repeat:





>Fix:


--- led.diff begins here ---
diff -ruN /usr/ports/editors/led/Makefile ports/editors/led/Makefile
--- /usr/ports/editors/led/Makefile	Tue Sep 20 13:05:36 2005
+++ ports/editors/led/Makefile	Tue May 16 06:37:55 2006
@@ -16,5 +16,6 @@
 
 GNU_CONFIGURE=	yes
 USE_PERL5=	yes
+USE_GCC=	3.4
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/editors/led/pkg-plist ports/editors/led/pkg-plist
--- /usr/ports/editors/led/pkg-plist	Mon Jul 15 13:21:34 2002
+++ ports/editors/led/pkg-plist	Tue May 16 06:37:22 2006
@@ -1,19 +1,19 @@
 bin/led
 lib/led/modules/perlapi.so
-share/led/syntax/conf
-share/led/syntax/c
-share/led/syntax/h
-share/led/syntax/cc
-share/led/syntax/ledrc
-share/led/syntax/cs
-share/led/syntax/mail
-share/led/syntax/perl
-share/led/syntax/python
-share/led/syntax/sh
-share/led/syntax/syntax
-share/led/syntax/tex
-share/led/color
-@dirrm share/led/syntax
-@dirrm share/led
+%%DATADIR%%/color
+%%DATADIR%%/syntax/c
+%%DATADIR%%/syntax/cc
+%%DATADIR%%/syntax/conf
+%%DATADIR%%/syntax/cs
+%%DATADIR%%/syntax/h
+%%DATADIR%%/syntax/ledrc
+%%DATADIR%%/syntax/mail
+%%DATADIR%%/syntax/perl
+%%DATADIR%%/syntax/python
+%%DATADIR%%/syntax/sh
+%%DATADIR%%/syntax/syntax
+%%DATADIR%%/syntax/tex
+@dirrm %%DATADIR%%/syntax
+@dirrm %%DATADIR%%
 @dirrm lib/led/modules
 @dirrm lib/led
--- led.diff ends here ---



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->itetcu 
Responsible-Changed-By: itetcu 
Responsible-Changed-When: Thu May 18 03:47:34 UTC 2006 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97410 
State-Changed-From-To: open->feedback 
State-Changed-By: itetcu 
State-Changed-When: Thu May 18 05:30:34 UTC 2006 
State-Changed-Why:  
"ask submitter why USE_CGG=3.4" 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97410 

From: Ion-Mihai "IOnut" Tetcu <itetcu@FreeBSD.org>
To: "Martin Wilke" <freebsd@unixfreunde.de>
Cc: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org>
Subject: Re: ports/97410: [patch] editors/led
Date: Thu, 18 May 2006 08:30:03 +0300

 --Sig_hCmGL2EF6Sm+B/G7npAUF_l
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 > - add USE_GCC3.4
 
 Why ?
 
 
 --=20
 IOnut - Un^d^dregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 
 BOFH excuse #252:
 Our ISP is having {switching,routing,SMDS,frame relay} problems
 
 
 
 --Sig_hCmGL2EF6Sm+B/G7npAUF_l
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.3 (FreeBSD)
 
 iD4DBQFEbAZbBX6fi0k6KXsRAlGrAJdVw+XwYfWXZUXs8py6dhgC+lsfAJwP+ZZc
 r2YbK5oKS93TAJ2o2ImGPg==
 =xyLl
 -----END PGP SIGNATURE-----
 
 --Sig_hCmGL2EF6Sm+B/G7npAUF_l--
State-Changed-From-To: feedback->open 
State-Changed-By: itetcu 
State-Changed-When: Thu May 18 05:40:47 UTC 2006 
State-Changed-Why:  
doesn't run / build with with gcc 4.0/4.1 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97410 
State-Changed-From-To: open->feedback 
State-Changed-By: itetcu 
State-Changed-When: Sun May 21 01:14:19 UTC 2006 
State-Changed-Why:  
I built the port with gcc 4.0 on i386 on 4, 5, 6 and HEAD and with 4.1 
on amd64 on 5, 6, and HEAD. Are youaware of any runtime problems when 
the port is built with gcc 4.0/4.1 ? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97410 
State-Changed-From-To: feedback->open 
State-Changed-By: itetcu 
State-Changed-When: Sun Jun 4 18:35:21 UTC 2006 
State-Changed-Why:  
USE_GCC is not necessary, according to submitter and my tests 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97410 
State-Changed-From-To: open->closed 
State-Changed-By: itetcu 
State-Changed-When: Mon Jun 5 11:17:29 UTC 2006 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97410 
>Unformatted:
