From ddliu@readonline.info  Wed May 17 03:07:55 2006
Return-Path: <ddliu@readonline.info>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 08E8216A403
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 17 May 2006 03:07:55 +0000 (UTC)
	(envelope-from ddliu@readonline.info)
Received: from readonline.info (readonline.info [221.0.230.72])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5683343D45
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 17 May 2006 03:07:54 +0000 (GMT)
	(envelope-from ddliu@readonline.info)
Received: from [127.0.0.1] (helo=readonline.info)
	by readonline.info with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.62 (FreeBSD))
	(envelope-from <ddliu@readonline.info>)
	id 1FgCO6-0002yd-BW
	for FreeBSD-gnats-submit@freebsd.org; Wed, 17 May 2006 11:07:50 +0800
Received: (from ddliu@localhost)
	by readonline.info (8.13.4/8.13.4/Submit) id k4H37IdW011446;
	Wed, 17 May 2006 11:07:18 +0800 (CST)
	(envelope-from ddliu)
Message-Id: <200605170307.k4H37IdW011446@readonline.info>
Date: Wed, 17 May 2006 11:07:18 +0800 (CST)
From: Dryice Liu <dryice@dryice.name>
Reply-To: Dryice Liu <dryice@dryice.name>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [maintainer] www/roundup: add options
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         97382
>Category:       ports
>Synopsis:       [maintainer] www/roundup: add options
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    itetcu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 17 03:10:14 GMT 2006
>Closed-Date:    Fri May 19 06:04:30 GMT 2006
>Last-Modified:  Fri May 19 06:04:30 GMT 2006
>Originator:     Dryice Liu
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD dryice.3322.org 6.0-STABLE FreeBSD 6.0-STABLE #0: Thu Dec 1 15:59:44 CST 2005


	
>Description:

	add options to run depends on various backends

>How-To-Repeat:
	
>Fix:

	

--- attached file begins here ---
diff -ruN roundup.old/Makefile roundup/Makefile
--- roundup.old/Makefile	Wed May 10 08:54:49 2006
+++ roundup/Makefile	Wed May 17 11:03:08 2006
@@ -19,7 +19,30 @@
 USE_PYDISTUTILS=	yes
 USE_GETTEXT=	yes
 
+OPTIONS=	SQLITE	"Support Sqlite as backend" on
+OPTIONS+=	METAKIT	"Support metakit as backend" off
+OPTIONS+=	PGSQL	"Support posggresql as backend" off
+OPTIONS+=	MYSQL	"Support mysql as backend" off
+
+.include <bsd.port.pre.mk>
+
+.if !defined(WITHOUT_SQLITE)
+RUN_DEPENDS+=	${PREFIX}/%%PYTHON_SITELIBDIR%%/sqlite/__init__.py:${PORTSDIR}/databases/py-PySQLite11
+.endif
+
+.if !defined(WITHOUT_METAKIT)
+RUN_DEPENDS+=	${PREFIX}/%%PYTHON_SITELIBDIR%%/metakit.py:${PORTSDIR}/databases/metakit
+.endif
+
+.if !defined(WITHOUT_PGSQL)
+RUN_DEPENDS+=	${PREFIX}/lib/%%PYTHON_VERSION%%/site-packages/psycopgmodule.so:${PORTSDIR}/databases/py-psycopg
+.endif
+
+.if !defined(WITHOUT_MYSQL)
+RUN_DEPENDS+=	${PREFIX}/%%PYTHON_SITELIBDIR%%/MySQLdb/__init__.py:${PORTSDIR}/databases/py-MySQLdb
+.endif
+
 MAN1=		roundup-admin.1 roundup-demo.1 roundup-mailgw.1 \
 		roundup-server.1
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- attached file ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->itetcu 
Responsible-Changed-By: itetcu 
Responsible-Changed-When: Wed May 17 08:02:08 UTC 2006 
Responsible-Changed-Why:  
I like OPTIONS 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97382 
State-Changed-From-To: open->feedback 
State-Changed-By: itetcu 
State-Changed-When: Wed May 17 08:14:24 UTC 2006 
State-Changed-Why:  
Ask for submitter fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97382 

From: Dryice Liu <dryice@dryice.name>
To: bug-followup@FreeBSD.org,dryice@dryice.name
Cc:  
Subject: Re: ports/97382: [maintainer] www/roundup: add options
Date: Wed, 17 May 2006 21:21:48 +0800

 Thanks Ion-Mihai for pointing this out. Here is a new patch with fix.
 
 ======================================================================
 diff -ruN roundup.old/Makefile roundup/Makefile
 --- roundup.old/Makefile	Wed May 10 08:54:49 2006
 +++ roundup/Makefile	Wed May 17 21:16:22 2006
 @@ -19,7 +19,30 @@
  USE_PYDISTUTILS=	yes
  USE_GETTEXT=	yes
  
 +OPTIONS=	SQLITE	"Support Sqlite as backend" on
 +OPTIONS+=	METAKIT	"Support metakit as backend" off
 +OPTIONS+=	PGSQL	"Support posggresql as backend" off
 +OPTIONS+=	MYSQL	"Support mysql as backend" off
 +
 +.include <bsd.port.pre.mk>
 +
 +.if !defined(WITHOUT_SQLITE)
 +RUN_DEPENDS+=	${PREFIX}/%%PYTHON_SITELIBDIR%%/sqlite/__init__.py:${PORTSDIR}/databases/py-PySQLite11
 +.endif
 +
 +.if defined(WITH_METAKIT)
 +RUN_DEPENDS+=	${PREFIX}/%%PYTHON_SITELIBDIR%%/metakit.py:${PORTSDIR}/databases/metakit
 +.endif
 +
 +.if defined(WITH_PGSQL)
 +RUN_DEPENDS+=	${PREFIX}/lib/%%PYTHON_VERSION%%/site-packages/psycopgmodule.so:${PORTSDIR}/databases/py-psycopg
 +.endif
 +
 +.if defined(WITH_MYSQL)
 +RUN_DEPENDS+=	${PREFIX}/%%PYTHON_SITELIBDIR%%/MySQLdb/__init__.py:${PORTSDIR}/databases/py-MySQLdb
 +.endif
 +
  MAN1=		roundup-admin.1 roundup-demo.1 roundup-mailgw.1 \
  		roundup-server.1
  
 -.include <bsd.port.mk>
 +.include <bsd.port.post.mk>
 ======================================================================
 -- 
 Dryice @ http://dryice.name
 
 Please avoid sending me Word or PowerPoint attachments.
 See http://www.gnu.org/philosophy/sylvester-response.html
State-Changed-From-To: feedback->open 
State-Changed-By: itetcu 
State-Changed-When: Wed May 17 13:34:03 UTC 2006 
State-Changed-Why:  
new patch received 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97382 
State-Changed-From-To: open->closed 
State-Changed-By: itetcu 
State-Changed-When: Fri May 19 06:04:27 UTC 2006 
State-Changed-Why:  
Commited with fixes: 
s:${PREFIX}/%%PYTHON_SITELIBDIR%%:${PYTHON_SITELIBDIR}: in RUN_DEPENDS 

http://www.freebsd.org/cgi/query-pr.cgi?pr=97382 
>Unformatted:
