From jylefort@brutele.be  Thu May  4 14:40:13 2006
Return-Path: <jylefort@brutele.be>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 020DD16A467
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 May 2006 14:40:12 +0000 (UTC)
	(envelope-from jylefort@brutele.be)
Received: from mirapoint3.brutele.be (mirapoint3.brutele.be [212.68.199.148])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4DDAC43D45
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 May 2006 14:40:11 +0000 (GMT)
	(envelope-from jylefort@brutele.be)
Received: from host-212-68-244-243.brutele.be (host-212-68-244-243.brutele.be [212.68.244.243])
	by mirapoint3.brutele.be (MOS 3.7.3-GA)
	with ESMTP id AFX22321;
	Thu, 4 May 2006 16:40:09 +0200 (CEST)
Received: from jsite.lefort.net (jsite.lefort.net [192.168.1.2])
	by gateway.lefort.net (Postfix) with ESMTP id B9C3854F5
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 May 2006 16:40:09 +0200 (CEST)
Received: by jsite.lefort.net (Postfix, from userid 1000)
	id 7E484C0FD; Thu,  4 May 2006 16:40:09 +0200 (CEST)
Message-Id: <20060504144009.7E484C0FD@jsite.lefort.net>
Date: Thu,  4 May 2006 16:40:09 +0200 (CEST)
From: Jean-Yves Lefort <jylefort@FreeBSD.org>
Reply-To: Jean-Yves Lefort <jylefort@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: fix handling of OPTIONS default values in bsd.port.mk
X-Send-Pr-Version: 3.113

>Number:         96777
>Category:       ports
>Synopsis:       fix handling of OPTIONS default values in bsd.port.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 04 14:50:19 GMT 2006
>Closed-Date:    Mon Apr 02 22:41:36 GMT 2007
>Last-Modified:  Mon Apr  2 22:50:04 GMT 2007
>Originator:     Jean-Yves Lefort
>Release:        FreeBSD 6.0-RELEASE i386
>Organization:
>Environment:
System: FreeBSD jsite.lefort.net 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Fri Apr 28 18:59:37 CEST 2006 jylefort@jsite.lefort.net:/usr/obj/usr/src/sys/JSITE i386
>Description:
See this discussion:

	http://lists.freebsd.org/pipermail/cvs-ports/2006-May/093086.html
>How-To-Repeat:
>Fix:
--- bsd.port.mk.orig	Tue May  2 12:09:23 2006
+++ bsd.port.mk	Thu May  4 16:33:55 2006
@@ -1133,7 +1133,7 @@
 OPTIONSFILE?=	${PORT_DBDIR}/${UNIQUENAME}/options
 _OPTIONSFILE!=	${ECHO_CMD} "${OPTIONSFILE}"
 .if defined(OPTIONS)
-.	if defined(PACKAGE_BUILDING) || (defined(BATCH) && !exists(${_OPTIONSFILE}))
+.	if !exists(${_OPTIONSFILE})
 WITHOUT:=
 WITH:=
 .	if defined(OPTIONS)
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu May 4 14:52:13 UTC 2006 
Responsible-Changed-Why:  
bsd.port.mk is port manager territory 

http://www.freebsd.org/cgi/query-pr.cgi?pr=96777 
State-Changed-From-To: open->analyzed 
State-Changed-By: pav 
State-Changed-When: Thu Mar 29 17:15:58 UTC 2007 
State-Changed-Why:  
Extended patch, supplied by rafan, is being tested on the pointyhat cluster 

http://www.freebsd.org/cgi/query-pr.cgi?pr=96777 
State-Changed-From-To: analyzed->closed 
State-Changed-By: pav 
State-Changed-When: Mon Apr 2 22:39:50 UTC 2007 
State-Changed-Why:  
Fixed (using rafan's patch). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=96777 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/96777: commit references a PR
Date: Mon,  2 Apr 2007 22:41:26 +0000 (UTC)

 pav         2007-04-02 22:41:20 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.port.mk 
   Log:
   - Fix handling of OPTIONS default values when configuration files wasn't
     written yet (make depends, make describe), and for options missing from
     existing configuration files
   
   PR:             ports/96777
   Submitted by:   rafan (in follow-up)
   Tested on:      pointyhat exp-run
   
   Revision  Changes    Path
   1.559     +13 -9     ports/Mk/bsd.port.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
