From frank@dynamical-systems.org  Sun Mar 26 18:25:38 2006
Return-Path: <frank@dynamical-systems.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7CAC516A41F;
	Sun, 26 Mar 2006 18:25:38 +0000 (UTC)
	(envelope-from frank@dynamical-systems.org)
Received: from mout1.freenet.de (mout1.freenet.de [194.97.50.132])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DB8DB43D45;
	Sun, 26 Mar 2006 18:25:37 +0000 (GMT)
	(envelope-from frank@dynamical-systems.org)
Received: from [194.97.55.242] (helo=mx9.freenet.de)
	by mout1.freenet.de with esmtpa (Exim 4.61)
	(envelope-from <frank@dynamical-systems.org>)
	id 1FNZvk-0008Db-Oj; Sun, 26 Mar 2006 20:25:36 +0200
Received: from p508e9e50.dip0.t-ipconnect.de ([80.142.158.80] helo=pollux.senax.net)
	by mx9.freenet.de with esmtpsa (ID jr-relay@freenet.de) (TLSv1:AES256-SHA:256) (Exim 4.61 #1)
	id 1FNZvk-0005OE-Bz; Sun, 26 Mar 2006 20:25:36 +0200
Received: from pollux.senax.net (localhost.senax.net [127.0.0.1])
	by pollux.senax.net (8.13.6/8.13.6) with ESMTP id k2QIPYgA006270;
	Sun, 26 Mar 2006 20:25:34 +0200 (CEST)
	(envelope-from frank@dynamical-systems.org)
Received: (from josellis@localhost)
	by pollux.senax.net (8.13.6/8.13.6/Submit) id k2QIPXQ7006269;
	Sun, 26 Mar 2006 20:25:33 +0200 (CEST)
	(envelope-from frank@dynamical-systems.org)
Message-Id: <200603261825.k2QIPXQ7006269@pollux.senax.net>
Date: Sun, 26 Mar 2006 20:25:33 +0200 (CEST)
From: "Frank W. Josellis" <frank@dynamical-systems.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: ijliao@freebsd.org
Subject: games/sudoku - saving a game does not work
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         94972
>Category:       ports
>Synopsis:       games/sudoku - saving a game does not work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ijliao
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 26 18:30:15 GMT 2006
>Closed-Date:    Tue Mar 28 00:59:03 GMT 2006
>Last-Modified:  Tue Mar 28 00:59:03 GMT 2006
>Originator:     Frank W. Josellis
>Release:        FreeBSD 5.5-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD pollux.senax.net 5.5-PRERELEASE FreeBSD 5.5-PRERELEASE #5: Fri Mar 24 13:53:32 CET 2006 root@pollux.senax.net:/usr/obj/usr/src/sys/POLLUX i386


	
>Description:
Nice port, but trying to save a game is a fatal trap: the program expects
a filename follwed by CR, but hitting <ENTER> sends LF (for xterm as well
as for console). From here `killall sudoku` seems to be the only way out.
Please consider the patch below to fix this problem.

>How-To-Repeat:
Invoke sudoku and then hit 's' for 'save'.

>Fix:

--- sudoku-1.0.1.patch begins here ---
diff -Nur sudoku.BAK/Makefile sudoku/Makefile
--- sudoku.BAK/Makefile	Fri Mar 17 01:04:56 2006
+++ sudoku/Makefile	Sun Mar 26 18:25:24 2006
@@ -8,6 +8,7 @@
 
 PORTNAME=	sudoku
 PORTVERSION=	1.0.1
+PORTREVISION=	1
 CATEGORIES=	games
 MASTER_SITES=	http://www.laurasia.com.au/downloads/
 EXTRACT_SUFX=	.tgz
diff -Nur sudoku.BAK/files/patch-sudoku.c sudoku/files/patch-sudoku.c
--- sudoku.BAK/files/patch-sudoku.c	Thu Jan  1 01:00:00 1970
+++ sudoku/files/patch-sudoku.c	Sun Mar 26 18:16:35 2006
@@ -0,0 +1,11 @@
+--- sudoku.c.orig	Mon Jul 25 03:13:31 2005
++++ sudoku.c	Sun Mar 26 18:12:22 2006
+@@ -1837,7 +1837,7 @@
+ 
+     /* Read character input (raw processing mode) */
+     i = strlen( userfile );
+-    while( '\r' != ( ch = getkey( ) ) )
++    while( '\n' != ( ch = getkey( ) ) )
+     {
+         if( 0x08 == ch || VKEY_LEFT == ch ) /* destructive backspace */
+         {
--- sudoku-1.0.1.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ijliao 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Mar 26 18:34:14 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94972 
State-Changed-From-To: open->closed 
State-Changed-By: ijliao 
State-Changed-When: Tue Mar 28 00:58:53 UTC 2006 
State-Changed-Why:  
committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94972 
>Unformatted:
