From itetcu@people.tecnik93.com  Fri Mar 10 01:45:24 2006
Return-Path: <itetcu@people.tecnik93.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B0CDB16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 10 Mar 2006 01:45:24 +0000 (GMT)
	(envelope-from itetcu@people.tecnik93.com)
Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 400A243D45
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 10 Mar 2006 01:45:24 +0000 (GMT)
	(envelope-from itetcu@people.tecnik93.com)
Received: from it.buh.tecnik93.com (localhost [127.0.0.1])
	by it.buh.tecnik93.com (Postfix) with ESMTP id 1BC7A1758D
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 10 Mar 2006 03:45:23 +0200 (EET)
Message-Id: <1141955123.89714@it.buh.tecnik93.com>
Date: Fri, 10 Mar 2006 03:45:23 +0200
From: "Ion-Mihai "IOnut" Tetcu" <itetcu@people.tecnik93.com>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: [PATCH] misc/tinderbox: OPTIONaly depend on c[v]sup
X-Send-Pr-Version: gtk-send-pr 0.4.7 
X-GNATS-Notify: andreas@syndrom23.de

>Number:         94288
>Category:       ports
>Synopsis:       [PATCH] misc/tinderbox: OPTIONaly depend on c[v]sup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    itetcu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 10 01:50:05 GMT 2006
>Closed-Date:    Fri May 12 13:51:36 GMT 2006
>Last-Modified:  Fri May 12 13:51:36 GMT 2006
>Originator:     Ion-Mihai "IOnut" Tetcu
>Release:        FreeBSD 6.1-PRERELEASE i386
>Organization:
Tecnik'93 
>Environment:


System: FreeBSD 6.1-PRERELEASE #0: Fri Feb 24 07:01:54 EET 2006
    root@it.buh.tecnik93.com:/usr/obj/usr/src/sys/IT6_B_P



>Description:


Csup is mature enough to be used and builds much faster that cvsup and dependencies.
Tinderbox now has support for using something else that cvsup for updates.
So offer the option to tun-depend on one or the other.

On HEAD csup is in the base, but I don't think we had a OSVERSION bump since it was imported;
when a new bump is done we should try to install/depend on csup.




>How-To-Repeat:





>Fix:


--- tinderbox.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/misc/tinderbox/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile	24 Feb 2006 02:28:02 -0000	1.13
+++ Makefile	10 Mar 2006 01:33:59 -0000
@@ -6,7 +6,7 @@
 
 PORTNAME=	tinderbox
 PORTVERSION=	2.3.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	misc
 MASTER_SITES=	http://tinderbox.marcuscom.com/
 
@@ -19,7 +19,9 @@
 		cvsup:${PORTSDIR}/net/cvsup-without-gui
 
 OPTIONS=	PGSQL "With pgsql" On \
-		MYSQL "With mysql" Off
+		MYSQL "With mysql" Off \
+		CSUP  "Use CSUP for updates"   On \
+		CVSUP "Use CVSUP for updates"  Off
 
 NO_BUILD=	yes
 USE_APACHE=	yes
@@ -44,6 +46,14 @@
 USE_PHP+=	mysql
 USE_MYSQL=	yes
 RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/DBD/mysql.pm:${PORTSDIR}/databases/p5-DBD-mysql
+.endif
+
+.if defined(WITH_CSUP)
+RUN_DEPENDS+=	csup:${PORTSDIR}/net/csup
+.endif
+
+.if defined(WITH_CVSUP)
+RUN_DEPENDS+=	cvsup:${PORTSDIR}/net/cvsup-without-gui
 .endif
 
 .include "${PORTSDIR}/Mk/bsd.php.mk"
--- tinderbox.diff ends here ---



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Mar 10 01:52:11 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94288 

From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
To: "Ion-Mihai "IOnut" Tetcu" <itetcu@people.tecnik93.com>
Cc: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org>
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on
 c[v]sup
Date: Fri, 10 Mar 2006 04:32:04 +0200

 --MP_15qD_UUazmXQi8Sx6qg/oX=
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 This new patch also fixes p5-DBD-mysql dependency
 
  # /var/tinderbox/scripts/setup.sh
 Welcome to the Tinderbox Setup script.  This script will guide you through
 some of the automated Tinderbox setup steps.  Once this script completes, you
 should review the documentation in /var/tinderbox/scripts/README or on the
 web at http://tinderbox.marcuscom.com/ to complete your setup.
 
 Hit <ENTER> to get started:
 INFO: Checking prerequisites ...
 DONE.
 
 INFO: Creating default configuration files ...
 DONE.
 
 INFO: Beginning database configuration.
 Enter database driver (mysql pgsql): mysql
 INFO: Checking for prerequisites for mysql database driver ...
 ERROR: The following mandatory dependencies are missing.  These must be
 installed prior to running the Tinderbox setup script.
 ERROR:     databases/p5-DBD-mysql41 databases/mysql41-client
 root(itetcu)@worf/SU >-SSH-> /usr/ports/misc/tinderbox [4:20:44] 1
  # pkg_info -I p5-DBD\*
 p5-DBD-mysql-3.0002 MySQL driver for the Perl5 Database Interface (DBI)
 
  # make -VMYSQL_VER
 50
 
 
 
 -- 
 IOnut - Unregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 
 BOFH excuse #157:
 Incorrect time synchronization
 
 
 
 --MP_15qD_UUazmXQi8Sx6qg/oX=
 Content-Type: text/x-patch; name=tinderbox.diff
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=tinderbox.diff
 
 ? tinderbox.diff
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/misc/tinderbox/Makefile,v
 retrieving revision 1.13
 diff -u -r1.13 Makefile
 --- Makefile	24 Feb 2006 02:28:02 -0000	1.13
 +++ Makefile	10 Mar 2006 02:28:45 -0000
 @@ -6,7 +6,7 @@
  
  PORTNAME=	tinderbox
  PORTVERSION=	2.3.0
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	misc
  MASTER_SITES=	http://tinderbox.marcuscom.com/
  
 @@ -19,7 +19,9 @@
  		cvsup:${PORTSDIR}/net/cvsup-without-gui
  
  OPTIONS=	PGSQL "With pgsql" On \
 -		MYSQL "With mysql" Off
 +		MYSQL "With mysql" Off \
 +		CSUP  "Use CSUP for updates"   On \
 +		CVSUP "Use CVSUP for updates"  Off
  
  NO_BUILD=	yes
  USE_APACHE=	yes
 @@ -43,7 +45,15 @@
  .if defined(WITH_MYSQL)
  USE_PHP+=	mysql
  USE_MYSQL=	yes
 -RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/DBD/mysql.pm:${PORTSDIR}/databases/p5-DBD-mysql
 +RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/DBD/mysql.pm:${PORTSDIR}/databases/p5-DBD-mysql${MYSQL_VER}
 +.endif
 +
 +.if defined(WITH_CSUP)
 +RUN_DEPENDS+=	csup:${PORTSDIR}/net/csup
 +.endif
 +
 +.if defined(WITH_CVSUP)
 +RUN_DEPENDS+=	cvsup:${PORTSDIR}/net/cvsup-without-gui
  .endif
  
  .include "${PORTSDIR}/Mk/bsd.php.mk"
 
 --MP_15qD_UUazmXQi8Sx6qg/oX=--

From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
To: "Ion-Mihai "IOnut" Tetcu" <itetcu@people.tecnik93.com>
Cc: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org>
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on
 c[v]sup
Date: Fri, 10 Mar 2006 05:17:21 +0200

 > >Description:
 > 
 > 
 > Csup is mature enough to be used and builds much faster that cvsup and dependencies.
 > Tinderbox now has support for using something else that cvsup for updates.
 
 The update command for ./create Jail should be set to ../../../usr/local/bin/csup
 
 -- 
 IOnut - Unregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 
 BOFH excuse #370:
 Virus due to computers having unsafe sex
 
 

From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
To: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
Cc: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org>
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on
 c[v]sup
Date: Fri, 10 Mar 2006 14:58:13 +0200

 On Fri, 10 Mar 2006 05:17:21 +0200
 Ion-Mihai Tetcu <itetcu@people.tecnik93.com> wrote:
 
 > > >Description:
 > > 
 > > 
 > > Csup is mature enough to be used and builds much faster that cvsup and dependencies.
 > > Tinderbox now has support for using something else that cvsup for updates.
 > 
 > The update command for ./create Jail should be set to ../../../usr/local/bin/csup
 
 Err, more like:
       '../../../usr/local/bin/csup /var/tinderbox/jails/6/src-supfile'
 e.g. if not using cvsup you need to pass the exact invocation of the update  command.
 
 
 -- 
 IOnut - Unregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 
 History tends to exaggerate.
 		-- Col. Green, "The Savage Curtain", stardate 5906.4
 
 

From: Andreas Kohn <andreas@syndrom23.de>
To: bug-followup@FreeBSD.org, itetcu@people.tecnik93.com
Cc:  
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on
	c[v]sup
Date: Sat, 18 Mar 2006 12:59:31 +0100

 --=-5nBkBW3ZFI1EyC2OFnA7
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable
 
 Hi,
 
 I like the patch to enable cvsup/csup selection.
 I think the unconditional RUN_DEPENDS on cvsup needs to get removed in
 that case as well.
 The patch for MySQL is incomplete, as setup-mysql.sh would still barf
 about missing MySQL-ports.
 The attached patch also fixes that, and sets USE_APACHE=3D1.3+ to stop
 annoying apache2 users that apache13 is needed :)
 
 Ion-Mihai, what do you think?
 
 Regards,
 Andreas
 
 (Patch copy/pasted into the Mail, I cannot make evolution not send it base6=
 4-encoded :/
  same patch available on http://andreas.syndrom23.de/dump/tb-r2.diff
 )
 --- tb-r2.diff begins here ---
 Index: Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /storage/freebsd/cvs/ports/misc/tinderbox/Makefile,v
 retrieving revision 1.13
 diff -u -r1.13 Makefile
 --- Makefile	24 Feb 2006 02:28:02 -0000	1.13
 +++ Makefile	18 Mar 2006 11:38:26 -0000
 @@ -6,7 +6,7 @@
 =20
  PORTNAME=3D	tinderbox
  PORTVERSION=3D	2.3.0
 -PORTREVISION=3D	1
 +PORTREVISION=3D	2
  CATEGORIES=3D	misc
  MASTER_SITES=3D	http://tinderbox.marcuscom.com/
 =20
 @@ -15,14 +15,15 @@
 =20
  RUN_DEPENDS=3D	${SITE_PERL}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/securit=
 y/p5-Digest-MD5 \
  		${SITE_PERL}/Net/SMTP.pm:${PORTSDIR}/net/p5-Net \
 -		${LOCALBASE}/share/pear/DB.php:${PORTSDIR}/databases/pear-DB \
 -		cvsup:${PORTSDIR}/net/cvsup-without-gui
 +		${LOCALBASE}/share/pear/DB.php:${PORTSDIR}/databases/pear-DB
 =20
  OPTIONS=3D	PGSQL "With pgsql" On \
 -		MYSQL "With mysql" Off
 +		MYSQL "With mysql" Off \
 +		CSUP  "Use csup for updates" On \
 +		CVSUP "Use cvsup for updates" Off
 =20
  NO_BUILD=3D	yes
 -USE_APACHE=3D	yes
 +USE_APACHE=3D	1.3+
  SUB_FILES=3D	pkg-message
  PKGMESSAGE=3D	${WRKDIR}/pkg-message
 =20
 @@ -43,7 +44,15 @@
  .if defined(WITH_MYSQL)
  USE_PHP+=3D	mysql
  USE_MYSQL=3D	yes
 -RUN_DEPENDS+=3D	${SITE_PERL}/${PERL_ARCH}/DBD/mysql.pm:${PORTSDIR}/databas=
 es/p5-DBD-mysql
 +RUN_DEPENDS+=3D	${SITE_PERL}/${PERL_ARCH}/DBD/mysql.pm:${PORTSDIR}/databas=
 es/p5-DBD-mysql${MYSQL_VER}
 +.endif
 +
 +.if defined(WITH_CSUP)
 +RUN_DEPENDS+=3D	csup:${PORTSDIR}/net/csup
 +.endif
 +
 +.if defined(WITH_CVSUP)
 +RUN_DEPENDS+=3D	cvsup:${PORTSDIR}/net/cvsup-without-gui
  .endif
 =20
  .include "${PORTSDIR}/Mk/bsd.php.mk"
 @@ -53,6 +62,13 @@
  	${MV} ${WRKSRC}/www-exp/${f} ${WRKSRC}/www-exp/${f}-dist
  .endfor
 =20
 +post-patch:
 +.if defined(WITH_MYSQL)
 +	${REINPLACE_CMD} \
 +		-e 's,DB_MAN_PREREQS=3D.*,DB_MAN_PREREQS=3D"databases/p5-DBD-mysql${MYSQ=
 L_VER} databases/mysql${MYSQL_VER}-client",' \
 +		${WRKSRC}/lib/setup-mysql.sh
 +.endif
 +
  do-install:
  	${MKDIR} ${PREFIX}/tinderbox/scripts
  	${CP} -R ${WRKSRC}/* ${PREFIX}/tinderbox/scripts
 
 --- tb-r2.diff ends here ---
 
 
 
 --=-5nBkBW3ZFI1EyC2OFnA7
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (FreeBSD)
 
 iD8DBQBEG/YjYucd7Ow1ygwRAu9yAJ0ab1JfwTQc3eQ3FFfsXNeFEiwhHACfe+xz
 uBPEOslllqpEfzr0xDqNbAo=
 =vUhS
 -----END PGP SIGNATURE-----
 
 --=-5nBkBW3ZFI1EyC2OFnA7--
 

From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
To: Andreas Kohn <andreas@syndrom23.de>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on
 c[v]sup
Date: Sat, 18 Mar 2006 19:09:26 +0200

 On Sat, 18 Mar 2006 12:59:31 +0100
 Andreas Kohn <andreas@syndrom23.de> wrote:
 
 > Hi,
 > 
 > I like the patch to enable cvsup/csup selection.
 > I think the unconditional RUN_DEPENDS on cvsup needs to get removed in
 > that case as well.
 > The patch for MySQL is incomplete, as setup-mysql.sh would still barf
 > about missing MySQL-ports.
 
 Yes, I was too enthusiastic the night I sent that PR; I didn't do the
 post-patch because I didn't know if that shouldn't be fixed upstream.
 
 > The attached patch also fixes that, and sets USE_APACHE=1.3+ to stop
 > annoying apache2 users that apache13 is needed :)
 > 
 > Ion-Mihai, what do you think?
 
  [ .. patch .. ]
 
 Looks good.
 
 
 -- 
 IOnut - Unregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 
 The sooner our happiness together begins, the longer it will last.
 		-- Miramanee, "The Paradise Syndrome", stardate 4842.6
 
 
Responsible-Changed-From-To: freebsd-ports-bugs->jmelo 
Responsible-Changed-By: jmelo 
Responsible-Changed-When: Tue Apr 4 17:37:38 UTC 2006 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94288 

From: Jean Milanez Melo <jmelo@FreeBSD.org>
To: bug-followup@FreeBSD.org,  itetcu@people.tecnik93.com, 
 andreas@syndrom23.de
Cc:  
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on c[v]sup
Date: Wed, 05 Apr 2006 12:52:00 -0300

 Dears,
 
 I looked the patch last night and i would like to give an advice to you. 
 You should apply a patch (eg. with REINPLACE_CMD) in tinderbox script 
 when the user choose csup as default updater. Otherwise the user must 
 pass exact invocation of the update command as itetcu said before.
 
 - Jean

From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
To: Jean Milanez Melo <jmelo@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, andreas@syndrom23.de,
 tinderbox-list@marcuscom.com
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on
 c[v]sup
Date: Wed, 5 Apr 2006 23:46:05 +0300

 On Wed, 05 Apr 2006 12:52:00 -0300
 Jean Milanez Melo <jmelo@FreeBSD.org> wrote:
 
 > Dears,
 > 
 > I looked the patch last night and i would like to give an advice to you. 
 > You should apply a patch (eg. with REINPLACE_CMD) in tinderbox script 
 > when the user choose csup as default updater. Otherwise the user must 
 > pass exact invocation of the update command as itetcu said before.
 
 After reading a small part of the code when installing my latest tindy,
 I believe the problem should be fixed upstream (hence tinderbox list
 cc'ed), both in the scripts/create and in scripts/tc. We can of course
 patch this locally until the next release.
 
 Please commit the patch as it is for now, since Andreas is rather busy
 for now.
 
 Thanks,
 
 -- 
 IOnut - Unregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 
 BOFH excuse #23:
 improperly oriented keyboard
 
 

From: Joe Marcus Clarke <marcus@marcuscom.com>
To: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
Cc: Jean Milanez Melo <jmelo@freebsd.org>, tinderbox-list@marcuscom.com,
        bug-followup@freebsd.org
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on c[v]sup
Date: Wed, 05 Apr 2006 16:56:03 -0400

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 Ion-Mihai Tetcu wrote:
 > On Wed, 05 Apr 2006 12:52:00 -0300
 > Jean Milanez Melo <jmelo@FreeBSD.org> wrote:
 > 
 >> Dears,
 >>
 >> I looked the patch last night and i would like to give an advice to you. 
 >> You should apply a patch (eg. with REINPLACE_CMD) in tinderbox script 
 >> when the user choose csup as default updater. Otherwise the user must 
 >> pass exact invocation of the update command as itetcu said before.
 
 Please concisely describe the problem for this list.
 
 Joe
 
 - --
 PGP Key : http://www.marcuscom.com/pgp.asc
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (Darwin)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
 iD8DBQFENC7Ib2iPiv4Uz4cRAu0iAJ9+W7caF6kbAe4y8TrwN6e6vv/k8ACfdDhp
 zREaEiFPIxPlBv54iLpdvJk=
 =uVFt
 -----END PGP SIGNATURE-----

From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
To: Joe Marcus Clarke <marcus@marcuscom.com>
Cc: Jean Milanez Melo <jmelo@freebsd.org>, tinderbox-list@marcuscom.com,
 bug-followup@freebsd.org
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on
 c[v]sup
Date: Thu, 6 Apr 2006 01:07:06 +0300

  [ Dropped bug-follow-up ]
 
 On Wed, 05 Apr 2006 16:56:03 -0400
 Joe Marcus Clarke <marcus@marcuscom.com> wrote:
 
 > -----BEGIN PGP SIGNED MESSAGE-----
 > Hash: SHA1
 > 
 > Ion-Mihai Tetcu wrote:
 > > On Wed, 05 Apr 2006 12:52:00 -0300
 > > Jean Milanez Melo <jmelo@FreeBSD.org> wrote:
 > > 
 > >> Dears,
 > >>
 > >> I looked the patch last night and i would like to give an advice to you. 
 > >> You should apply a patch (eg. with REINPLACE_CMD) in tinderbox script 
 > >> when the user choose csup as default updater. Otherwise the user must 
 > >> pass exact invocation of the update command as itetcu said before.
 > 
 > Please concisely describe the problem for this list.
 
 You can't use something else that cvsup as update command for port
 trees or jails. The example in the README doesn't work (it will still
 try to use cvsup). From glancing at the code it seems -P's values isn't
 used by ./tc  (and it's used wrong by ./create).
 
 I don't have my last full session of trial and error, but if you want I
 could set up a tinderbox on my desktop and give you a script(1) session
 of it or something like that.
 
 -- 
 IOnut - Unregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 
 BOFH excuse #111:
 The salesman drove over the CPU board
 
 

From: Joe Marcus Clarke <marcus@marcuscom.com>
To: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
Cc: Jean Milanez Melo <jmelo@freebsd.org>, tinderbox-list@marcuscom.com,
        bug-followup@freebsd.org
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on
	c[v]sup
Date: Thu, 06 Apr 2006 01:14:38 -0400

 --=-zgnK5fCHFVNY6dilrov6
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable
 
 On Thu, 2006-04-06 at 01:07 +0300, Ion-Mihai Tetcu wrote:
 >  [ Dropped bug-follow-up ]
 >=20
 > On Wed, 05 Apr 2006 16:56:03 -0400
 > Joe Marcus Clarke <marcus@marcuscom.com> wrote:
 >=20
 > > -----BEGIN PGP SIGNED MESSAGE-----
 > > Hash: SHA1
 > >=20
 > > Ion-Mihai Tetcu wrote:
 > > > On Wed, 05 Apr 2006 12:52:00 -0300
 > > > Jean Milanez Melo <jmelo@FreeBSD.org> wrote:
 > > >=20
 > > >> Dears,
 > > >>
 > > >> I looked the patch last night and i would like to give an advice to =
 you.=20
 > > >> You should apply a patch (eg. with REINPLACE_CMD) in tinderbox scrip=
 t=20
 > > >> when the user choose csup as default updater. Otherwise the user mus=
 t=20
 > > >> pass exact invocation of the update command as itetcu said before.
 > >=20
 > > Please concisely describe the problem for this list.
 >=20
 > You can't use something else that cvsup as update command for port
 > trees or jails. The example in the README doesn't work (it will still
 > try to use cvsup). From glancing at the code it seems -P's values isn't
 > used by ./tc  (and it's used wrong by ./create).
 >=20
 > I don't have my last full session of trial and error, but if you want I
 > could set up a tinderbox on my desktop and give you a script(1) session
 > of it or something like that.
 
 This should be fixed in the 2.X branch in CVS.
 
 Joe
 
 --=20
 PGP Key : http://www.marcuscom.com/pgp.asc
 
 --=-zgnK5fCHFVNY6dilrov6
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2.2 (FreeBSD)
 
 iD8DBQBENKO+b2iPiv4Uz4cRAlskAJ9zfm30RgtjvuPTmaXvYRCnXzb6cQCeJ3fC
 c45VTAbYzkmU9/15PXyUn80=
 =K+p8
 -----END PGP SIGNATURE-----
 
 --=-zgnK5fCHFVNY6dilrov6--
 

From: Jean Milanez Melo <jmelo@freebsdbrasil.com.br>
To: Joe Marcus Clarke <marcus@marcuscom.com>
Cc: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>, 
 Jean Milanez Melo <jmelo@freebsd.org>,
  tinderbox-list@marcuscom.com,  bug-followup@freebsd.org
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on	c[v]sup
Date: Thu, 06 Apr 2006 10:07:31 -0300

 Joe Marcus Clarke wrote:
 > 
 > This should be fixed in the 2.X branch in CVS.
 > 
 > Joe
 > 
 
 Itetcu,
 
 So i think that right thing is wait until 2.X branch in CVS to be 
 released to do this changes on port.
 
 - Jean

From: Sergey Matveychuk <sem@FreeBSD.org>
To: bug-followup@FreeBSD.org,  itetcu@people.tecnik93.com
Cc: jmelo@freebsdbrasil.com.br
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on c[v]sup
Date: Sat, 06 May 2006 01:23:06 +0400

 >  So i think that right thing is wait until 2.X branch in CVS to be 
 >  released to do this changes on port.
 
 But note, the port does not sets up with mysql right now. I've installed
    the port and should change the port to work. And not just me.
 ports/96823 was submitted today.
 
 -- 
 Dixi.
 Sem.

From: Jean Milanez Melo <jmelo@freebsdbrasil.com.br>
To: Sergey Matveychuk <sem@FreeBSD.org>
Cc: bug-followup@FreeBSD.org,  itetcu@people.tecnik93.com
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on c[v]sup
Date: Mon, 08 May 2006 11:10:29 -0300

 Sergey Matveychuk wrote:
 >> So i think that right thing is wait until 2.X branch in CVS to be 
 >> released to do this changes on port.
 > 
 > 
 > But note, the port does not sets up with mysql right now. I've installed
 >    the port and should change the port to work. And not just me.
 > ports/96823 was submitted today.
 > 
 
 Hello sem and itetcu,
 
 I can commit only mysql change on port. Is it ok to you?
 
 If itetcu wants i can assign this PR to him, after all now he's committer ;)
 
 -- 
 Atenciosamente
 Jean Milanez Melo
 FreeBSD Brasil LTDA.
 Fone: (31) 3281-9633
 http://www.freebsdbrasil.com.br

From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
To: Jean Milanez Melo <jmelo@freebsdbrasil.com.br>
Cc: Sergey Matveychuk <sem@FreeBSD.org>, bug-followup@FreeBSD.org
Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on
 c[v]sup
Date: Mon, 8 May 2006 17:27:07 +0300

 On Mon, 08 May 2006 11:10:29 -0300
 Jean Milanez Melo <jmelo@freebsdbrasil.com.br> wrote:
 
 > Sergey Matveychuk wrote:
 > >> So i think that right thing is wait until 2.X branch in CVS to be 
 > >> released to do this changes on port.
 > > 
 > > 
 > > But note, the port does not sets up with mysql right now. I've installed
 > >    the port and should change the port to work. And not just me.
 > > ports/96823 was submitted today.
 > > 
 > 
 > Hello sem and itetcu,
 > 
 > I can commit only mysql change on port. Is it ok to you?
 
 For the time being, yes.
  
 > If itetcu wants i can assign this PR to him, after all now he's committer ;)
 
 Please and thanks.
 
 
 -- 
 IOnut - Un^d^dregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 
 BOFH excuse #259:
 Someone's tie is caught in the printer, and if anything else gets
 printed, he'll be in it too
 
 
Responsible-Changed-From-To: jmelo->itetcu 
Responsible-Changed-By: jmelo 
Responsible-Changed-When: Mon May 8 14:49:20 UTC 2006 
Responsible-Changed-Why:  
Assign PR to submitter, now he's committer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94288 
State-Changed-From-To: feedback->closed 
State-Changed-By: itetcu 
State-Changed-When: Fri May 12 13:51:34 UTC 2006 
State-Changed-Why:  
Committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=94288 
>Unformatted:
