From wielebap@volt.iem.pw.edu.pl  Fri Feb 17 09:34:26 2006
Return-Path: <wielebap@volt.iem.pw.edu.pl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 06D1E16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Feb 2006 09:34:26 +0000 (GMT)
	(envelope-from wielebap@volt.iem.pw.edu.pl)
Received: from volt.iem.pw.edu.pl (volt.iem.pw.edu.pl [194.29.146.3])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5736C43D4C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Feb 2006 09:34:25 +0000 (GMT)
	(envelope-from wielebap@volt.iem.pw.edu.pl)
Received: from volt.iem.pw.edu.pl (wielebap@localhost [127.0.0.1])
	by volt.iem.pw.edu.pl (8.13.4/8.13.1) with ESMTP id k1H9YOfa090035
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Feb 2006 10:34:24 +0100 (CET)
	(envelope-from wielebap@volt.iem.pw.edu.pl)
Received: (from wielebap@localhost)
	by volt.iem.pw.edu.pl (8.13.4/8.13.4/Submit) id k1H9YOwm090034;
	Fri, 17 Feb 2006 10:34:24 +0100 (CET)
	(envelope-from wielebap)
Message-Id: <200602170934.k1H9YOwm090034@volt.iem.pw.edu.pl>
Date: Fri, 17 Feb 2006 10:34:24 +0100 (CET)
From: Pawel Wieleba <P.Wieleba@iem.pw.edu.pl>
Reply-To: Pawel Wieleba <P.Wieleba@iem.pw.edu.pl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] net/samba3; pam_smbpass.so is not added to package file
X-Send-Pr-Version: 3.113
X-GNATS-Notify: timur@gnu.org

>Number:         93470
>Category:       ports
>Synopsis:       [PATCH] net/samba3; pam_smbpass.so is not added to package file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 17 09:40:04 GMT 2006
>Closed-Date:    Wed Apr 05 03:38:37 GMT 2006
>Last-Modified:  Wed Apr 05 03:38:37 GMT 2006
>Originator:     Pawel Wieleba
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD srv 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Mon Oct 31 17:22:48 CET 2005 root@srv:/usr/src/sys/i386/compile/SRV i386
	
>Description:
	If net/samba3 is build with WITH_PAM_SMBASS flag, file pam_smbpass.so is not included in the package file (tbz) after making package 
	
>How-To-Repeat:
	# cd /usr/ports/net/samba3
	# make WITH_PAM_SMBPASS=yes install package
	
>Fix:
	Is quite self explaining.
	


--- Makefile-pam_smbpass.diff begins here ---
--- /usr/ports/net/samba3/Makefile-OLD	Tue Jan 10 23:31:46 2006
+++ /usr/ports/net/samba3/Makefile	Thu Feb 16 21:38:36 2006
@@ -346,7 +346,7 @@
 	${INSTALL_PROGRAM} ${WRKSRC}/nsswitch/pam_winbind.so ${SAMBA_LIBDIR}
 .endif
 .if defined(WITH_PAM_SMBPASS)
-	@${INSTALL_PROGRAM} ${WRKSRC}/bin/pam_smbpass.so ${SAMBA_LIBDIR}
+	${INSTALL_PROGRAM} ${WRKSRC}/bin/pam_smbpass.so ${SAMBA_LIBDIR}
 .endif
 # Lib
 	@${FIND} ${SAMBA_LIBDIR} -type f | ${SED} -e 's|^${PREFIX}||; s|^/||' | ${EGREP} -F -v -f ${WRKDIR}/.PLIST.exclude | ${SORT} >> ${TMPPLIST}
--- Makefile-pam_smbpass.diff ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Feb 17 09:44:10 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93470 

From: Pawel Wieleba <P.Wieleba@iem.pw.edu.pl>
To: Edwin Groothuis <edwin@FreeBSD.org>
Cc:  
Subject: Re: ports/93470: [PATCH] net/samba3; pam_smbpass.so is not added to package file
Date: Sat, 18 Feb 2006 00:18:54 +0100

 Hello!
 
 I've sent this problem report, but the fix does not repair the problem. 
 (By the way commit this fix as it is desired to display command while library is installed as others do)
 
 The source of the problem is dynamic PLIST creation.
 In my system pam_smbpass.so file has already been in /usr/local/lib,
  before installing samba3 and that's way it was classified to .PLIST.exclude file:
 % grep pam_smbpass.so /usr/ports/net/samba3/work/*
 .PLIST.exclude:lib/pam_smbpass.so
 
 Maybe we could think of a smarter dynamic PLIST creation?
 Maybe we could check the creation date of files in one of the statements in post-install section:
 @${FIND} ${SAMBA_LIBDIR} -type f | ${SED} -e 's|^${PREFIX}||; s|^/||' | ${EGREP} -F -v -f ${WRKDIR}/.PLIST.exclude | ${SORT} >> ${TMPPLIST}
 
 Do you have any idea how to repair the problem?
 
 Yours,
 Pawel Wieleba
 
 On Fri, Feb 17, 2006 at 09:44:10AM +0000, Edwin Groothuis wrote:
 > Synopsis: [PATCH] net/samba3; pam_smbpass.so is not added to package file
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: edwin
 > State-Changed-When: Fri Feb 17 09:44:10 UTC 2006
 > State-Changed-Why: 
 > Awaiting maintainers feedback
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=93470
 
 

From: "Timur I. Bakeyev" <timur@gnu.org>
To: bug-followup@FreeBSD.org,  P.Wieleba@iem.pw.edu.pl
Cc:  
Subject: Re: ports/93470: [PATCH] net/samba3; pam_smbpass.so is not added
 to package file
Date: Mon, 20 Feb 2006 03:07:53 +0100

 Hi, Pawel!
 
 I don't see any good solution here, as with experimental modules in 
 place it's difficult to say, which ones will be installed exactly. For 
 the new port I truncated dynamic list to lib/samba/,
 which should reduce number of false positives(one case when such 
 approach is necessary is samba-vscan port, which installs in the same 
 directory). Hope, this will address your
 problem.
 
 In general, it's strange, you got pam_smbpass.so remaining in the 
 directory, as it should be removed by deinstall procedure...
 
 I hope, we can close this PR now, as new port version SEEMS addresses 
 concerns in it.
 
 With best regards,
 Timur.
State-Changed-From-To: feedback->closed 
State-Changed-By: mnag 
State-Changed-When: Wed Apr 5 03:38:35 UTC 2006 
State-Changed-Why:  
Already fixed. Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93470 
>Unformatted:
