From dcp1990@fez.theamigan.net  Sat Feb 11 17:05:13 2006
Return-Path: <dcp1990@fez.theamigan.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 77FDC16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Feb 2006 17:05:13 +0000 (GMT)
	(envelope-from dcp1990@fez.theamigan.net)
Received: from eastrmmtao01.cox.net (eastrmmtao01.cox.net [68.230.240.38])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C5E2D43D49
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Feb 2006 17:05:12 +0000 (GMT)
	(envelope-from dcp1990@fez.theamigan.net)
Received: from styx.theamigan.net ([68.9.18.102]) by eastrmmtao01.cox.net
          (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP
          id <20060211170521.NNGS4894.eastrmmtao01.cox.net@styx.theamigan.net>;
          Sat, 11 Feb 2006 12:05:21 -0500
Received: from fez.theamigan.net (fez.danponte.net [10.10.10.2])
	by styx.theamigan.net (8.13.4/8.13.4) with ESMTP id k1BH5AOM029801;
	Sat, 11 Feb 2006 12:05:11 -0500 (EST)
	(envelope-from dcp1990@fez.theamigan.net)
Received: from fez.theamigan.net (localhost.theamigan.net [127.0.0.1])
	by fez.theamigan.net (8.13.4/8.13.4) with ESMTP id k1BH5AZw032359;
	Sat, 11 Feb 2006 12:05:10 -0500 (EST)
	(envelope-from dcp1990@fez.theamigan.net)
Received: (from root@localhost)
	by fez.theamigan.net (8.13.4/8.13.4/Submit) id k1BH2elv030424;
	Sat, 11 Feb 2006 12:02:40 -0500 (EST)
	(envelope-from dcp1990)
Message-Id: <200602111702.k1BH2elv030424@fez.theamigan.net>
Date: Sat, 11 Feb 2006 12:02:40 -0500 (EST)
From: Dan Ponte <dcp1990@neptune.atopia.net>
Reply-To: Dan Ponte <dcp1990@neptune.atopia.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Dan Ponte <dcp1990@neptune.atopia.net>
Subject: [PATCH] fix audacity build errors on amd64/possibly others
X-Send-Pr-Version: 3.113
X-GNATS-Notify: craig@yekse.gank.org

>Number:         93191
>Category:       ports
>Synopsis:       [PATCH] fix audacity build errors on amd64/possibly others
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 11 17:10:03 GMT 2006
>Closed-Date:    Sat Apr 15 20:10:20 GMT 2006
>Last-Modified:  Sat Apr 15 20:10:20 GMT 2006
>Originator:     Dan Ponte
>Release:        FreeBSD 6.1-PRERELEASE amd64
>Organization:
Unix Users Anonymous
>Environment:
System: FreeBSD fez.theamigan.net 6.1-PRERELEASE FreeBSD 6.1-PRERELEASE #1: Tue Feb 7 20:19:56 EST 2006 root@fez.theamigan.net:/usr/obj/usr/src/sys/FEZ amd64


	wxgtk2-2.6.2_3
>Description:
	Supposedly, audacity is broken on platforms other than i386. I don't see how this problem is related to this, but applying the included patch lets me build and use audacity on my amd64 machine.
>How-To-Repeat:
	Try to build audacity with the above system.
>Fix:
	Apply this patch (from audacity 1.3 CVS audacity/audacity-src/effects/ToneGen.cpp revision 1.22)

--- tonegen.diff begins here ---
--- work/audacity-src-1.2.4b/src/effects/ToneGen.cpp.old	Sat Feb 11 11:53:25 2006
+++ work/audacity-src-1.2.4b/src/effects/ToneGen.cpp	Sat Feb 11 11:52:07 2006
@@ -265,7 +265,7 @@
    item2->Add(item3, 0, wxALIGN_CENTRE | wxALL, 5);
 
    wxChoice *item4 = new wxChoice(parent, ID_WAVEFORM, wxDefaultPosition,
-                                  wxSize(80, -1), 0, NULL);
+                                  wxSize(80, -1), 0, NULL, 0);
    item2->Add(item4, 0, wxALIGN_CENTRE | wxALL, 5);
 
    item0->Add(item2, 1, wxALIGN_CENTRE | wxALL, 5);
--- tonegen.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Feb 11 20:05:16 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93191 

From: Craig Boston <craig@yekse.gank.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/93191: [PATCH] fix audio/audacity build errors on amd64/possibly others
Date: Sat, 11 Feb 2006 17:33:12 -0600

 Thanks for taking the time to track this down, I don't have any 64-bit
 architectures here to test with.  I'm not sure what is different about
 the compiler on amd64 and sparc64 that cause it to be an issue there
 (AFAICT the other constructor for wxChoice shouldn't be a canditate in
 the first place as it doesn't provide the default value).
 
 If this is the only problem preventing builds on 64-bit arch, then
 please commit away and remove BROKEN.
 
 Thanks!
 Craig

From: Ruben de Groot <rdg@bzerk.org>
To: bug-followup@FreeBSD.org, dcp1990@neptune.atopia.net
Cc:  
Subject: Re: ports/93191: [PATCH] fix audacity build errors on amd64/possibly others
Date: Sun, 19 Mar 2006 22:01:39 +0100

 I can confirm that this patch lets me build and use audacity on my amd64.
 
 Please commit
 
 regards,
 Ruben de Groot
 
 -- 
 "Windows' job is to prevent you from shooting yourself in the foot. With
 UNIX, the idea is to make damn sure that there is a hole in your foot
 with the greatest possible efficiency."
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Mon Mar 20 05:17:20 UTC 2006 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93191 
State-Changed-From-To: open->closed 
State-Changed-By: arved 
State-Changed-When: Sat Apr 15 20:10:13 UTC 2006 
State-Changed-Why:  
committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93191 
>Unformatted:
