From nobody@FreeBSD.org  Tue Feb  7 21:25:11 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2A82416A422
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Feb 2006 21:25:11 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E2B5243D45
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Feb 2006 21:25:10 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k17LPA1x048876
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 7 Feb 2006 21:25:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k17LPAha048870;
	Tue, 7 Feb 2006 21:25:10 GMT
	(envelope-from nobody)
Message-Id: <200602072125.k17LPAha048870@www.freebsd.org>
Date: Tue, 7 Feb 2006 21:25:10 GMT
From: Stefan Bethke <stb@lassitu.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] mail/imp clobbers Apache ${PREFIX}/apache2/Includes/
X-Send-Pr-Version: www-2.3

>Number:         92995
>Category:       ports
>Synopsis:       [patch] mail/imp clobbers Apache ${PREFIX}/apache2/Includes/
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    thierry
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 07 21:30:12 GMT 2006
>Closed-Date:    Thu Feb 16 22:31:45 GMT 2006
>Last-Modified:  Thu Feb 16 22:31:45 GMT 2006
>Originator:     Stefan Bethke
>Release:        6-stable
>Organization:
>Environment:
FreeBSD koef.zs64.net 6.0-STABLE FreeBSD 6.0-STABLE #4: Thu Jan 12 15:59:51 CET 2006     root@lokschuppen.zs64.net:/usr/obj/usr/src/sys/EISENBOOT  i386

>Description:
Since I'm not using the default include mechanism that the Apache 2.0 port provides, I removed the ${PREFIX}/etc/apache2/Includes directory. When I subsequently installed IMP, instead of installing the IMP include file in that subdir, it created a new file under that name.

When I then tried to upgrade the www/apache20 port (through portupgrade or manually), the install target failed to create a new Includes directory because the file was in the way.

The IMP port should not create a file where a directory is expected.

With the patch, the install fails with an appropriate error message:

===>   imp-4.0.4_1 depends on file: /usr/local/bin/deliverquota - found
===>   imp-4.0.4_1 depends on file: /usr/local/sbin/apxs - found
===>   Generating temporary packing list
===>  Checking if mail/imp already installed
install: /usr/local/etc/apache2/Includes/: No such file or directory
*** Error code 71

Stop in /usr/ports/mail/imp.

>How-To-Repeat:
1. Install www/apache20
2. rmdir ${PREFIX}/etc/apache2/Includes
3. Install mail/imp
4. Re-install www/apache20

>Fix:
$ diff -u Makefile.orig  Makefile
--- Makefile.orig       Fri Jan  6 01:38:12 2006
+++ Makefile    Tue Feb  7 22:10:56 2006
@@ -158,9 +158,9 @@
 .endif
 
 .if ${APACHE_VERSION} >= 20
-HORDE_INC=     ${LOCALBASE}/etc/apache${APACHE_VERSION:S/20/2/}/Includes
+HORDE_INC=     ${LOCALBASE}/etc/apache${APACHE_VERSION:S/20/2/}/Includes/
 .else
-HORDE_INC=     ${LOCALBASE}/etc/horde
+HORDE_INC=     ${LOCALBASE}/etc/horde/
 .endif
 
 pre-everything::

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->thierry 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Feb 7 21:32:09 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92995 
State-Changed-From-To: open->closed 
State-Changed-By: thierry 
State-Changed-When: Thu Feb 16 22:29:50 UTC 2006 
State-Changed-Why:  

Committed, thanks. 

Note: you should not remove a directory created by a port, when you 
will upgrade Apache, it will be recreated. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=92995 
>Unformatted:
