From nobody@FreeBSD.org  Mon Feb  6 19:07:52 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CE65F16A420
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  6 Feb 2006 19:07:52 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6556643D4C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  6 Feb 2006 19:07:52 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k16J7q4i053378
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 6 Feb 2006 19:07:52 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k16J7q5R053377;
	Mon, 6 Feb 2006 19:07:52 GMT
	(envelope-from nobody)
Message-Id: <200602061907.k16J7q5R053377@www.freebsd.org>
Date: Mon, 6 Feb 2006 19:07:52 GMT
From: Victor Snezhko <snezhko@indorsoft.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] x11-wm/sawfish2 writes 1 byte beyond allocated memory
X-Send-Pr-Version: www-2.3

>Number:         92912
>Category:       ports
>Synopsis:       [patch] x11-wm/sawfish2 writes 1 byte beyond allocated memory
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 06 19:10:04 GMT 2006
>Closed-Date:    Wed Feb 08 03:39:32 GMT 2006
>Last-Modified:  Wed Feb 08 03:39:32 GMT 2006
>Originator:     Victor Snezhko
>Release:        7.0-CURRENT
>Organization:
IndorSoft Ltd.
>Environment:
FreeBSD freebsd.indorsoft.ru 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Sat Jan 21 08:03:26 NOVT 2006     root@freebsd.indorsoft.ru:/home/vvs/obj/usr/src/sys/VVS  i386

>Description:
src/fonts.c contains the following code:
            buf = malloc (len);
            memcpy (buf, p + 1, len);
            buf[len] = 0;

after the new malloc code has been committed to -current (with debugging enabled by default), sawfish fails to start due to this error.
>How-To-Repeat:
Install x11-wm/sawfish2 on a 7.0-CURRENT box cvsupped after Jan 13, 2006.
It will not start.
>Fix:
we need to add this patch:
vvs@freebsd$ cat /usr/ports/x11-wm/sawfish2/files/patch-src\:\:fonts.c 
--- src/fonts.c.orig    Tue Feb  7 00:15:27 2006
+++ src/fonts.c Tue Feb  7 00:15:37 2006
@@ -131,7 +131,7 @@
            if (end == 0)
                end = p + strlen (p);
            len = end - (p + 1);
-           buf = malloc (len);
+           buf = malloc (len + 1);
            memcpy (buf, p + 1, len);
            buf[len] = 0;
            return buf;

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Feb 6 19:12:34 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92912 
State-Changed-From-To: open->closed 
State-Changed-By: jylefort 
State-Changed-When: Wed Feb 8 03:39:27 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92912 
>Unformatted:
