From leeym@utopia.leeym.com  Sun Feb  5 15:29:50 2006
Return-Path: <leeym@utopia.leeym.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5CD3216A420;
	Sun,  5 Feb 2006 15:29:50 +0000 (GMT)
	(envelope-from leeym@utopia.leeym.com)
Received: from msr7.hinet.net (msr7.hinet.net [168.95.4.107])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 934AD43D46;
	Sun,  5 Feb 2006 15:29:49 +0000 (GMT)
	(envelope-from leeym@utopia.leeym.com)
Received: from utopia.leeym.com (utopia.leeym.com [211.21.137.52])
	by msr7.hinet.net (8.9.3/8.9.3) with ESMTP id XAA03133;
	Sun, 5 Feb 2006 23:29:45 +0800 (CST)
Received: from localhost (localhost [127.0.0.1])
	by utopia.leeym.com (Postfix) with ESMTP id AA0D7B29CCA;
	Sun,  5 Feb 2006 23:29:44 +0800 (CST)
Received: from utopia.leeym.com ([127.0.0.1])
 by localhost (utopia.leeym.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 16600-03; Sun,  5 Feb 2006 23:29:40 +0800 (CST)
Received: by utopia.leeym.com (Postfix, from userid 1000)
	id 0DC5CB29CC8; Sun,  5 Feb 2006 23:29:40 +0800 (CST)
Message-Id: <20060205152940.0DC5CB29CC8@utopia.leeym.com>
Date: Sun,  5 Feb 2006 23:29:40 +0800 (CST)
From: Yen-Ming Lee <leeym@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: gnome@freebsd.org
Subject: [PATCH] devel/dbus: minor fixes
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         92844
>Category:       ports
>Synopsis:       [PATCH] devel/dbus: minor fixes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 05 15:30:03 GMT 2006
>Closed-Date:    Tue Feb 14 17:51:34 GMT 2006
>Last-Modified:  Wed Feb 15 00:00:21 GMT 2006
>Originator:     Yen-Ming Lee
>Release:        FreeBSD 6.1-PRERELEASE i386
>Organization:
FreeBSD Taiwan
>Environment:
System: FreeBSD utopia.leeym.com 6.1-PRERELEASE FreeBSD 6.1-PRERELEASE #0: Fri Feb  3 08:02:39 CST
>Description:
- fix plist (without --localstatedir=/var, it will create /usr/local/var/run)
- minor fixes to make portlint happier

Port maintainer (gnome@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

--- dbus-0.60_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/dbus/Makefile,v
retrieving revision 1.41
diff -u -u -r1.41 Makefile
--- Makefile	30 Jan 2006 23:19:52 -0000	1.41
+++ Makefile	5 Feb 2006 15:28:40 -0000
@@ -22,13 +22,13 @@
 USE_AUTOTOOLS=	libtool:15
 INSTALLS_SHLIB=	yes
 USE_RC_SUBR=	yes
-USE_REINPLACE=	yes
 CONFIGURE_ARGS?=--disable-gtk \
 		--disable-python \
 		--disable-gcj \
 		--disable-qt \
 		--disable-mono \
 		--disable-mono-docs \
+		--localstatedir=/var \
 		--with-system-pid-file=/var/run/dbus.pid \
 		--with-system-socket=/var/run/dbus \
 		--with-session-socket-dir=/var/tmp \
@@ -77,7 +77,7 @@
 .if defined(PKGNAMEPREFIX)
 .if ${PKGNAMEPREFIX}==${PYTHON_PKGNAMEPREFIX} && ${OSVERSION} < 500000
 # Ignore for py-dbus
-IGNORE=	Does not build on 4.X
+IGNORE=	does not build on 4.X
 .endif
 .endif
 
--- dbus-0.60_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Feb 5 15:32:13 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92844 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Tue Feb 14 17:51:21 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92844 

From: Pascal Hofstee <caelian@gmail.com>
To: bug-followup@FreeBSD.org, leeym@freebsd.org
Cc:  
Subject: Re: ports/92844: [PATCH] devel/dbus: minor fixes
Date: Tue, 14 Feb 2006 15:50:27 -0800

 ------=_Part_7775_3484170.1139961027744
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline
 
 This commit actually breaks the dbus port.
 
 By setting localstatedir to /var .. the port is trying to "mkdir
 /var/run/dbus"  for its localstatedir during the install phase. However
 /var/run/dbus is at the same time used as the name for the dbus-socket.
 
 This is an obvious naming conflict that breaks a portupgrade (when the
 dbus-socket already exists), or if the socket does not exist during
 installation, causes dbus to be unable to start because the new
 /var/run/dbus/ localstatedir triggers dbus launch to think it's already
 running because its "socket" already exists.
 
 The proper solution is likely to resolve this path-conflict by either
 renaming the dbus-socket .. or putting it Inside the new localstatedir.
 
 --
   Pascal Hofstee
 
 ------=_Part_7775_3484170.1139961027744
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline
 
 This commit actually breaks the dbus port.<br><br>By setting localstatedir =
 to /var .. the port is trying to &quot;mkdir /var/run/dbus&quot;&nbsp; for =
 its localstatedir during the install phase. However /var/run/dbus is at the=
  same time used as the name for the dbus-socket.
 <br><br>This is an obvious naming conflict that breaks a portupgrade (when =
 the dbus-socket already exists), or if the socket does not exist during ins=
 tallation, causes dbus to be unable to start because the new /var/run/dbus/=
  localstatedir triggers dbus launch to think it's already running because i=
 ts &quot;socket&quot; already exists.
 <br><br>The proper solution is likely to resolve this path-conflict by eith=
 er renaming the dbus-socket .. or putting it Inside the new localstatedir.<=
 br><br>-- <br>&nbsp; Pascal Hofstee<br>
 
 ------=_Part_7775_3484170.1139961027744--
>Unformatted:
