From lth@dask.thegler.dk  Mon Jan 30 14:19:47 2006
Return-Path: <lth@dask.thegler.dk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 77A0716A420;
	Mon, 30 Jan 2006 14:19:47 +0000 (GMT)
	(envelope-from lth@dask.thegler.dk)
Received: from cicero0.cybercity.dk (cicero0.cybercity.dk [212.242.40.52])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E424543D53;
	Mon, 30 Jan 2006 14:19:46 +0000 (GMT)
	(envelope-from lth@dask.thegler.dk)
Received: from dask.thegler.dk (port456.ds1-bav.adsl.cybercity.dk [212.242.213.149])
	by cicero0.cybercity.dk (Postfix) with ESMTP id 3DCBC67847D;
	Mon, 30 Jan 2006 15:19:44 +0100 (CET)
Received: by dask.thegler.dk (Postfix, from userid 1001)
	id 67C873F50; Mon, 30 Jan 2006 15:19:44 +0100 (CET)
Message-Id: <20060130141944.67C873F50@dask.thegler.dk>
Date: Mon, 30 Jan 2006 15:19:44 +0100 (CET)
From: Lars Thegler <lth@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: ahze@FreeBSD.org
Subject: [PATCH] textproc/p5-xmltv: Fix 'bad makefile line' error
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         92548
>Category:       ports
>Synopsis:       [PATCH] textproc/p5-xmltv: Fix 'bad makefile line' error
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ahze
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 30 14:20:02 GMT 2006
>Closed-Date:    Fri Dec 08 13:18:04 GMT 2006
>Last-Modified:  Fri Dec 08 13:18:04 GMT 2006
>Originator:     Lars Thegler
>Release:        FreeBSD 4.11-STABLE i386
>Organization:
>Environment:
System: FreeBSD dask.thegler.dk 4.11-STABLE FreeBSD 4.11-STABLE #6: Thu Dec 30 14:06:09 CET 2004
>Description:
1) During the build phase, p5-xmltv fails with:

--cut--
bad makefile line: '    $(NOECHO) $(NOOP)' at ./Makefile.PL line 1031.
*** Error code 2
--cut--

This is probably due to newer versions of ExtUtils::MakeMaker
starting to use spaces instead of the traditional tabs in the
generated Makefile. The attached patch to Makefile.PL fixes this.

2) Also, the current build complains:

--cut--
Warning: the following files are missing in your kit:
        META.yml
Please inform the author.
--cut--

The new patchfile against MAINFEST fixes this. This is only a
warning, so can be ignored if you like.


Added file(s):
- files/patch-MANIFEST

Port maintainer (ahze@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

--- p5-xmltv-0.5.41_1.patch begins here ---
Index: files/patch-MANIFEST
===================================================================
RCS file: files/patch-MANIFEST
diff -N files/patch-MANIFEST
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-MANIFEST	30 Jan 2006 14:12:20 -0000
@@ -0,0 +1,7 @@
+--- MANIFEST.orig	Mon Jan 30 14:54:45 2006
++++ MANIFEST	Mon Jan 30 14:54:59 2006
+@@ -1246,4 +1246,3 @@
+ t/data/tv_sort_test_remove_some_overlapping_xml.expected
+ t/data/tv_to_latex_test_remove_some_overlapping_xml.expected
+ t/data/tv_to_text_test_remove_some_overlapping_xml.expected
+-META.yml                                 Module meta-data (added by MakeMaker)
Index: files/patch-Makefile.PL
===================================================================
RCS file: /home/pcvs/ports/textproc/p5-xmltv/files/patch-Makefile.PL,v
retrieving revision 1.3
diff -u -u -r1.3 patch-Makefile.PL
--- files/patch-Makefile.PL	28 Nov 2004 14:35:02 -0000	1.3
+++ files/patch-Makefile.PL	30 Jan 2006 14:12:20 -0000
@@ -1,6 +1,6 @@
---- Makefile.PL.orig	Mon Oct 25 02:33:47 2004
-+++ Makefile.PL	Fri Nov 26 15:29:30 2004
-@@ -466,14 +466,14 @@
+--- Makefile.PL.orig	Mon Jan 30 14:53:32 2006
++++ Makefile.PL	Mon Jan 30 14:54:19 2006
+@@ -537,14 +537,14 @@
  	# Guess a default value for {install} based on whether
  	# prerequisites were found.
  	#
@@ -17,7 +17,7 @@
  	# Need to set {install} for each component by prompting.
  	foreach my $info (@opt_components) {
  	    my $missing = $info->{missing};
-@@ -502,8 +502,8 @@
+@@ -573,8 +573,8 @@
  		die;
  	    }
  	
@@ -28,3 +28,12 @@
  	}
      }
  }
+@@ -1019,7 +1019,7 @@
+ 	    die "target $name seen twice" if defined $r{$name};
+ 	    $r{$name} = $curr_target = [];
+ 	}
+-	elsif (/^\t/ and defined $curr_target) {
++	elsif (/^\s/ and defined $curr_target) {
+ 	    # Commands for the target.
+ 	    push @$curr_target, $_;
+ 	}
--- p5-xmltv-0.5.41_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ahze 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jan 30 14:24:16 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92548 
State-Changed-From-To: open->feedback  
State-Changed-By: ahze 
State-Changed-When: Sun Sep 10 19:31:28 UTC 2006 
State-Changed-Why:  
Is this still a problem with the newest version in ports (0.5.44) ? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92548 
State-Changed-From-To: feedback->closed  
State-Changed-By: ahze 
State-Changed-When: Fri Dec 8 13:17:31 UTC 2006 
State-Changed-Why:  
Feedback timeout (2+ months) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92548 
>Unformatted:
