From nobody@FreeBSD.org  Thu Jan 26 02:33:02 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 97D0516A420
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 26 Jan 2006 02:33:02 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 64DE343D48
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 26 Jan 2006 02:33:02 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k0Q2X2Fp041579
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 26 Jan 2006 02:33:02 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k0Q2X2Im041578;
	Thu, 26 Jan 2006 02:33:02 GMT
	(envelope-from nobody)
Message-Id: <200601260233.k0Q2X2Im041578@www.freebsd.org>
Date: Thu, 26 Jan 2006 02:33:02 GMT
From: Tom Pavel <pavel@alum.mit.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: xosview port has a memory leak
X-Send-Pr-Version: www-2.3

>Number:         92339
>Category:       ports
>Synopsis:       xosview port has a memory leak
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    clsung
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 26 02:40:02 GMT 2006
>Closed-Date:    Fri Jan 27 08:18:09 GMT 2006
>Last-Modified:  Fri Jan 27 08:18:09 GMT 2006
>Originator:     Tom Pavel
>Release:        6.0-RELEASE
>Organization:
Network Physics
>Environment:
FreeBSD valiant.fractal.networkphysics.com 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Thu Nov  3 09:36:13 UTC 2005     root@x64.samsco.home:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
The sysutils/xosview port that comes with 6.0 results in a memory leak that eventually crashes the xosview process.  The CVS tree doesn't show any activity here more recent than 6.0.  The attached extra patch to bsd/kernel.cc fixes the problem. 
>How-To-Repeat:
              
>Fix:
--- work/xosview-1.8.2/bsd/kernel.cc.save       Thu Jan 19 14:26:39 2006
+++ work/xosview-1.8.2/bsd/kernel.cc    Fri Jan 20 16:35:35 2006
@@ -1006,8 +1006,8 @@
     }
 #else /* FreeBSD 5.x and 6.x */
     /* This code is stolen from vmstat */
-    unsigned long *kvm_intrcnt;
-    char *kvm_intrname;
+    unsigned long *kvm_intrcnt, *base_intrcnt;
+    char *kvm_intrname, *base_intrname;
     size_t inamlen, intrcntlen;
     unsigned int i, nintr;
     int d;
@@ -1020,6 +1020,10 @@
        ((kvm_intrname = (char *)malloc(inamlen)) == NULL))
       err(1, "malloc()");

+    // keep track of the mem we're given:
+    base_intrcnt = kvm_intrcnt;
+    base_intrname = kvm_intrname;
+
     safe_kvm_read (nlst[INTRCNT_SYM_INDEX].n_value, kvm_intrcnt, intrcntlen);
     safe_kvm_read (nlst[INTRNAMES_SYM_INDEX].n_value, kvm_intrname, inamlen);

@@ -1035,6 +1039,10 @@
        kvm_intrcnt++;
        kvm_intrname += strlen(kvm_intrname) + 1;
     }
+
+    // Doh! somebody needs to free this stuff too... (pavel 20-Jan-2006)
+    free(base_intrcnt);
+    free(base_intrname);
 #endif
 #elif defined (XOSVIEW_BSDI)
     int nintr = 16;

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->clsung 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Jan 26 11:14:32 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92339 
State-Changed-From-To: open->closed 
State-Changed-By: clsung 
State-Changed-When: Fri Jan 27 08:18:07 UTC 2006 
State-Changed-Why:  
Committed. Thank You. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92339 
>Unformatted:
